From: Al Viro <viro@zeniv.linux.org.uk>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-fsdevel@vger.kernel.org, p.raghav@samsung.com,
hch@infradead.org, john.johansen@canonical.com,
dhowells@redhat.com
Subject: Re: [RFC 3/3] fs: remove old MS_* internal flags for the superblock
Date: Tue, 10 Jan 2023 23:54:15 +0000 [thread overview]
Message-ID: <Y736p/ChILQE5a9X@ZenIV> (raw)
In-Reply-To: <20230110022554.1186499-4-mcgrof@kernel.org>
On Mon, Jan 09, 2023 at 06:25:54PM -0800, Luis Chamberlain wrote:
> During commit e462ec50cb5 ("VFS: Differentiate mount flags (MS_*) from
> internal superblock flags") Christoph had suggested we should eventually
> remove these old flags which were exposed to userspace but could not
> be used as they were internal-only.
>
> Nuke them.
Umm... They are still exposed to userland after your series, though.
IOW, we can't change the bit assignment of e.g. SB_ACTIVE - the apparmor
part will break, etc.
If anything, it would be more honest to lift the "we ignore those bits"
logics to path_mount()...
prev parent reply other threads:[~2023-01-10 23:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-10 2:25 [RFC 0/3] fs: kill old ms_* flags for internal sb Luis Chamberlain
2023-01-10 2:25 ` [RFC 1/3] apparmor: use SB_* flags for private sb flags Luis Chamberlain
2023-01-10 23:40 ` Al Viro
2023-01-10 2:25 ` [RFC 2/3] fs: use SB_NOUSER on path_mount() instead of deprecated MS_NOUSER Luis Chamberlain
2023-01-10 23:43 ` Al Viro
2023-01-10 2:25 ` [RFC 3/3] fs: remove old MS_* internal flags for the superblock Luis Chamberlain
2023-01-10 23:54 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y736p/ChILQE5a9X@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=dhowells@redhat.com \
--cc=hch@infradead.org \
--cc=john.johansen@canonical.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=p.raghav@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.