From: Bjorn Helgaas <helgaas@kernel.org>
To: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>
Cc: netdev@vger.kernel.org, linux-pci@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-mips@vger.kernel.org,
linux-trace-kernel@vger.kernel.org, sparclinux@vger.kernel.org,
Leon Romanovsky <leon@kernel.org>
Subject: Re: [PATCH net-next 2/7] PCI: Remove PCI IDs used by the Sun Cassini driver
Date: Tue, 10 Jan 2023 09:26:06 -0600 [thread overview]
Message-ID: <20230110152606.GA1504608@bhelgaas> (raw)
In-Reply-To: <20230106220020.1820147-3-anirudh.venkataramanan@intel.com>
On Fri, Jan 06, 2023 at 02:00:15PM -0800, Anirudh Venkataramanan wrote:
> The previous patch removed the Cassini driver (drivers/net/ethernet/sun).
> With this, PCI_DEVICE_ID_NS_SATURN and PCI_DEVICE_ID_SUN_CASSINI are
> unused. Remove them.
>
> Cc: Leon Romanovsky <leon@kernel.org>
> Signed-off-by: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>
> ---
> include/linux/pci_ids.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> index b362d90..eca2340 100644
> --- a/include/linux/pci_ids.h
> +++ b/include/linux/pci_ids.h
> @@ -433,7 +433,6 @@
> #define PCI_DEVICE_ID_NS_CS5535_AUDIO 0x002e
> #define PCI_DEVICE_ID_NS_CS5535_USB 0x002f
> #define PCI_DEVICE_ID_NS_GX_VIDEO 0x0030
> -#define PCI_DEVICE_ID_NS_SATURN 0x0035
> #define PCI_DEVICE_ID_NS_SCx200_BRIDGE 0x0500
> #define PCI_DEVICE_ID_NS_SCx200_SMI 0x0501
> #define PCI_DEVICE_ID_NS_SCx200_IDE 0x0502
> @@ -1047,7 +1046,6 @@
> #define PCI_DEVICE_ID_SUN_SABRE 0xa000
> #define PCI_DEVICE_ID_SUN_HUMMINGBIRD 0xa001
> #define PCI_DEVICE_ID_SUN_TOMATILLO 0xa801
> -#define PCI_DEVICE_ID_SUN_CASSINI 0xabba
I don't think there's value in removing these definitions. I would
just leave them alone.
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Helgaas <helgaas@kernel.org>
To: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>
Cc: Leon Romanovsky <leon@kernel.org>,
netdev@vger.kernel.org, linux-mips@vger.kernel.org,
linux-pci@vger.kernel.org, sparclinux@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org,
linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 2/7] PCI: Remove PCI IDs used by the Sun Cassini driver
Date: Tue, 10 Jan 2023 09:26:06 -0600 [thread overview]
Message-ID: <20230110152606.GA1504608@bhelgaas> (raw)
In-Reply-To: <20230106220020.1820147-3-anirudh.venkataramanan@intel.com>
On Fri, Jan 06, 2023 at 02:00:15PM -0800, Anirudh Venkataramanan wrote:
> The previous patch removed the Cassini driver (drivers/net/ethernet/sun).
> With this, PCI_DEVICE_ID_NS_SATURN and PCI_DEVICE_ID_SUN_CASSINI are
> unused. Remove them.
>
> Cc: Leon Romanovsky <leon@kernel.org>
> Signed-off-by: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>
> ---
> include/linux/pci_ids.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> index b362d90..eca2340 100644
> --- a/include/linux/pci_ids.h
> +++ b/include/linux/pci_ids.h
> @@ -433,7 +433,6 @@
> #define PCI_DEVICE_ID_NS_CS5535_AUDIO 0x002e
> #define PCI_DEVICE_ID_NS_CS5535_USB 0x002f
> #define PCI_DEVICE_ID_NS_GX_VIDEO 0x0030
> -#define PCI_DEVICE_ID_NS_SATURN 0x0035
> #define PCI_DEVICE_ID_NS_SCx200_BRIDGE 0x0500
> #define PCI_DEVICE_ID_NS_SCx200_SMI 0x0501
> #define PCI_DEVICE_ID_NS_SCx200_IDE 0x0502
> @@ -1047,7 +1046,6 @@
> #define PCI_DEVICE_ID_SUN_SABRE 0xa000
> #define PCI_DEVICE_ID_SUN_HUMMINGBIRD 0xa001
> #define PCI_DEVICE_ID_SUN_TOMATILLO 0xa801
> -#define PCI_DEVICE_ID_SUN_CASSINI 0xabba
I don't think there's value in removing these definitions. I would
just leave them alone.
next prev parent reply other threads:[~2023-01-10 15:27 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-06 22:00 [PATCH net-next 0/7] Remove three Sun net drivers Anirudh Venkataramanan
2023-01-06 22:00 ` Anirudh Venkataramanan
2023-01-06 22:00 ` [PATCH net-next 1/7] ethernet: Remove the Sun Cassini driver Anirudh Venkataramanan
2023-01-06 22:00 ` Anirudh Venkataramanan
2023-01-07 12:25 ` Anatoly Pugachev
2023-01-07 12:25 ` Anatoly Pugachev
2023-01-07 19:16 ` Anirudh Venkataramanan
2023-01-07 19:16 ` Anirudh Venkataramanan
2023-01-06 22:00 ` [PATCH net-next 2/7] PCI: Remove PCI IDs used by " Anirudh Venkataramanan
2023-01-06 22:00 ` Anirudh Venkataramanan
2023-01-10 15:26 ` Bjorn Helgaas [this message]
2023-01-10 15:26 ` Bjorn Helgaas
2023-01-10 16:51 ` Anirudh Venkataramanan
2023-01-10 16:51 ` Anirudh Venkataramanan
2023-01-06 22:00 ` [PATCH net-next 3/7] powerpc: configs: Remove reference to CONFIG_CASSINI Anirudh Venkataramanan
2023-01-06 22:00 ` Anirudh Venkataramanan
2023-01-06 22:00 ` [PATCH net-next 4/7] mips: " Anirudh Venkataramanan
2023-01-06 22:00 ` Anirudh Venkataramanan
2023-01-06 22:00 ` [PATCH net-next 5/7] ethernet: Remove the Sun LDOM vswitch and sunvnet drivers Anirudh Venkataramanan
2023-01-06 22:00 ` Anirudh Venkataramanan
2023-01-06 22:00 ` [PATCH net-next 6/7] sunvnet: Remove event tracing file Anirudh Venkataramanan
2023-01-06 22:00 ` Anirudh Venkataramanan
2023-01-06 22:00 ` [PATCH net-next 7/7] sparc: configs: Remove references to CONFIG_SUNVNET and CONFIG_LDMVSW Anirudh Venkataramanan
2023-01-06 22:00 ` Anirudh Venkataramanan
2023-01-07 12:14 ` Anatoly Pugachev
2023-01-07 12:14 ` Anatoly Pugachev
2023-01-06 22:44 ` [PATCH net-next 0/7] Remove three Sun net drivers Karl Volz
2023-01-06 22:44 ` Karl Volz
2023-01-06 23:10 ` Anirudh Venkataramanan
2023-01-06 23:10 ` Anirudh Venkataramanan
2023-01-06 23:25 ` Karl Volz
2023-01-06 23:25 ` Karl Volz
2023-01-07 1:36 ` John Paul Adrian Glaubitz
2023-01-07 1:36 ` John Paul Adrian Glaubitz
2023-01-07 2:04 ` Anirudh Venkataramanan
2023-01-07 2:04 ` Anirudh Venkataramanan
2023-01-07 2:15 ` Jakub Kicinski
2023-01-07 2:15 ` Jakub Kicinski
2023-01-07 2:24 ` John Paul Adrian Glaubitz
2023-01-07 2:24 ` John Paul Adrian Glaubitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230110152606.GA1504608@bhelgaas \
--to=helgaas@kernel.org \
--cc=anirudh.venkataramanan@intel.com \
--cc=leon@kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.