* [PATCH] tests: Fix help test to reflect updated help output
@ 2023-01-10 21:02 Glenn Washburn
2023-01-11 18:48 ` Daniel Kiper
0 siblings, 1 reply; 3+ messages in thread
From: Glenn Washburn @ 2023-01-10 21:02 UTC (permalink / raw)
To: grub-devel, Daniel Kiper; +Cc: Glenn Washburn
Commit f5759a878 (normal/help: Add paging instructions to normal and help
prompts) changed the output of the help command, which broke the help
test. This change allows the test to pass.
Signed-off-by: Glenn Washburn <development@efficientek.com>
---
tests/help_test.in | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/help_test.in b/tests/help_test.in
index b08cf20138..630e9860ae 100644
--- a/tests/help_test.in
+++ b/tests/help_test.in
@@ -8,6 +8,9 @@ Show a help message.
-h, --help Display this help and exit.
-u, --usage Display the usage of this command and exit.
+
+
+To enable less(1)-like paging, \"set pager=1\".
Hello World"
outpu="$(echo 'help help; hello' | @builddir@/grub-shell)"
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] tests: Fix help test to reflect updated help output
2023-01-10 21:02 [PATCH] tests: Fix help test to reflect updated help output Glenn Washburn
@ 2023-01-11 18:48 ` Daniel Kiper
2023-01-11 23:10 ` Glenn Washburn
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Kiper @ 2023-01-11 18:48 UTC (permalink / raw)
To: Glenn Washburn; +Cc: grub-devel
On Tue, Jan 10, 2023 at 03:02:15PM -0600, Glenn Washburn wrote:
> Commit f5759a878 (normal/help: Add paging instructions to normal and help
> prompts) changed the output of the help command, which broke the help
> test. This change allows the test to pass.
>
> Signed-off-by: Glenn Washburn <development@efficientek.com>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
... but...
> ---
> tests/help_test.in | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tests/help_test.in b/tests/help_test.in
> index b08cf20138..630e9860ae 100644
> --- a/tests/help_test.in
> +++ b/tests/help_test.in
> @@ -8,6 +8,9 @@ Show a help message.
>
> -h, --help Display this help and exit.
> -u, --usage Display the usage of this command and exit.
> +
> +
> +To enable less(1)-like paging, \"set pager=1\".
> Hello World"
> outpu="$(echo 'help help; hello' | @builddir@/grub-shell)"
We could do s/outpu/output/ on the occasion. I can do it before the push...
Daniel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] tests: Fix help test to reflect updated help output
2023-01-11 18:48 ` Daniel Kiper
@ 2023-01-11 23:10 ` Glenn Washburn
0 siblings, 0 replies; 3+ messages in thread
From: Glenn Washburn @ 2023-01-11 23:10 UTC (permalink / raw)
To: Daniel Kiper; +Cc: grub-devel
On Wed, 11 Jan 2023 19:48:06 +0100
Daniel Kiper <dkiper@net-space.pl> wrote:
> On Tue, Jan 10, 2023 at 03:02:15PM -0600, Glenn Washburn wrote:
> > Commit f5759a878 (normal/help: Add paging instructions to normal
> > and help prompts) changed the output of the help command, which
> > broke the help test. This change allows the test to pass.
> >
> > Signed-off-by: Glenn Washburn <development@efficientek.com>
>
> Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
>
> ... but...
>
> > ---
> > tests/help_test.in | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/tests/help_test.in b/tests/help_test.in
> > index b08cf20138..630e9860ae 100644
> > --- a/tests/help_test.in
> > +++ b/tests/help_test.in
> > @@ -8,6 +8,9 @@ Show a help message.
> >
> > -h, --help Display this help and exit.
> > -u, --usage Display the usage of this command and exit.
> > +
> > +
> > +To enable less(1)-like paging, \"set pager=1\".
> > Hello World"
> > outpu="$(echo 'help help; hello' | @builddir@/grub-shell)"
>
> We could do s/outpu/output/ on the occasion. I can do it before the
> push...
Sure thing, go ahead.
Glenn
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-11 23:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-10 21:02 [PATCH] tests: Fix help test to reflect updated help output Glenn Washburn
2023-01-11 18:48 ` Daniel Kiper
2023-01-11 23:10 ` Glenn Washburn
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.