All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
	Stephen Boyd <swboyd@chromium.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	dri-devel@lists.freedesktop.org, Sean Paul <sean@poorly.run>,
	linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org,
	David Airlie <airlied@gmail.com>,
	devicetree@vger.kernel.org,
	Bjorn Andersson <andersson@kernel.org>,
	Rob Clark <robdclark@gmail.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Daniel Vetter <daniel@ffwll.ch>,
	Abhinav Kumar <quic_abhinavk@quicinc.com>
Subject: Re: [PATCH v6 01/11] dt-bindings: display/msm: convert MDP5 schema to YAML format
Date: Fri, 13 Jan 2023 15:11:14 -0600	[thread overview]
Message-ID: <20230113211114.GA2925393-robh@kernel.org> (raw)
In-Reply-To: <167362343145.2212490.16180994187587985655.robh@kernel.org>

On Fri, Jan 13, 2023 at 09:26:52AM -0600, Rob Herring wrote:
> 
> On Fri, 13 Jan 2023 10:37:10 +0200, Dmitry Baryshkov wrote:
> > Convert the mdp5.txt into the yaml format. Changes to the existing (txt) schema:
> >  - MSM8996 has additional "iommu" clock, define it separately
> >  - Add new properties used on some of platforms:
> >    - interconnects, interconnect-names
> >    - iommus
> >    - power-domains
> >    - operating-points-v2, opp-table
> > 
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> > ---
> >  .../devicetree/bindings/display/msm/mdp5.txt  | 132 -----------------
> >  .../bindings/display/msm/qcom,mdp5.yaml       | 138 ++++++++++++++++++
> >  2 files changed, 138 insertions(+), 132 deletions(-)
> >  delete mode 100644 Documentation/devicetree/bindings/display/msm/mdp5.txt
> >  create mode 100644 Documentation/devicetree/bindings/display/msm/qcom,mdp5.yaml
> > 
> 
> Running 'make dtbs_check' with the schema in this patch gives the
> following warnings. Consider if they are expected or the schema is
> incorrect. These may not be new warnings.
> 
> Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> This will change in the future.
> 
> Full log is available here: https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230113083720.39224-2-dmitry.baryshkov@linaro.org
> 
> 
> mdp@1a01000: compatible:0: 'qcom,mdp5' was expected
> 	arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dtb
> 
> mdp@1a01000: compatible: ['qcom,msm8953-mdp5', 'qcom,mdp5'] is too long
> 	arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dtb

If your thought is to drop 'qcom,msm8953-mdp5' here that doesn't really 
seem great.

Rob

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: freedreno@lists.freedesktop.org, devicetree@vger.kernel.org,
	linux-arm-msm@vger.kernel.org,
	Bjorn Andersson <andersson@kernel.org>,
	Abhinav Kumar <quic_abhinavk@quicinc.com>,
	dri-devel@lists.freedesktop.org,
	Stephen Boyd <swboyd@chromium.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Andy Gross <agross@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Sean Paul <sean@poorly.run>
Subject: Re: [PATCH v6 01/11] dt-bindings: display/msm: convert MDP5 schema to YAML format
Date: Fri, 13 Jan 2023 15:11:14 -0600	[thread overview]
Message-ID: <20230113211114.GA2925393-robh@kernel.org> (raw)
In-Reply-To: <167362343145.2212490.16180994187587985655.robh@kernel.org>

On Fri, Jan 13, 2023 at 09:26:52AM -0600, Rob Herring wrote:
> 
> On Fri, 13 Jan 2023 10:37:10 +0200, Dmitry Baryshkov wrote:
> > Convert the mdp5.txt into the yaml format. Changes to the existing (txt) schema:
> >  - MSM8996 has additional "iommu" clock, define it separately
> >  - Add new properties used on some of platforms:
> >    - interconnects, interconnect-names
> >    - iommus
> >    - power-domains
> >    - operating-points-v2, opp-table
> > 
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> > ---
> >  .../devicetree/bindings/display/msm/mdp5.txt  | 132 -----------------
> >  .../bindings/display/msm/qcom,mdp5.yaml       | 138 ++++++++++++++++++
> >  2 files changed, 138 insertions(+), 132 deletions(-)
> >  delete mode 100644 Documentation/devicetree/bindings/display/msm/mdp5.txt
> >  create mode 100644 Documentation/devicetree/bindings/display/msm/qcom,mdp5.yaml
> > 
> 
> Running 'make dtbs_check' with the schema in this patch gives the
> following warnings. Consider if they are expected or the schema is
> incorrect. These may not be new warnings.
> 
> Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> This will change in the future.
> 
> Full log is available here: https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230113083720.39224-2-dmitry.baryshkov@linaro.org
> 
> 
> mdp@1a01000: compatible:0: 'qcom,mdp5' was expected
> 	arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dtb
> 
> mdp@1a01000: compatible: ['qcom,msm8953-mdp5', 'qcom,mdp5'] is too long
> 	arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dtb

If your thought is to drop 'qcom,msm8953-mdp5' here that doesn't really 
seem great.

Rob

  reply	other threads:[~2023-01-13 21:11 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-13  8:37 [PATCH v6 00/11] dt-bindings: display/msm: rework MDP5 and MDSS schema Dmitry Baryshkov
2023-01-13  8:37 ` Dmitry Baryshkov
2023-01-13  8:37 ` [PATCH v6 01/11] dt-bindings: display/msm: convert MDP5 schema to YAML format Dmitry Baryshkov
2023-01-13  8:37   ` Dmitry Baryshkov
2023-01-13 15:26   ` Rob Herring
2023-01-13 15:26     ` Rob Herring
2023-01-13 21:11     ` Rob Herring [this message]
2023-01-13 21:11       ` Rob Herring
2023-01-13 21:12       ` Dmitry Baryshkov
2023-01-13 21:12         ` Dmitry Baryshkov
2023-01-13 21:11     ` Dmitry Baryshkov
2023-01-13 21:11       ` Dmitry Baryshkov
2023-01-17 18:03   ` Rob Herring
2023-01-17 18:03     ` Rob Herring
2023-01-13  8:37 ` [PATCH v6 02/11] dt-bindings: display/msm: add SoC-specific compats to qcom,mdp5.yaml Dmitry Baryshkov
2023-01-13  8:37   ` [PATCH v6 02/11] dt-bindings: display/msm: add SoC-specific compats to qcom, mdp5.yaml Dmitry Baryshkov
2023-01-17 18:05   ` [PATCH v6 02/11] dt-bindings: display/msm: add SoC-specific compats to qcom,mdp5.yaml Rob Herring
2023-01-17 18:05     ` Rob Herring
2023-01-13  8:37 ` [PATCH v6 03/11] dt-bindings: display/msm: add core clock to the mdss bindings Dmitry Baryshkov
2023-01-13  8:37   ` Dmitry Baryshkov
2023-01-17 18:09   ` Rob Herring
2023-01-17 18:09     ` Rob Herring
2023-01-13  8:37 ` [PATCH v6 04/11] dt-bindings: display/msm: rename mdss nodes to display-subsystem Dmitry Baryshkov
2023-01-13  8:37   ` Dmitry Baryshkov
2023-01-13 15:26   ` Rob Herring
2023-01-13 15:26     ` Rob Herring
2023-01-18  2:28     ` Dmitry Baryshkov
2023-01-18  2:28       ` Dmitry Baryshkov
2023-01-13  8:37 ` [PATCH v6 05/11] dt-bindings: display/msm: rename mdp nodes to display-controller Dmitry Baryshkov
2023-01-13  8:37   ` Dmitry Baryshkov
2023-01-17 18:11   ` Rob Herring
2023-01-17 18:11     ` Rob Herring
2023-01-13  8:37 ` [PATCH v6 06/11] ARM: dts: qcom-msm8974: add SoC specific compat string to mdp5 node Dmitry Baryshkov
2023-01-13  8:37   ` Dmitry Baryshkov
2023-01-13  8:37 ` [PATCH v6 07/11] arm64: dts: qcom: add SoC specific compat strings to mdp5 nodes Dmitry Baryshkov
2023-01-13  8:37   ` Dmitry Baryshkov
2023-01-13  8:37 ` [PATCH v6 08/11] arm64: dts: qcom: rename mdss nodes to display-subsystem Dmitry Baryshkov
2023-01-13  8:37   ` Dmitry Baryshkov
2023-01-13  8:37 ` [PATCH v6 09/11] ARM: dts: qcom-msm8974: rename mdss node " Dmitry Baryshkov
2023-01-13  8:37   ` Dmitry Baryshkov
2023-01-13  8:37 ` [PATCH v6 10/11] arm64: dts: qcom: rename mdp nodes to display-controller Dmitry Baryshkov
2023-01-13  8:37   ` Dmitry Baryshkov
2023-01-13  8:37 ` [PATCH v6 11/11] ARM: " Dmitry Baryshkov
2023-01-13  8:37   ` Dmitry Baryshkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230113211114.GA2925393-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=agross@kernel.org \
    --cc=airlied@gmail.com \
    --cc=andersson@kernel.org \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=quic_abhinavk@quicinc.com \
    --cc=robdclark@gmail.com \
    --cc=sean@poorly.run \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.