From: haibo.chen@nxp.com
To: jic23@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de
Cc: lars@metafoo.de, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, kernel@pengutronix.de,
festevam@gmail.com, linux-imx@nxp.com, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
haibo.chen@nxp.com
Subject: [PATCH v6 0/3] add imx93 adc support
Date: Tue, 17 Jan 2023 21:51:34 +0800 [thread overview]
Message-ID: <20230117135137.1735536-1-haibo.chen@nxp.com> (raw)
From: Haibo Chen <haibo.chen@nxp.com>
V6:
-Change the Copyright to 2023
-Power down the ADC if imx93_adc_calibration() if meet issue.
-Add new error label in probe (error_adc_power_down)
-Add back the pm_runtime_get_sync(dev) in imx93_adc_remove().
Though in imx93_adc_remove(), already in pm runtime resume due to the useage
of autosuspend logic. But call this pm_runtime_get_sync(dev) will make the
code logic more clear and will make the runtime pm counter balance after
pm_runtime_put_noidle(dev).
V5:
-For ADC driver, use dev_err_probe() to replace dev_err() in dev_err_probe().
-Add imx93_adc_power_down() in the probe error path.
-Re-order the function in imx93_adc_remove(), make them inverse in probe().
-Remove the pm_runtime_get_sync(dev) in imx93_adc_remove(), because this driver
enable the pm_runtime autosuspend feature, and config the delay as 50ms. So when
called imx93_adc_remove(), this device still in runtime resume state, no need to
force resume the device back.
-no changes for binding doc and dts.
V4:
For ADC driver, re-define the ADC status show the relation to specific register bit.
Redo the imx93_adc_remove(), change the return error sequence in imx93_adc_read_raw(),
and use a direct string for indio_dev->name.
For dt-bings, change the commit title and add maintainer's reviewed by tag
For dts, no change.
V3:
For dt-bings, add some change according to review comments, and pass dt_binding_check.
For dts, add #io-channel-cells = <1>; to pass dtbs_check
For ADC driver, no change.
V2:
For ADC driver, add change according to matainer's commets.
Haibo Chen (3):
iio: adc: add imx93 adc support
dt-bindings: iio: adc: Add NXP IMX93 ADC
arm64: dts: imx93: add ADC support
.../bindings/iio/adc/nxp,imx93-adc.yaml | 81 +++
MAINTAINERS | 4 +-
.../boot/dts/freescale/imx93-11x11-evk.dts | 12 +
arch/arm64/boot/dts/freescale/imx93.dtsi | 13 +
drivers/iio/adc/Kconfig | 10 +
drivers/iio/adc/Makefile | 1 +
drivers/iio/adc/imx93_adc.c | 484 ++++++++++++++++++
7 files changed, 604 insertions(+), 1 deletion(-)
create mode 100644 Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
create mode 100644 drivers/iio/adc/imx93_adc.c
--
2.34.1
WARNING: multiple messages have this Message-ID (diff)
From: haibo.chen@nxp.com
To: jic23@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de
Cc: lars@metafoo.de, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, kernel@pengutronix.de,
festevam@gmail.com, linux-imx@nxp.com, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
haibo.chen@nxp.com
Subject: [PATCH v6 0/3] add imx93 adc support
Date: Tue, 17 Jan 2023 21:51:34 +0800 [thread overview]
Message-ID: <20230117135137.1735536-1-haibo.chen@nxp.com> (raw)
From: Haibo Chen <haibo.chen@nxp.com>
V6:
-Change the Copyright to 2023
-Power down the ADC if imx93_adc_calibration() if meet issue.
-Add new error label in probe (error_adc_power_down)
-Add back the pm_runtime_get_sync(dev) in imx93_adc_remove().
Though in imx93_adc_remove(), already in pm runtime resume due to the useage
of autosuspend logic. But call this pm_runtime_get_sync(dev) will make the
code logic more clear and will make the runtime pm counter balance after
pm_runtime_put_noidle(dev).
V5:
-For ADC driver, use dev_err_probe() to replace dev_err() in dev_err_probe().
-Add imx93_adc_power_down() in the probe error path.
-Re-order the function in imx93_adc_remove(), make them inverse in probe().
-Remove the pm_runtime_get_sync(dev) in imx93_adc_remove(), because this driver
enable the pm_runtime autosuspend feature, and config the delay as 50ms. So when
called imx93_adc_remove(), this device still in runtime resume state, no need to
force resume the device back.
-no changes for binding doc and dts.
V4:
For ADC driver, re-define the ADC status show the relation to specific register bit.
Redo the imx93_adc_remove(), change the return error sequence in imx93_adc_read_raw(),
and use a direct string for indio_dev->name.
For dt-bings, change the commit title and add maintainer's reviewed by tag
For dts, no change.
V3:
For dt-bings, add some change according to review comments, and pass dt_binding_check.
For dts, add #io-channel-cells = <1>; to pass dtbs_check
For ADC driver, no change.
V2:
For ADC driver, add change according to matainer's commets.
Haibo Chen (3):
iio: adc: add imx93 adc support
dt-bindings: iio: adc: Add NXP IMX93 ADC
arm64: dts: imx93: add ADC support
.../bindings/iio/adc/nxp,imx93-adc.yaml | 81 +++
MAINTAINERS | 4 +-
.../boot/dts/freescale/imx93-11x11-evk.dts | 12 +
arch/arm64/boot/dts/freescale/imx93.dtsi | 13 +
drivers/iio/adc/Kconfig | 10 +
drivers/iio/adc/Makefile | 1 +
drivers/iio/adc/imx93_adc.c | 484 ++++++++++++++++++
7 files changed, 604 insertions(+), 1 deletion(-)
create mode 100644 Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
create mode 100644 drivers/iio/adc/imx93_adc.c
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2023-01-17 13:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 13:51 haibo.chen [this message]
2023-01-17 13:51 ` [PATCH v6 0/3] add imx93 adc support haibo.chen
2023-01-17 13:51 ` [PATCH v6 1/3] iio: adc: " haibo.chen
2023-01-17 13:51 ` haibo.chen
2023-01-22 17:17 ` Jonathan Cameron
2023-01-22 17:17 ` Jonathan Cameron
2023-01-17 13:51 ` [PATCH v6 2/3] dt-bindings: iio: adc: Add NXP IMX93 ADC haibo.chen
2023-01-17 13:51 ` haibo.chen
2023-01-22 17:17 ` Jonathan Cameron
2023-01-22 17:17 ` Jonathan Cameron
2023-01-17 13:51 ` [PATCH v6 3/3] arm64: dts: imx93: add ADC support haibo.chen
2023-01-17 13:51 ` haibo.chen
2023-01-26 7:40 ` Shawn Guo
2023-01-26 7:40 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230117135137.1735536-1-haibo.chen@nxp.com \
--to=haibo.chen@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=jic23@kernel.org \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.