From: Rob Herring <robh@kernel.org>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: devicetree@vger.kernel.org,
Linux-ALSA <alsa-devel@alsa-project.org>,
Mark Brown <broonie@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Subject: Re: [PATCH v2 03/10] ASoC: dt-bindings: audio-graph-port: add missing mclk-fs
Date: Tue, 17 Jan 2023 11:09:42 -0600 [thread overview]
Message-ID: <20230117170942.GA3244879-robh@kernel.org> (raw)
In-Reply-To: <87y1q9ho56.wl-kuninori.morimoto.gx@renesas.com>
On Wed, Jan 11, 2023 at 01:10:29AM +0000, Kuninori Morimoto wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> audio-graph-port is missing "mclk-fs" on ports/port,
> it is used not only endpoint. It is already defined on simple-card.
> This patch fixup it.
> Without this patch, we will get below warning.
>
> ${LINUX}/arch/arm64/boot/dts/renesas/r8a77951-ulcb-kf.dtb: audio-codec@44: ports: 'mclk-fs' does not match any of the regexes: '^port@[0-9a-f]+$', 'pinctrl-[0-9]+'
> From schema: ${LINUX}/Documentation/devicetree/bindings/sound/ti,pcm3168a.yaml
IMO, the warning is correct. 'ports' should not be anything but a
container of 'port' nodes. If something applies to all ports, then it
should probably be in the device node (or implicit).
Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Mark Brown <broonie@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Linux-ALSA <alsa-devel@alsa-project.org>,
devicetree@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>
Subject: Re: [PATCH v2 03/10] ASoC: dt-bindings: audio-graph-port: add missing mclk-fs
Date: Tue, 17 Jan 2023 11:09:42 -0600 [thread overview]
Message-ID: <20230117170942.GA3244879-robh@kernel.org> (raw)
In-Reply-To: <87y1q9ho56.wl-kuninori.morimoto.gx@renesas.com>
On Wed, Jan 11, 2023 at 01:10:29AM +0000, Kuninori Morimoto wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> audio-graph-port is missing "mclk-fs" on ports/port,
> it is used not only endpoint. It is already defined on simple-card.
> This patch fixup it.
> Without this patch, we will get below warning.
>
> ${LINUX}/arch/arm64/boot/dts/renesas/r8a77951-ulcb-kf.dtb: audio-codec@44: ports: 'mclk-fs' does not match any of the regexes: '^port@[0-9a-f]+$', 'pinctrl-[0-9]+'
> From schema: ${LINUX}/Documentation/devicetree/bindings/sound/ti,pcm3168a.yaml
IMO, the warning is correct. 'ports' should not be anything but a
container of 'port' nodes. If something applies to all ports, then it
should probably be in the device node (or implicit).
Rob
next prev parent reply other threads:[~2023-01-17 17:11 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-11 1:07 [PATCH v2 00/10] ASoC: dt-bindings: audio-graph-port related update Kuninori Morimoto
2023-01-11 1:07 ` Kuninori Morimoto
2023-01-11 1:08 ` [PATCH v2 01/10] ASoC: dt-bindings: audio-graph-port: use definitions for port/endpoint Kuninori Morimoto
2023-01-11 1:08 ` Kuninori Morimoto
2023-01-11 1:09 ` [PATCH v2 02/10] ASoC: dt-bindings: audio-graph-port: add definitions/ports Kuninori Morimoto
2023-01-11 1:09 ` Kuninori Morimoto
2023-01-17 17:04 ` Rob Herring
2023-01-17 17:04 ` Rob Herring
2023-01-18 0:08 ` Kuninori Morimoto
2023-01-18 0:08 ` Kuninori Morimoto
2023-01-11 1:10 ` [PATCH v2 03/10] ASoC: dt-bindings: audio-graph-port: add missing mclk-fs Kuninori Morimoto
2023-01-11 1:10 ` Kuninori Morimoto
2023-01-17 17:09 ` Rob Herring [this message]
2023-01-17 17:09 ` Rob Herring
2023-01-11 1:10 ` [PATCH v2 04/10] ASoC: dt-bindings: audio-graph-port: add clocks on endpoint Kuninori Morimoto
2023-01-11 1:10 ` Kuninori Morimoto
2023-01-11 1:11 ` [PATCH v2 05/10] ASoC: dt-bindings: audio-graph-port: remove prefix Kuninori Morimoto
2023-01-11 1:11 ` Kuninori Morimoto
2023-01-17 17:11 ` Rob Herring
2023-01-17 17:11 ` Rob Herring
2023-01-11 1:11 ` [PATCH v2 06/10] ASoC: dt-bindings: ti, pcm3168a: Convert to json-schema Kuninori Morimoto
2023-01-11 1:11 ` [PATCH v2 06/10] ASoC: dt-bindings: ti,pcm3168a: " Kuninori Morimoto
2023-01-17 17:12 ` Rob Herring
2023-01-17 17:12 ` Rob Herring
2023-01-11 1:11 ` [PATCH v2 07/10] ASoC: dt-bindings: ak4613: enable Of-graph (Audio-Graph-Card) style Kuninori Morimoto
2023-01-11 1:11 ` Kuninori Morimoto
2023-01-11 1:12 ` [PATCH v2 08/10] ASoC: dt-bindings: renesas, rsnd: add missing playback/capture Kuninori Morimoto
2023-01-11 1:12 ` [PATCH v2 08/10] ASoC: dt-bindings: renesas,rsnd: " Kuninori Morimoto
2023-01-11 13:29 ` Rob Herring
2023-01-11 13:29 ` Rob Herring
2023-01-12 0:58 ` [PATCH v2 08/10] ASoC: dt-bindings: renesas, rsnd: " Kuninori Morimoto
2023-01-12 0:58 ` [PATCH v2 08/10] ASoC: dt-bindings: renesas,rsnd: " Kuninori Morimoto
2023-01-11 1:12 ` [PATCH v2 09/10] ASoC: dt-bindings: renesas, rsnd: #sound-dai-cells is not mandatory Kuninori Morimoto
2023-01-11 1:12 ` [PATCH v2 09/10] ASoC: dt-bindings: renesas,rsnd: " Kuninori Morimoto
2023-01-11 1:12 ` [PATCH v2 10/10] ASoC: dt-bindings: simple-card: add missing #address-cells/#size-cells Kuninori Morimoto
2023-01-11 1:12 ` Kuninori Morimoto
2023-01-12 1:01 ` [PATCH 11/10] ASoC: dt-bindings: renesas,rsnd: tidyup rcar_sound,src Kuninori Morimoto
2023-01-12 1:01 ` Kuninori Morimoto
2023-01-12 12:22 ` [PATCH 11/10] ASoC: dt-bindings: renesas, rsnd: tidyup rcar_sound, src Rob Herring
2023-01-12 12:22 ` [PATCH 11/10] ASoC: dt-bindings: renesas,rsnd: tidyup rcar_sound,src Rob Herring
2023-01-12 22:53 ` [PATCH 11/10] ASoC: dt-bindings: renesas, rsnd: tidyup rcar_sound, src Kuninori Morimoto
2023-01-12 22:53 ` [PATCH 11/10] ASoC: dt-bindings: renesas,rsnd: tidyup rcar_sound,src Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230117170942.GA3244879-robh@kernel.org \
--to=robh@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuninori.morimoto.gx@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.