From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org,
Bjorn Andersson <andersson@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Andy Gross <agross@kernel.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Mark Brown <broonie@kernel.org>,
Banajit Goswami <bgoswami@quicinc.com>
Subject: Re: [PATCH 2/3] ASoC: dt-bindings: qcom,wcd934x: Describe slim-ifc-dev
Date: Tue, 17 Jan 2023 13:27:24 -0600 [thread overview]
Message-ID: <20230117192724.GA3489389-robh@kernel.org> (raw)
In-Reply-To: <20230113162214.117261-2-krzysztof.kozlowski@linaro.org>
On Fri, Jan 13, 2023 at 05:22:13PM +0100, Krzysztof Kozlowski wrote:
> The "slim-ifc-dev" property should not be just "true", because it allows
> any type.
Yes, but it is common, so it should be in a common schema. Though
there's only one other binding using it (wcd9335.txt).
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> Documentation/devicetree/bindings/sound/qcom,wcd934x.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/qcom,wcd934x.yaml b/Documentation/devicetree/bindings/sound/qcom,wcd934x.yaml
> index 184e8ccbdd13..39b27126cfc1 100644
> --- a/Documentation/devicetree/bindings/sound/qcom,wcd934x.yaml
> +++ b/Documentation/devicetree/bindings/sound/qcom,wcd934x.yaml
> @@ -28,7 +28,9 @@ properties:
> description: GPIO spec for reset line to use
> maxItems: 1
>
> - slim-ifc-dev: true
> + slim-ifc-dev:
> + description: IFC device interface
> + $ref: /schemas/types.yaml#/definitions/phandle
>
> clocks:
> maxItems: 1
> --
> 2.34.1
>
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Banajit Goswami <bgoswami@quicinc.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
alsa-devel@alsa-project.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] ASoC: dt-bindings: qcom,wcd934x: Describe slim-ifc-dev
Date: Tue, 17 Jan 2023 13:27:24 -0600 [thread overview]
Message-ID: <20230117192724.GA3489389-robh@kernel.org> (raw)
In-Reply-To: <20230113162214.117261-2-krzysztof.kozlowski@linaro.org>
On Fri, Jan 13, 2023 at 05:22:13PM +0100, Krzysztof Kozlowski wrote:
> The "slim-ifc-dev" property should not be just "true", because it allows
> any type.
Yes, but it is common, so it should be in a common schema. Though
there's only one other binding using it (wcd9335.txt).
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> Documentation/devicetree/bindings/sound/qcom,wcd934x.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/qcom,wcd934x.yaml b/Documentation/devicetree/bindings/sound/qcom,wcd934x.yaml
> index 184e8ccbdd13..39b27126cfc1 100644
> --- a/Documentation/devicetree/bindings/sound/qcom,wcd934x.yaml
> +++ b/Documentation/devicetree/bindings/sound/qcom,wcd934x.yaml
> @@ -28,7 +28,9 @@ properties:
> description: GPIO spec for reset line to use
> maxItems: 1
>
> - slim-ifc-dev: true
> + slim-ifc-dev:
> + description: IFC device interface
> + $ref: /schemas/types.yaml#/definitions/phandle
>
> clocks:
> maxItems: 1
> --
> 2.34.1
>
next prev parent reply other threads:[~2023-01-17 19:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-13 16:22 [PATCH 1/3] ASoC: dt-bindings: qcom,wsa881x: Allow sound-name-prefix Krzysztof Kozlowski
2023-01-13 16:22 ` [PATCH 2/3] ASoC: dt-bindings: qcom,wcd934x: Describe slim-ifc-dev Krzysztof Kozlowski
2023-01-17 19:27 ` Rob Herring [this message]
2023-01-17 19:27 ` Rob Herring
2023-01-18 11:25 ` Krzysztof Kozlowski
2023-01-18 11:25 ` Krzysztof Kozlowski
2023-01-18 13:19 ` [PATCH 2/3] ASoC: dt-bindings: qcom, wcd934x: " Rob Herring
2023-01-18 13:19 ` [PATCH 2/3] ASoC: dt-bindings: qcom,wcd934x: " Rob Herring
2023-01-18 13:26 ` Krzysztof Kozlowski
2023-01-18 13:26 ` Krzysztof Kozlowski
2023-01-13 16:22 ` [PATCH 3/3] ASoC: dt-bindings: qcom, wcd934x: Allow usage as IFD device Krzysztof Kozlowski
2023-01-13 16:22 ` [PATCH 3/3] ASoC: dt-bindings: qcom,wcd934x: " Krzysztof Kozlowski
2023-01-17 19:33 ` Rob Herring
2023-01-17 19:33 ` Rob Herring
2023-01-17 19:22 ` [PATCH 1/3] ASoC: dt-bindings: qcom,wsa881x: Allow sound-name-prefix Rob Herring
2023-01-17 19:22 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230117192724.GA3489389-robh@kernel.org \
--to=robh@kernel.org \
--cc=agross@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=andersson@kernel.org \
--cc=bgoswami@quicinc.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.