Re: [OE-core] [PATCH] librsvg: Only enable the Vala bindings if GObject Introspection is enabled

[Luca Ceresoli <luca.ceresoli@bootlin.com>]

Hello Peter,

On Wed, 18 Jan 2023 22:22:22 +0000
"Peter Kjellerstedt" <peter.kjellerstedt@axis.com> wrote:

> > -----Original Message-----
> > From: Luca Ceresoli <luca.ceresoli@bootlin.com>
> > Sent: den 18 januari 2023 17:22
> > To: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
> > Cc: openembedded-core@lists.openembedded.org; Richard Purdie
> > <richard.purdie@linuxfoundation.org>
> > Subject: Re: [OE-core] [PATCH] librsvg: Only enable the Vala bindings if
> > GObject Introspection is enabled
> > 
> > Hello Peter,
> > 
> > On Wed, 18 Jan 2023 12:27:59 +0100
> > "Peter Kjellerstedt" <peter.kjellerstedt@axis.com> wrote:
> >   
> > > This avoids the following error:
> > >
> > >   configure: error: Vala bindings require GObject Introspection
> > >
> > > Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com>  
> > 
> > A different patch [0] to address the same bug is already in my testing
> > branch and is possibly being merged soon on master by Richard. Can you
> > please check whether your think your patch is better and let us know?  
> 
> I had not seen that patch when I sent mine. I think mine is a little better 
> since it defines and uses a PACKAGECONFIG for the vala support, which should 
> make it easier for anyone wanting to, e.g., disable the vala support even if 
> it is enabled by default.

Indeed. I'm replacing Alex's patch with yours in my testing branch in
order to have both tested. None is on master at the moment.

-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com