RE: [OE-core] [PATCH] librsvg: Only enable the Vala bindings if GObject Introspection is enabled

[Peter Kjellerstedt <peter.kjellerstedt@axis.com>]

[-- Attachment #1: Type: text/plain, Size: 3103 bytes --]

gobject-instrospection is not enabled by default in DISTRO_FEATURES_NATIVE and DISTRO_FEATURES_NATIVESDK so unless you explicitly enable it yourself (which seems unlikely to me), it will not be enabled in the native/nativesdk cases.

//Peter

From: Jose Quaresma <quaresma.jose@gmail.com>
Sent: den 18 januari 2023 13:13
To: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH] librsvg: Only enable the Vala bindings if GObject Introspection is enabled

Hi Peter,

Peter Kjellerstedt <peter.kjellerstedt@axis.com<mailto:peter.kjellerstedt@axis.com>> escreveu no dia quarta, 18/01/2023 à(s) 11:28:
This avoids the following error:

  configure: error: Vala bindings require GObject Introspection

Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com<mailto:peter.kjellerstedt@axis.com>>
---
 meta/recipes-gnome/librsvg/librsvg_2.54.5.bb<http://librsvg_2.54.5.bb> | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/meta/recipes-gnome/librsvg/librsvg_2.54.5.bb<http://librsvg_2.54.5.bb> b/meta/recipes-gnome/librsvg/librsvg_2.54.5.bb<http://librsvg_2.54.5.bb>
index b2e93a2684..c55aa250e9 100644
--- a/meta/recipes-gnome/librsvg/librsvg_2.54.5.bb<http://librsvg_2.54.5.bb>
+++ b/meta/recipes-gnome/librsvg/librsvg_2.54.5.bb<http://librsvg_2.54.5.bb>
@@ -42,8 +42,6 @@ do_configure[postfuncs] += "cargo_common_do_configure"

 inherit rust-target-config

-EXTRA_OECONF:class-target = "--enable-vala"
-
 # rust-cross writes the target linker binary into target json definition without any flags.
 # This breaks here because the linker isn't going to work without at least knowing where
 # the sysroot is. So copy the json to workdir, and patch in the path to wrapper from rust class
@@ -57,9 +55,10 @@ CVE_CHECK_IGNORE += "CVE-2018-1000041"

 CACHED_CONFIGUREVARS = "ac_cv_path_GDK_PIXBUF_QUERYLOADERS=${STAGING_LIBDIR_NATIVE}/gdk-pixbuf-2.0/gdk-pixbuf-query-loaders"

-PACKAGECONFIG ??= "gdkpixbuf"
+PACKAGECONFIG ??= "gdkpixbuf ${@bb.utils.contains('GI_DATA_ENABLED<mailto:$%7b@bb.utils.contains('GI_DATA_ENABLED>', 'True', 'vala', '', d)}"
 # The gdk-pixbuf loader
 PACKAGECONFIG[gdkpixbuf] = "--enable-pixbuf-loader,--disable-pixbuf-loader,gdk-pixbuf-native"
+PACKAGECONFIG[vala] = "--enable-vala,--disable-vala"

This will be enabled in the native builds too and before it is only defined for target.

Jose


 do_install:append() {
        # Loadable modules don't need .a or .la on Linux

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#176086): https://lists.openembedded.org/g/openembedded-core/message/176086
Mute This Topic: https://lists.openembedded.org/mt/96351645/5052612
Group Owner: openembedded-core+owner@lists.openembedded.org<mailto:openembedded-core%2Bowner@lists.openembedded.org>
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [quaresma.jose@gmail.com<mailto:quaresma.jose@gmail.com>]
-=-=-=-=-=-=-=-=-=-=-=-


--
Best regards,

José Quaresma

[-- Attachment #2: Type: text/html, Size: 8055 bytes --]