From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH drm-next 13/14] drm/nouveau: implement new VM_BIND UAPI
Date: Fri, 20 Jan 2023 07:32:10 +0800 [thread overview]
Message-ID: <202301200752.muIBg2TR-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20230118061256.2689-14-dakr@redhat.com>
References: <20230118061256.2689-14-dakr@redhat.com>
TO: Danilo Krummrich <dakr@redhat.com>
TO: daniel@ffwll.ch
TO: airlied@redhat.com
TO: christian.koenig@amd.com
TO: bskeggs@redhat.com
TO: jason@jlekstrand.net
TO: tzimmermann@suse.de
TO: mripard@kernel.org
TO: corbet@lwn.net
CC: nouveau@lists.freedesktop.org
CC: Danilo Krummrich <dakr@redhat.com>
CC: linux-kernel@vger.kernel.org
CC: dri-devel@lists.freedesktop.org
CC: linux-doc@vger.kernel.org
Hi Danilo,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on 0b45ac1170ea6416bc1d36798414c04870cd356d]
url: https://github.com/intel-lab-lkp/linux/commits/Danilo-Krummrich/drm-execution-context-for-GEM-buffers/20230118-141552
base: 0b45ac1170ea6416bc1d36798414c04870cd356d
patch link: https://lore.kernel.org/r/20230118061256.2689-14-dakr%40redhat.com
patch subject: [PATCH drm-next 13/14] drm/nouveau: implement new VM_BIND UAPI
:::::: branch date: 2 days ago
:::::: commit date: 2 days ago
config: ia64-randconfig-m041-20230119 (https://download.01.org/0day-ci/archive/20230120/202301200752.muIBg2TR-lkp@intel.com/config)
compiler: ia64-linux-gcc (GCC) 12.1.0
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
smatch warnings:
drivers/gpu/drm/nouveau/nouveau_sched.c:256 nouveau_bind_job_run() warn: passing zero to 'ERR_PTR'
drivers/gpu/drm/nouveau/nouveau_sched.c:466 nouveau_exec_job_submit() warn: inconsistent returns '&uvmm->mutex'.
vim +/ERR_PTR +256 drivers/gpu/drm/nouveau/nouveau_sched.c
85eb5d5193ee71 Danilo Krummrich 2023-01-18 204
85eb5d5193ee71 Danilo Krummrich 2023-01-18 205 static struct dma_fence *
85eb5d5193ee71 Danilo Krummrich 2023-01-18 206 nouveau_bind_job_run(struct nouveau_job *job)
85eb5d5193ee71 Danilo Krummrich 2023-01-18 207 {
85eb5d5193ee71 Danilo Krummrich 2023-01-18 208 struct nouveau_bind_job *bind_job = to_nouveau_bind_job(job);
85eb5d5193ee71 Danilo Krummrich 2023-01-18 209 struct nouveau_uvmm *uvmm = nouveau_cli_uvmm(job->cli);
85eb5d5193ee71 Danilo Krummrich 2023-01-18 210 struct bind_job_op *op;
85eb5d5193ee71 Danilo Krummrich 2023-01-18 211 int ret = 0;
85eb5d5193ee71 Danilo Krummrich 2023-01-18 212
85eb5d5193ee71 Danilo Krummrich 2023-01-18 213 nouveau_uvmm_lock(uvmm);
85eb5d5193ee71 Danilo Krummrich 2023-01-18 214 list_for_each_op(op, &bind_job->ops) {
85eb5d5193ee71 Danilo Krummrich 2023-01-18 215 switch (op->op) {
85eb5d5193ee71 Danilo Krummrich 2023-01-18 216 case OP_ALLOC: {
85eb5d5193ee71 Danilo Krummrich 2023-01-18 217 bool sparse = op->flags & DRM_NOUVEAU_VM_BIND_SPARSE;
85eb5d5193ee71 Danilo Krummrich 2023-01-18 218
85eb5d5193ee71 Danilo Krummrich 2023-01-18 219 ret = nouveau_uvma_region_new(uvmm,
85eb5d5193ee71 Danilo Krummrich 2023-01-18 220 op->va.addr,
85eb5d5193ee71 Danilo Krummrich 2023-01-18 221 op->va.range,
85eb5d5193ee71 Danilo Krummrich 2023-01-18 222 sparse);
85eb5d5193ee71 Danilo Krummrich 2023-01-18 223 if (ret)
85eb5d5193ee71 Danilo Krummrich 2023-01-18 224 goto out_unlock;
85eb5d5193ee71 Danilo Krummrich 2023-01-18 225 break;
85eb5d5193ee71 Danilo Krummrich 2023-01-18 226 }
85eb5d5193ee71 Danilo Krummrich 2023-01-18 227 case OP_FREE:
85eb5d5193ee71 Danilo Krummrich 2023-01-18 228 ret = nouveau_uvma_region_destroy(uvmm,
85eb5d5193ee71 Danilo Krummrich 2023-01-18 229 op->va.addr,
85eb5d5193ee71 Danilo Krummrich 2023-01-18 230 op->va.range);
85eb5d5193ee71 Danilo Krummrich 2023-01-18 231 if (ret)
85eb5d5193ee71 Danilo Krummrich 2023-01-18 232 goto out_unlock;
85eb5d5193ee71 Danilo Krummrich 2023-01-18 233 break;
85eb5d5193ee71 Danilo Krummrich 2023-01-18 234 case OP_MAP:
85eb5d5193ee71 Danilo Krummrich 2023-01-18 235 ret = nouveau_uvmm_sm_map(uvmm,
85eb5d5193ee71 Danilo Krummrich 2023-01-18 236 op->va.addr, op->va.range,
85eb5d5193ee71 Danilo Krummrich 2023-01-18 237 op->gem.obj, op->gem.offset,
85eb5d5193ee71 Danilo Krummrich 2023-01-18 238 op->flags && 0xff);
85eb5d5193ee71 Danilo Krummrich 2023-01-18 239 if (ret)
85eb5d5193ee71 Danilo Krummrich 2023-01-18 240 goto out_unlock;
85eb5d5193ee71 Danilo Krummrich 2023-01-18 241 break;
85eb5d5193ee71 Danilo Krummrich 2023-01-18 242 case OP_UNMAP:
85eb5d5193ee71 Danilo Krummrich 2023-01-18 243 ret = nouveau_uvmm_sm_unmap(uvmm,
85eb5d5193ee71 Danilo Krummrich 2023-01-18 244 op->va.addr,
85eb5d5193ee71 Danilo Krummrich 2023-01-18 245 op->va.range);
85eb5d5193ee71 Danilo Krummrich 2023-01-18 246 if (ret)
85eb5d5193ee71 Danilo Krummrich 2023-01-18 247 goto out_unlock;
85eb5d5193ee71 Danilo Krummrich 2023-01-18 248 break;
85eb5d5193ee71 Danilo Krummrich 2023-01-18 249 }
85eb5d5193ee71 Danilo Krummrich 2023-01-18 250 }
85eb5d5193ee71 Danilo Krummrich 2023-01-18 251
85eb5d5193ee71 Danilo Krummrich 2023-01-18 252 out_unlock:
85eb5d5193ee71 Danilo Krummrich 2023-01-18 253 nouveau_uvmm_unlock(uvmm);
85eb5d5193ee71 Danilo Krummrich 2023-01-18 254 if (ret)
85eb5d5193ee71 Danilo Krummrich 2023-01-18 255 NV_PRINTK(err, job->cli, "bind job failed: %d\n", ret);
85eb5d5193ee71 Danilo Krummrich 2023-01-18 @256 return ERR_PTR(ret);
85eb5d5193ee71 Danilo Krummrich 2023-01-18 257 }
85eb5d5193ee71 Danilo Krummrich 2023-01-18 258
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
next reply other threads:[~2023-01-19 23:32 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-19 23:32 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-01-18 6:12 [PATCH drm-next 00/14] [RFC] DRM GPUVA Manager & Nouveau VM_BIND UAPI Danilo Krummrich
2023-01-18 6:12 ` [PATCH drm-next 13/14] drm/nouveau: implement new " Danilo Krummrich
2023-01-18 6:12 ` Danilo Krummrich
2023-01-18 8:37 ` kernel test robot
2023-01-18 8:37 ` kernel test robot
2023-01-18 20:37 ` Thomas Hellström (Intel)
2023-01-19 3:44 ` Danilo Krummrich
2023-01-19 4:58 ` Matthew Brost
2023-01-19 4:58 ` Matthew Brost
2023-01-19 7:32 ` Thomas Hellström (Intel)
2023-01-19 7:32 ` Thomas Hellström (Intel)
2023-01-19 15:36 ` Danilo Krummrich
2023-01-19 16:38 ` Matthew Brost
2023-01-19 17:46 ` Danilo Krummrich
2023-01-19 21:47 ` Matthew Brost
2023-01-19 22:25 ` Danilo Krummrich
2023-01-20 4:30 ` Matthew Brost
2023-01-20 10:22 ` Boris Brezillon
2023-01-22 17:48 ` Matthew Brost
2023-01-23 10:01 ` Boris Brezillon
2023-01-20 10:08 ` Boris Brezillon
2023-01-20 10:08 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202301200752.muIBg2TR-lkp@intel.com \
--to=lkp@intel.com \
--cc=error27@gmail.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.