From: Boris Brezillon <boris.brezillon@collabora.com>
To: Matthew Brost <matthew.brost@intel.com>
Cc: "Danilo Krummrich" <dakr@redhat.com>,
dri-devel@lists.freedesktop.org, corbet@lwn.net,
tzimmermann@suse.de,
"Thomas Hellström (Intel)" <thomas_os@shipmail.org>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
bskeggs@redhat.com, jason@jlekstrand.net,
nouveau@lists.freedesktop.org, airlied@redhat.com,
christian.koenig@amd.com
Subject: Re: [PATCH drm-next 13/14] drm/nouveau: implement new VM_BIND UAPI
Date: Fri, 20 Jan 2023 11:08:33 +0100 [thread overview]
Message-ID: <20230120110833.76cc7864@collabora.com> (raw)
In-Reply-To: <Y8jOCE/PyNZ2Z6aX@DUT025-TGLU.fm.intel.com>
On Thu, 19 Jan 2023 04:58:48 +0000
Matthew Brost <matthew.brost@intel.com> wrote:
> > For the ops structures the drm_gpuva_manager allocates for reporting the
> > split/merge steps back to the driver I have ideas to entirely avoid
> > allocations, which also is a good thing in respect of Christians feedback
> > regarding the huge amount of mapping requests some applications seem to
> > generate.
> >
>
> It should be fine to have allocations to report the split/merge step as
> this step should be before a dma-fence is published, but yea if possible
> to avoid extra allocs as that is always better.
>
> Also BTW, great work on drm_gpuva_manager too. We will almost likely
> pick this up in Xe rather than open coding all of this as we currently
> do. We should probably start the port to this soon so we can contribute
> to the implementation and get both of our drivers upstream sooner.
Also quite interested in using this drm_gpuva_manager for pancsf, since
I've been open-coding something similar. Didn't have the
gpuva_region concept to make sure VA mapping/unmapping requests don't
don't go outside a pre-reserved region, but it seems to automate some
of the stuff I've been doing quite nicely.
WARNING: multiple messages have this Message-ID (diff)
From: Boris Brezillon <boris.brezillon@collabora.com>
To: Matthew Brost <matthew.brost@intel.com>
Cc: jason@jlekstrand.net, linux-doc@vger.kernel.org,
nouveau@lists.freedesktop.org,
"Thomas Hellström (Intel)" <thomas_os@shipmail.org>,
corbet@lwn.net, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, bskeggs@redhat.com,
airlied@redhat.com, christian.koenig@amd.com
Subject: Re: [Nouveau] [PATCH drm-next 13/14] drm/nouveau: implement new VM_BIND UAPI
Date: Fri, 20 Jan 2023 11:08:33 +0100 [thread overview]
Message-ID: <20230120110833.76cc7864@collabora.com> (raw)
In-Reply-To: <Y8jOCE/PyNZ2Z6aX@DUT025-TGLU.fm.intel.com>
On Thu, 19 Jan 2023 04:58:48 +0000
Matthew Brost <matthew.brost@intel.com> wrote:
> > For the ops structures the drm_gpuva_manager allocates for reporting the
> > split/merge steps back to the driver I have ideas to entirely avoid
> > allocations, which also is a good thing in respect of Christians feedback
> > regarding the huge amount of mapping requests some applications seem to
> > generate.
> >
>
> It should be fine to have allocations to report the split/merge step as
> this step should be before a dma-fence is published, but yea if possible
> to avoid extra allocs as that is always better.
>
> Also BTW, great work on drm_gpuva_manager too. We will almost likely
> pick this up in Xe rather than open coding all of this as we currently
> do. We should probably start the port to this soon so we can contribute
> to the implementation and get both of our drivers upstream sooner.
Also quite interested in using this drm_gpuva_manager for pancsf, since
I've been open-coding something similar. Didn't have the
gpuva_region concept to make sure VA mapping/unmapping requests don't
don't go outside a pre-reserved region, but it seems to automate some
of the stuff I've been doing quite nicely.
WARNING: multiple messages have this Message-ID (diff)
From: Boris Brezillon <boris.brezillon@collabora.com>
To: Matthew Brost <matthew.brost@intel.com>
Cc: jason@jlekstrand.net, linux-doc@vger.kernel.org,
nouveau@lists.freedesktop.org,
"Thomas Hellström (Intel)" <thomas_os@shipmail.org>,
corbet@lwn.net, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
"Danilo Krummrich" <dakr@redhat.com>,
bskeggs@redhat.com, tzimmermann@suse.de, airlied@redhat.com,
christian.koenig@amd.com
Subject: Re: [PATCH drm-next 13/14] drm/nouveau: implement new VM_BIND UAPI
Date: Fri, 20 Jan 2023 11:08:33 +0100 [thread overview]
Message-ID: <20230120110833.76cc7864@collabora.com> (raw)
In-Reply-To: <Y8jOCE/PyNZ2Z6aX@DUT025-TGLU.fm.intel.com>
On Thu, 19 Jan 2023 04:58:48 +0000
Matthew Brost <matthew.brost@intel.com> wrote:
> > For the ops structures the drm_gpuva_manager allocates for reporting the
> > split/merge steps back to the driver I have ideas to entirely avoid
> > allocations, which also is a good thing in respect of Christians feedback
> > regarding the huge amount of mapping requests some applications seem to
> > generate.
> >
>
> It should be fine to have allocations to report the split/merge step as
> this step should be before a dma-fence is published, but yea if possible
> to avoid extra allocs as that is always better.
>
> Also BTW, great work on drm_gpuva_manager too. We will almost likely
> pick this up in Xe rather than open coding all of this as we currently
> do. We should probably start the port to this soon so we can contribute
> to the implementation and get both of our drivers upstream sooner.
Also quite interested in using this drm_gpuva_manager for pancsf, since
I've been open-coding something similar. Didn't have the
gpuva_region concept to make sure VA mapping/unmapping requests don't
don't go outside a pre-reserved region, but it seems to automate some
of the stuff I've been doing quite nicely.
next prev parent reply other threads:[~2023-01-20 10:08 UTC|newest]
Thread overview: 230+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-18 6:12 [PATCH drm-next 00/14] [RFC] DRM GPUVA Manager & Nouveau VM_BIND UAPI Danilo Krummrich
2023-01-18 6:12 ` Danilo Krummrich
2023-01-18 6:12 ` [Nouveau] " Danilo Krummrich
2023-01-18 6:12 ` [PATCH drm-next 01/14] drm: execution context for GEM buffers Danilo Krummrich
2023-01-18 6:12 ` Danilo Krummrich
2023-01-18 6:12 ` [Nouveau] " Danilo Krummrich
2023-01-18 6:12 ` [PATCH drm-next 02/14] drm/exec: fix memory leak in drm_exec_prepare_obj() Danilo Krummrich
2023-01-18 6:12 ` Danilo Krummrich
2023-01-18 6:12 ` [Nouveau] " Danilo Krummrich
2023-01-18 8:51 ` Christian König
2023-01-18 8:51 ` Christian König
2023-01-18 8:51 ` [Nouveau] " Christian König
2023-01-18 19:00 ` Danilo Krummrich
2023-01-18 19:00 ` Danilo Krummrich
2023-01-18 19:00 ` [Nouveau] " Danilo Krummrich
2023-01-18 6:12 ` [PATCH drm-next 03/14] drm: manager to keep track of GPUs VA mappings Danilo Krummrich
2023-01-18 6:12 ` Danilo Krummrich
2023-01-18 6:12 ` [Nouveau] " Danilo Krummrich
2023-01-19 4:14 ` Bagas Sanjaya
2023-01-19 4:14 ` Bagas Sanjaya
2023-01-19 4:14 ` [Nouveau] " Bagas Sanjaya
2023-01-20 18:32 ` Danilo Krummrich
2023-01-23 23:23 ` Niranjana Vishwanathapura
2023-01-23 23:23 ` Niranjana Vishwanathapura
2023-01-24 0:11 ` [Nouveau] " Danilo Krummrich
2023-01-24 0:11 ` Danilo Krummrich
2023-01-24 17:26 ` Niranjana Vishwanathapura
2023-01-26 23:43 ` Matthew Brost
2023-01-26 23:43 ` Matthew Brost
2023-01-27 0:24 ` Matthew Brost
2023-01-27 0:24 ` Matthew Brost
2023-01-28 1:51 ` Danilo Krummrich
2023-02-03 17:37 ` Matthew Brost
2023-02-03 17:37 ` Matthew Brost
2023-02-06 13:35 ` Christian König
2023-02-06 13:35 ` Christian König
2023-02-06 13:35 ` [Nouveau] " Christian König
2023-02-06 13:46 ` Danilo Krummrich
2023-02-06 13:46 ` Danilo Krummrich
2023-02-06 13:46 ` [Nouveau] " Danilo Krummrich
2023-02-14 11:52 ` Danilo Krummrich
2023-02-14 11:52 ` Danilo Krummrich
2023-02-14 11:52 ` [Nouveau] " Danilo Krummrich
2023-01-18 6:12 ` [PATCH drm-next 04/14] drm: debugfs: provide infrastructure to dump a DRM GPU VA space Danilo Krummrich
2023-01-18 6:12 ` Danilo Krummrich
2023-01-18 6:12 ` [Nouveau] " Danilo Krummrich
2023-01-18 13:55 ` kernel test robot
2023-01-18 13:55 ` kernel test robot
2023-01-18 13:55 ` [Nouveau] " kernel test robot
2023-01-18 15:47 ` kernel test robot
2023-01-18 15:47 ` kernel test robot
2023-01-18 15:47 ` [Nouveau] " kernel test robot
2023-01-18 6:12 ` [PATCH drm-next 05/14] drm/nouveau: new VM_BIND uapi interfaces Danilo Krummrich
2023-01-18 6:12 ` Danilo Krummrich
2023-01-18 6:12 ` [Nouveau] " Danilo Krummrich
2023-01-27 1:05 ` Matthew Brost
2023-01-27 1:05 ` Matthew Brost
2023-01-27 1:26 ` Danilo Krummrich
2023-01-27 1:26 ` Danilo Krummrich
2023-01-27 1:26 ` [Nouveau] " Danilo Krummrich
2023-01-27 7:55 ` Christian König
2023-01-27 7:55 ` Christian König
2023-01-27 7:55 ` [Nouveau] " Christian König
2023-01-27 13:12 ` Danilo Krummrich
2023-01-27 13:12 ` Danilo Krummrich
2023-01-27 13:12 ` [Nouveau] " Danilo Krummrich
2023-01-27 13:23 ` Christian König
2023-01-27 13:23 ` Christian König
2023-01-27 13:23 ` [Nouveau] " Christian König
2023-01-27 14:44 ` Danilo Krummrich
2023-01-27 14:44 ` Danilo Krummrich
2023-01-27 14:44 ` [Nouveau] " Danilo Krummrich
2023-01-27 15:17 ` Christian König
2023-01-27 15:17 ` Christian König
2023-01-27 15:17 ` [Nouveau] " Christian König
2023-01-27 20:25 ` David Airlie
2023-01-27 20:25 ` David Airlie
2023-01-27 20:25 ` [Nouveau] " David Airlie
2023-01-30 12:58 ` Christian König
2023-01-30 12:58 ` Christian König
2023-01-30 12:58 ` [Nouveau] " Christian König
2023-01-27 21:09 ` Danilo Krummrich
2023-01-27 21:09 ` Danilo Krummrich
2023-01-27 21:09 ` [Nouveau] " Danilo Krummrich
2023-01-29 18:46 ` Danilo Krummrich
2023-01-29 18:46 ` Danilo Krummrich
2023-01-29 18:46 ` [Nouveau] " Danilo Krummrich
2023-01-30 13:02 ` Christian König
2023-01-30 13:02 ` Christian König
2023-01-30 13:02 ` [Nouveau] " Christian König
2023-01-30 23:38 ` Danilo Krummrich
2023-01-30 23:38 ` Danilo Krummrich
2023-01-30 23:38 ` [Nouveau] " Danilo Krummrich
2023-02-01 8:10 ` Dave Airlie
2023-02-01 8:10 ` Dave Airlie
2023-02-01 8:10 ` Dave Airlie
2023-02-02 11:53 ` Christian König
2023-02-02 11:53 ` Christian König
2023-02-02 11:53 ` Christian König
2023-02-02 18:31 ` Danilo Krummrich
2023-02-02 18:31 ` Danilo Krummrich
2023-02-02 18:31 ` Danilo Krummrich
2023-02-06 9:48 ` Christian König
2023-02-06 9:48 ` Christian König
2023-02-06 9:48 ` Christian König
2023-02-06 13:27 ` Danilo Krummrich
2023-02-06 13:27 ` Danilo Krummrich
2023-02-06 13:27 ` Danilo Krummrich
2023-02-06 16:14 ` Christian König
2023-02-06 16:14 ` Christian König
2023-02-06 16:14 ` Christian König
2023-02-06 18:20 ` Danilo Krummrich
2023-02-06 18:20 ` Danilo Krummrich
2023-02-06 18:20 ` Danilo Krummrich
2023-02-07 9:35 ` Christian König
2023-02-07 9:35 ` Christian König
2023-02-07 9:35 ` Christian König
2023-02-07 10:50 ` Danilo Krummrich
2023-02-07 10:50 ` Danilo Krummrich
2023-02-07 10:50 ` Danilo Krummrich
2023-02-10 11:50 ` Christian König
2023-02-10 11:50 ` Christian König
2023-02-10 11:50 ` Christian König
2023-02-10 12:47 ` Danilo Krummrich
2023-02-10 12:47 ` Danilo Krummrich
2023-02-10 12:47 ` Danilo Krummrich
2023-01-27 1:43 ` Danilo Krummrich
2023-01-27 1:43 ` Danilo Krummrich
2023-01-27 1:43 ` [Nouveau] " Danilo Krummrich
2023-01-27 3:21 ` Matthew Brost
2023-01-27 3:21 ` Matthew Brost
2023-01-27 3:33 ` Danilo Krummrich
2023-01-27 3:33 ` Danilo Krummrich
2023-01-27 3:33 ` [Nouveau] " Danilo Krummrich
2023-01-18 6:12 ` [PATCH drm-next 06/14] drm/nouveau: get vmm via nouveau_cli_vmm() Danilo Krummrich
2023-01-18 6:12 ` Danilo Krummrich
2023-01-18 6:12 ` [Nouveau] " Danilo Krummrich
2023-01-18 6:12 ` [PATCH drm-next 07/14] drm/nouveau: bo: initialize GEM GPU VA interface Danilo Krummrich
2023-01-18 6:12 ` Danilo Krummrich
2023-01-18 6:12 ` [Nouveau] " Danilo Krummrich
2023-01-18 6:12 ` [PATCH drm-next 08/14] drm/nouveau: move usercopy helpers to nouveau_drv.h Danilo Krummrich
2023-01-18 6:12 ` Danilo Krummrich
2023-01-18 6:12 ` [Nouveau] " Danilo Krummrich
2023-01-18 6:12 ` [PATCH drm-next 09/14] drm/nouveau: fence: fail to emit when fence context is killed Danilo Krummrich
2023-01-18 6:12 ` Danilo Krummrich
2023-01-18 6:12 ` [Nouveau] " Danilo Krummrich
2023-01-18 6:12 ` [PATCH drm-next 10/14] drm/nouveau: chan: provide nouveau_channel_kill() Danilo Krummrich
2023-01-18 6:12 ` Danilo Krummrich
2023-01-18 6:12 ` [Nouveau] " Danilo Krummrich
2023-01-18 6:12 ` [PATCH drm-next 11/14] drm/nouveau: nvkm/vmm: implement raw ops to manage uvmm Danilo Krummrich
2023-01-18 6:12 ` Danilo Krummrich
2023-01-18 6:12 ` [Nouveau] " Danilo Krummrich
2023-01-18 9:37 ` kernel test robot
2023-01-18 9:37 ` kernel test robot
2023-01-20 3:37 ` kernel test robot
2023-01-20 3:37 ` kernel test robot
2023-01-20 3:37 ` [Nouveau] " kernel test robot
2023-01-18 6:12 ` [PATCH drm-next 12/14] drm/nouveau: implement uvmm for user mode bindings Danilo Krummrich
2023-01-18 6:12 ` Danilo Krummrich
2023-01-18 6:12 ` [Nouveau] " Danilo Krummrich
2023-01-18 6:12 ` [PATCH drm-next 13/14] drm/nouveau: implement new VM_BIND UAPI Danilo Krummrich
2023-01-18 6:12 ` Danilo Krummrich
2023-01-18 6:12 ` [Nouveau] " Danilo Krummrich
2023-01-18 8:37 ` kernel test robot
2023-01-18 8:37 ` kernel test robot
2023-01-18 20:37 ` Thomas Hellström (Intel)
2023-01-18 20:37 ` [Nouveau] " Thomas Hellström (Intel)
2023-01-19 3:44 ` Danilo Krummrich
2023-01-19 3:44 ` [Nouveau] " Danilo Krummrich
2023-01-19 4:58 ` Matthew Brost
2023-01-19 4:58 ` Matthew Brost
2023-01-19 7:32 ` Thomas Hellström (Intel)
2023-01-19 7:32 ` Thomas Hellström (Intel)
2023-01-19 7:32 ` [Nouveau] " Thomas Hellström (Intel)
2023-01-19 15:36 ` Danilo Krummrich
2023-01-19 16:38 ` Matthew Brost
2023-01-19 17:46 ` Danilo Krummrich
2023-01-19 21:47 ` Matthew Brost
2023-01-19 22:25 ` Danilo Krummrich
2023-01-20 4:30 ` Matthew Brost
2023-01-20 10:22 ` Boris Brezillon
2023-01-22 17:48 ` Matthew Brost
2023-01-23 10:01 ` Boris Brezillon
2023-01-20 10:08 ` Boris Brezillon [this message]
2023-01-20 10:08 ` Boris Brezillon
2023-01-20 10:08 ` [Nouveau] " Boris Brezillon
2023-01-18 6:12 ` [PATCH drm-next 14/14] drm/nouveau: debugfs: implement DRM GPU VA debugfs Danilo Krummrich
2023-01-18 6:12 ` Danilo Krummrich
2023-01-18 6:12 ` [Nouveau] " Danilo Krummrich
2023-01-18 8:53 ` [PATCH drm-next 00/14] [RFC] DRM GPUVA Manager & Nouveau VM_BIND UAPI Christian König
2023-01-18 8:53 ` Christian König
2023-01-18 8:53 ` [Nouveau] " Christian König
2023-01-18 15:34 ` Danilo Krummrich
2023-01-18 15:34 ` Danilo Krummrich
2023-01-18 15:34 ` [Nouveau] " Danilo Krummrich
2023-01-18 15:37 ` Christian König
2023-01-18 15:37 ` Christian König
2023-01-18 15:37 ` [Nouveau] " Christian König
2023-01-18 16:19 ` Danilo Krummrich
2023-01-18 16:19 ` Danilo Krummrich
2023-01-18 16:19 ` [Nouveau] " Danilo Krummrich
2023-01-18 16:30 ` Alex Deucher
2023-01-18 16:30 ` Alex Deucher
2023-01-18 16:30 ` [Nouveau] " Alex Deucher
2023-01-18 16:50 ` Danilo Krummrich
2023-01-18 16:50 ` Danilo Krummrich
2023-01-18 16:50 ` [Nouveau] " Danilo Krummrich
2023-01-18 16:54 ` Alex Deucher
2023-01-18 16:54 ` Alex Deucher
2023-01-18 16:54 ` [Nouveau] " Alex Deucher
2023-01-18 19:17 ` Dave Airlie
2023-01-18 19:17 ` Dave Airlie
2023-01-18 19:17 ` [Nouveau] " Dave Airlie
2023-01-18 19:48 ` Christian König
2023-01-18 19:48 ` Christian König
2023-01-18 19:48 ` [Nouveau] " Christian König
2023-01-19 4:04 ` Danilo Krummrich
2023-01-19 4:04 ` Danilo Krummrich
2023-01-19 4:04 ` [Nouveau] " Danilo Krummrich
2023-01-19 5:23 ` Matthew Brost
2023-01-19 5:23 ` Matthew Brost
2023-01-19 11:33 ` drm_gpuva_manager requirements (was Re: [PATCH drm-next 00/14] [RFC] DRM GPUVA Manager & Nouveau VM_BIND UAPI) Christian König
2023-01-19 11:33 ` Christian König
2023-01-19 11:33 ` [Nouveau] " Christian König
2023-02-06 14:48 ` [PATCH drm-next 00/14] [RFC] DRM GPUVA Manager & Nouveau VM_BIND UAPI Oded Gabbay
2023-02-06 14:48 ` Oded Gabbay
2023-03-16 16:39 ` Danilo Krummrich
2023-03-16 16:39 ` Danilo Krummrich
2023-03-16 16:39 ` [Nouveau] " Danilo Krummrich
-- strict thread matches above, loose matches on Subject: below --
2023-01-19 23:32 [PATCH drm-next 13/14] drm/nouveau: implement new " kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230120110833.76cc7864@collabora.com \
--to=boris.brezillon@collabora.com \
--cc=airlied@redhat.com \
--cc=bskeggs@redhat.com \
--cc=christian.koenig@amd.com \
--cc=corbet@lwn.net \
--cc=dakr@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jason@jlekstrand.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.brost@intel.com \
--cc=nouveau@lists.freedesktop.org \
--cc=thomas_os@shipmail.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.