From: Jakub Kicinski <kuba@kernel.org>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: bpf@vger.kernel.org, netdev@vger.kernel.org, ast@kernel.org,
daniel@iogearbox.net, andrii@kernel.org, davem@davemloft.net,
hawk@kernel.org, pabeni@redhat.com, edumazet@google.com,
toke@redhat.com, memxor@gmail.com, alardam@gmail.com,
saeedm@nvidia.com, anthony.l.nguyen@intel.com,
gospo@broadcom.com, vladimir.oltean@nxp.com, nbd@nbd.name,
john@phrozen.org, leon@kernel.org, simon.horman@corigine.com,
aelior@marvell.com, christophe.jaillet@wanadoo.fr,
ecree.xilinx@gmail.com, mst@redhat.com, bjorn@kernel.org,
magnus.karlsson@intel.com, maciej.fijalkowski@intel.com,
intel-wired-lan@lists.osuosl.org, lorenzo.bianconi@redhat.com,
martin.lau@linux.dev
Subject: Re: [PATCH v2 bpf-next 2/8] drivers: net: turn on XDP features
Date: Tue, 24 Jan 2023 19:04:14 -0800 [thread overview]
Message-ID: <20230124190414.2dab95a2@kernel.org> (raw)
In-Reply-To: <c1171111f8af76da11331277b1e4a930c10f3c30.1674606197.git.lorenzo@kernel.org>
On Wed, 25 Jan 2023 01:33:22 +0100 Lorenzo Bianconi wrote:
> A summary of the flags being set for various drivers is given below.
> Note that XDP_F_REDIRECT_TARGET and XDP_F_FRAG_TARGET are features
> that can be turned off and on at runtime. This means that these flags
> may be set and unset under RTNL lock protection by the driver. Hence,
> READ_ONCE must be used by code loading the flag value.
>
> Also, these flags are not used for synchronization against the availability
> of XDP resources on a device. It is merely a hint, and hence the read
> may race with the actual teardown of XDP resources on the device. This
> may change in the future, e.g. operations taking a reference on the XDP
> resources of the driver, and in turn inhibiting turning off this flag.
> However, for now, it can only be used as a hint to check whether device
> supports becoming a redirection target.
Acked-by: Jakub Kicinski <kuba@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: mst@redhat.com, vladimir.oltean@nxp.com, ast@kernel.org,
edumazet@google.com, anthony.l.nguyen@intel.com,
daniel@iogearbox.net, andrii@kernel.org,
intel-wired-lan@lists.osuosl.org, simon.horman@corigine.com,
pabeni@redhat.com, aelior@marvell.com, hawk@kernel.org,
christophe.jaillet@wanadoo.fr, memxor@gmail.com,
john@phrozen.org, bjorn@kernel.org, bpf@vger.kernel.org,
magnus.karlsson@intel.com, leon@kernel.org,
netdev@vger.kernel.org, toke@redhat.com, martin.lau@linux.dev,
ecree.xilinx@gmail.com, alardam@gmail.com, gospo@broadcom.com,
saeedm@nvidia.com, davem@davemloft.net, nbd@nbd.name
Subject: Re: [Intel-wired-lan] [PATCH v2 bpf-next 2/8] drivers: net: turn on XDP features
Date: Tue, 24 Jan 2023 19:04:14 -0800 [thread overview]
Message-ID: <20230124190414.2dab95a2@kernel.org> (raw)
In-Reply-To: <c1171111f8af76da11331277b1e4a930c10f3c30.1674606197.git.lorenzo@kernel.org>
On Wed, 25 Jan 2023 01:33:22 +0100 Lorenzo Bianconi wrote:
> A summary of the flags being set for various drivers is given below.
> Note that XDP_F_REDIRECT_TARGET and XDP_F_FRAG_TARGET are features
> that can be turned off and on at runtime. This means that these flags
> may be set and unset under RTNL lock protection by the driver. Hence,
> READ_ONCE must be used by code loading the flag value.
>
> Also, these flags are not used for synchronization against the availability
> of XDP resources on a device. It is merely a hint, and hence the read
> may race with the actual teardown of XDP resources on the device. This
> may change in the future, e.g. operations taking a reference on the XDP
> resources of the driver, and in turn inhibiting turning off this flag.
> However, for now, it can only be used as a hint to check whether device
> supports becoming a redirection target.
Acked-by: Jakub Kicinski <kuba@kernel.org>
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
next prev parent reply other threads:[~2023-01-25 3:04 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-25 0:33 [PATCH v2 bpf-next 0/8] xdp: introduce xdp-feature support Lorenzo Bianconi
2023-01-25 0:33 ` [Intel-wired-lan] " Lorenzo Bianconi
2023-01-25 0:33 ` [PATCH v2 bpf-next 1/8] netdev-genl: create a simple family for netdev stuff Lorenzo Bianconi
2023-01-25 0:33 ` [Intel-wired-lan] " Lorenzo Bianconi
2023-01-25 10:12 ` Jesper Dangaard Brouer
2023-01-25 10:12 ` [Intel-wired-lan] " Jesper Dangaard Brouer
2023-01-25 0:33 ` [PATCH v2 bpf-next 2/8] drivers: net: turn on XDP features Lorenzo Bianconi
2023-01-25 0:33 ` [Intel-wired-lan] " Lorenzo Bianconi
2023-01-25 3:04 ` Jakub Kicinski [this message]
2023-01-25 3:04 ` Jakub Kicinski
2023-01-25 4:00 ` kernel test robot
2023-01-25 4:00 ` [Intel-wired-lan] " kernel test robot
2023-01-25 8:27 ` Simon Horman
2023-01-25 8:27 ` [Intel-wired-lan] " Simon Horman
2023-01-26 19:09 ` Gerhard Engleder
2023-01-26 19:09 ` [Intel-wired-lan] " Gerhard Engleder
2023-01-26 22:00 ` Lorenzo Bianconi
2023-01-26 22:00 ` [Intel-wired-lan] " Lorenzo Bianconi
2023-01-29 13:05 ` Lorenzo Bianconi
2023-01-29 13:05 ` [Intel-wired-lan] " Lorenzo Bianconi
2023-01-30 14:09 ` Gerhard Engleder
2023-01-30 14:09 ` [Intel-wired-lan] " Gerhard Engleder
2023-01-25 0:33 ` [PATCH v2 bpf-next 3/8] xsk: add usage of XDP features flags Lorenzo Bianconi
2023-01-25 0:33 ` [Intel-wired-lan] " Lorenzo Bianconi
2023-01-25 0:33 ` [PATCH v2 bpf-next 4/8] libbpf: add the capability to specify netlink proto in libbpf_netlink_send_recv Lorenzo Bianconi
2023-01-25 0:33 ` [Intel-wired-lan] " Lorenzo Bianconi
2023-01-25 0:33 ` [PATCH v2 bpf-next 5/8] libbpf: add API to get XDP/XSK supported features Lorenzo Bianconi
2023-01-25 0:33 ` [Intel-wired-lan] " Lorenzo Bianconi
2023-01-25 0:33 ` [PATCH v2 bpf-next 6/8] bpf: devmap: check XDP features in __xdp_enqueue routine Lorenzo Bianconi
2023-01-25 0:33 ` [Intel-wired-lan] " Lorenzo Bianconi
2023-01-25 10:35 ` Jesper Dangaard Brouer
2023-01-25 10:35 ` [Intel-wired-lan] " Jesper Dangaard Brouer
2023-01-25 0:33 ` [PATCH v2 bpf-next 7/8] selftests/bpf: add test for bpf_xdp_query xdp-features support Lorenzo Bianconi
2023-01-25 0:33 ` [Intel-wired-lan] " Lorenzo Bianconi
2023-01-25 0:33 ` [PATCH v2 bpf-next 8/8] selftests/bpf: introduce XDP compliance test tool Lorenzo Bianconi
2023-01-25 0:33 ` [Intel-wired-lan] " Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230124190414.2dab95a2@kernel.org \
--to=kuba@kernel.org \
--cc=aelior@marvell.com \
--cc=alardam@gmail.com \
--cc=andrii@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=ast@kernel.org \
--cc=bjorn@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=gospo@broadcom.com \
--cc=hawk@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=john@phrozen.org \
--cc=leon@kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=lorenzo@kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=martin.lau@linux.dev \
--cc=memxor@gmail.com \
--cc=mst@redhat.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=simon.horman@corigine.com \
--cc=toke@redhat.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.