All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Leon Romanovsky <leon@kernel.org>
Cc: Steffen Klassert <steffen.klassert@secunet.com>,
	Veaceslav Falico <vfalico@gmail.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	Jonathan Corbet <corbet@lwn.net>,
	Tony Nguyen <anthony.l.nguyen@intel.com>,
	Jay Vosburgh <j.vosburgh@gmail.com>,
	oss-drivers@corigine.com, linux-doc@vger.kernel.org,
	Raju Rangoju <rajur@chelsio.com>,
	Jesse Brandeburg <jesse.brandeburg@intel.com>,
	Eric Dumazet <edumazet@google.com>,
	netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
	Ayush Sawal <ayush.sawal@chelsio.com>,
	Simon Horman <simon.horman@corigine.com>,
	Saeed Mahameed <saeedm@nvidia.com>,
	Paolo Abeni <pabeni@redhat.com>,
	Leon Romanovsky <leonro@nvidia.com>,
	"David S . Miller" <davem@davemloft.net>,
	Andy Gospodarek <andy@greyhouse.net>
Subject: Re: [Intel-wired-lan] [PATCH net-next v1 01/10] xfrm: extend add policy callback to set failure reason
Date: Wed, 25 Jan 2023 11:02:26 -0800	[thread overview]
Message-ID: <20230125110226.66dc7eeb@kernel.org> (raw)
In-Reply-To: <c182cae29914fa19ce970859e74234d3de506853.1674560845.git.leon@kernel.org>

On Tue, 24 Jan 2023 13:54:57 +0200 Leon Romanovsky wrote:
> -	err = dev->xfrmdev_ops->xdo_dev_policy_add(xp);
> +	err = dev->xfrmdev_ops->xdo_dev_policy_add(xp, extack);
>  	if (err) {
>  		xdo->dev = NULL;
>  		xdo->real_dev = NULL;
>  		xdo->type = XFRM_DEV_OFFLOAD_UNSPECIFIED;
>  		xdo->dir = 0;
>  		netdev_put(dev, &xdo->dev_tracker);
> -		NL_SET_ERR_MSG(extack, "Device failed to offload this policy");

In a handful of places we do:

if (!extack->msg)
	NL_SET_ERR_MSG(extack, "Device failed to offload this policy");

in case the device did not provide the extack.
Dunno if it's worth doing here.
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Leon Romanovsky <leon@kernel.org>
Cc: "David S . Miller" <davem@davemloft.net>,
	Steffen Klassert <steffen.klassert@secunet.com>,
	Leon Romanovsky <leonro@nvidia.com>,
	Andy Gospodarek <andy@greyhouse.net>,
	Ayush Sawal <ayush.sawal@chelsio.com>,
	Eric Dumazet <edumazet@google.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	intel-wired-lan@lists.osuosl.org,
	Jay Vosburgh <j.vosburgh@gmail.com>,
	Jesse Brandeburg <jesse.brandeburg@intel.com>,
	Jonathan Corbet <corbet@lwn.net>,
	linux-doc@vger.kernel.org, netdev@vger.kernel.org,
	oss-drivers@corigine.com, Paolo Abeni <pabeni@redhat.com>,
	Raju Rangoju <rajur@chelsio.com>,
	Saeed Mahameed <saeedm@nvidia.com>,
	Simon Horman <simon.horman@corigine.com>,
	Tony Nguyen <anthony.l.nguyen@intel.com>,
	Veaceslav Falico <vfalico@gmail.com>
Subject: Re: [PATCH net-next v1 01/10] xfrm: extend add policy callback to set failure reason
Date: Wed, 25 Jan 2023 11:02:26 -0800	[thread overview]
Message-ID: <20230125110226.66dc7eeb@kernel.org> (raw)
In-Reply-To: <c182cae29914fa19ce970859e74234d3de506853.1674560845.git.leon@kernel.org>

On Tue, 24 Jan 2023 13:54:57 +0200 Leon Romanovsky wrote:
> -	err = dev->xfrmdev_ops->xdo_dev_policy_add(xp);
> +	err = dev->xfrmdev_ops->xdo_dev_policy_add(xp, extack);
>  	if (err) {
>  		xdo->dev = NULL;
>  		xdo->real_dev = NULL;
>  		xdo->type = XFRM_DEV_OFFLOAD_UNSPECIFIED;
>  		xdo->dir = 0;
>  		netdev_put(dev, &xdo->dev_tracker);
> -		NL_SET_ERR_MSG(extack, "Device failed to offload this policy");

In a handful of places we do:

if (!extack->msg)
	NL_SET_ERR_MSG(extack, "Device failed to offload this policy");

in case the device did not provide the extack.
Dunno if it's worth doing here.

  reply	other threads:[~2023-01-25 19:02 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-24 11:54 [Intel-wired-lan] [PATCH net-next v1 00/10] Convert drivers to return XFRM configuration errors through extack Leon Romanovsky
2023-01-24 11:54 ` Leon Romanovsky
2023-01-24 11:54 ` [Intel-wired-lan] [PATCH net-next v1 01/10] xfrm: extend add policy callback to set failure reason Leon Romanovsky
2023-01-24 11:54   ` Leon Romanovsky
2023-01-25 19:02   ` Jakub Kicinski [this message]
2023-01-25 19:02     ` Jakub Kicinski
2023-01-26  7:28     ` [Intel-wired-lan] " Leon Romanovsky
2023-01-26  7:28       ` Leon Romanovsky
2023-01-26  9:45       ` [Intel-wired-lan] " Paolo Abeni
2023-01-26  9:45         ` Paolo Abeni
2023-01-26 10:42         ` [Intel-wired-lan] " Leon Romanovsky
2023-01-26 10:42           ` Leon Romanovsky
2023-01-26 19:17           ` [Intel-wired-lan] " Leon Romanovsky
2023-01-26 19:17             ` Leon Romanovsky
2023-01-24 11:54 ` [Intel-wired-lan] [PATCH net-next v1 02/10] net/mlx5e: Fill IPsec policy validation " Leon Romanovsky
2023-01-24 11:54   ` Leon Romanovsky
2023-01-24 11:54 ` [Intel-wired-lan] [PATCH net-next v1 03/10] xfrm: extend add state callback to set " Leon Romanovsky
2023-01-24 11:54   ` Leon Romanovsky
2023-01-24 11:55 ` [Intel-wired-lan] [PATCH net-next v1 04/10] net/mlx5e: Fill IPsec state validation " Leon Romanovsky
2023-01-24 11:55   ` Leon Romanovsky
2023-01-24 11:55 ` [Intel-wired-lan] [PATCH net-next v1 05/10] netdevsim: " Leon Romanovsky
2023-01-24 11:55   ` Leon Romanovsky
2023-01-24 11:55 ` [Intel-wired-lan] [PATCH net-next v1 06/10] nfp: fill " Leon Romanovsky
2023-01-24 11:55   ` Leon Romanovsky
2023-01-24 11:55 ` [Intel-wired-lan] [PATCH net-next v1 07/10] ixgbevf: " Leon Romanovsky
2023-01-24 11:55   ` Leon Romanovsky
2023-01-24 11:55 ` [Intel-wired-lan] [PATCH net-next v1 08/10] ixgbe: " Leon Romanovsky
2023-01-24 11:55   ` Leon Romanovsky
2023-01-24 11:55 ` [Intel-wired-lan] [PATCH net-next v1 09/10] bonding: " Leon Romanovsky
2023-01-24 11:55   ` Leon Romanovsky
2023-01-24 11:55 ` [Intel-wired-lan] [PATCH net-next v1 10/10] cxgb4: " Leon Romanovsky
2023-01-24 11:55   ` Leon Romanovsky
2023-01-25 19:01 ` [Intel-wired-lan] [PATCH net-next v1 00/10] Convert drivers to return XFRM configuration errors through extack Jakub Kicinski
2023-01-25 19:01   ` Jakub Kicinski
2023-01-26  9:43   ` [Intel-wired-lan] " Steffen Klassert
2023-01-26  9:43     ` Steffen Klassert
2023-01-27  0:50 ` [Intel-wired-lan] " patchwork-bot+netdevbpf
2023-01-27  0:50   ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230125110226.66dc7eeb@kernel.org \
    --to=kuba@kernel.org \
    --cc=andy@greyhouse.net \
    --cc=anthony.l.nguyen@intel.com \
    --cc=ayush.sawal@chelsio.com \
    --cc=corbet@lwn.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=j.vosburgh@gmail.com \
    --cc=jesse.brandeburg@intel.com \
    --cc=leon@kernel.org \
    --cc=leonro@nvidia.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=oss-drivers@corigine.com \
    --cc=pabeni@redhat.com \
    --cc=rajur@chelsio.com \
    --cc=saeedm@nvidia.com \
    --cc=simon.horman@corigine.com \
    --cc=steffen.klassert@secunet.com \
    --cc=vfalico@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.