All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: Philippe Schenker <dev@pschenker.ch>
Cc: devicetree@vger.kernel.org,
	Philippe Schenker <philippe.schenker@toradex.com>,
	Andrejs Cainikovs <andrejs.cainikovs@toradex.com>,
	Fabio Estevam <festevam@gmail.com>,
	Francesco Dolcini <francesco.dolcini@toradex.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Marcel Ziswiler <marcel.ziswiler@toradex.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Rob Herring <robh+dt@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: imx8mm-verdin: Do not power down eth-phy
Date: Thu, 26 Jan 2023 15:32:36 +0800	[thread overview]
Message-ID: <20230126073235.GU20713@T480> (raw)
In-Reply-To: <20230116140153.23938-1-dev@pschenker.ch>

On Mon, Jan 16, 2023 at 03:01:52PM +0100, Philippe Schenker wrote:
> From: Philippe Schenker <philippe.schenker@toradex.com>
> 
> Currently if suspending using either freeze or memory state, the fec
> driver tries to power down the phy which leads to crash of the kernel
> and non-responsible kernel with the following call trace:
> 
> [   24.839889 ] Call trace:
> [   24.839892 ]  phy_error+0x18/0x60
> [   24.839898 ]  kszphy_handle_interrupt+0x6c/0x80
> [   24.839903 ]  phy_interrupt+0x20/0x2c
> [   24.839909 ]  irq_thread_fn+0x30/0xa0
> [   24.839919 ]  irq_thread+0x178/0x2c0
> [   24.839925 ]  kthread+0x154/0x160
> [   24.839932 ]  ret_from_fork+0x10/0x20
> 
> Since there is currently no functionality in the phy subsystem to power
> down phys let's just disable the feature of powering-down the ethernet
> phy.
> 
> Fixes: 6a57f224f734 ("arm64: dts: freescale: add initial support for verdin imx8m mini")
> Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com>

Applied, thanks!

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Philippe Schenker <dev@pschenker.ch>
Cc: devicetree@vger.kernel.org,
	Philippe Schenker <philippe.schenker@toradex.com>,
	Andrejs Cainikovs <andrejs.cainikovs@toradex.com>,
	Fabio Estevam <festevam@gmail.com>,
	Francesco Dolcini <francesco.dolcini@toradex.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Marcel Ziswiler <marcel.ziswiler@toradex.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Rob Herring <robh+dt@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: imx8mm-verdin: Do not power down eth-phy
Date: Thu, 26 Jan 2023 15:32:36 +0800	[thread overview]
Message-ID: <20230126073235.GU20713@T480> (raw)
In-Reply-To: <20230116140153.23938-1-dev@pschenker.ch>

On Mon, Jan 16, 2023 at 03:01:52PM +0100, Philippe Schenker wrote:
> From: Philippe Schenker <philippe.schenker@toradex.com>
> 
> Currently if suspending using either freeze or memory state, the fec
> driver tries to power down the phy which leads to crash of the kernel
> and non-responsible kernel with the following call trace:
> 
> [   24.839889 ] Call trace:
> [   24.839892 ]  phy_error+0x18/0x60
> [   24.839898 ]  kszphy_handle_interrupt+0x6c/0x80
> [   24.839903 ]  phy_interrupt+0x20/0x2c
> [   24.839909 ]  irq_thread_fn+0x30/0xa0
> [   24.839919 ]  irq_thread+0x178/0x2c0
> [   24.839925 ]  kthread+0x154/0x160
> [   24.839932 ]  ret_from_fork+0x10/0x20
> 
> Since there is currently no functionality in the phy subsystem to power
> down phys let's just disable the feature of powering-down the ethernet
> phy.
> 
> Fixes: 6a57f224f734 ("arm64: dts: freescale: add initial support for verdin imx8m mini")
> Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com>

Applied, thanks!

  reply	other threads:[~2023-01-26  7:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-16 14:01 [PATCH] arm64: dts: imx8mm-verdin: Do not power down eth-phy Philippe Schenker
2023-01-16 14:01 ` Philippe Schenker
2023-01-26  7:32 ` Shawn Guo [this message]
2023-01-26  7:32   ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230126073235.GU20713@T480 \
    --to=shawnguo@kernel.org \
    --cc=andrejs.cainikovs@toradex.com \
    --cc=dev@pschenker.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=francesco.dolcini@toradex.com \
    --cc=kernel@pengutronix.de \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcel.ziswiler@toradex.com \
    --cc=philippe.schenker@toradex.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.