From: Shawn Guo <shawnguo@kernel.org>
To: Philippe Schenker <dev@pschenker.ch>
Cc: devicetree@vger.kernel.org, Rob Herring <robh@kernel.org>,
Philippe Schenker <philippe.schenker@toradex.com>,
Emanuele Ghidoli <emanuele.ghidoli@toradex.com>,
Fabio Estevam <festevam@gmail.com>,
Francesco Dolcini <francesco.dolcini@toradex.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Marcel Ziswiler <marcel.ziswiler@toradex.com>,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Rob Herring <robh+dt@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] arm64: dts: (imx8mm|imx8mp)-verdin-dev: Do not include dahlia dtsi
Date: Thu, 26 Jan 2023 16:06:13 +0800 [thread overview]
Message-ID: <20230126080611.GC20713@T480> (raw)
In-Reply-To: <20230118105251.6035-1-dev@pschenker.ch>
On Wed, Jan 18, 2023 at 11:52:49AM +0100, Philippe Schenker wrote:
> From: Philippe Schenker <philippe.schenker@toradex.com>
>
>
> We so far included the Dahlia device-tree in the development board
> devicetree in order to try to minimize code duplication.
>
> This mainly gets rid of ''status = "okay"' lines. Plus we saw that some
> settings in the audio-codec of verdin-imx8mm are inherited that are
> wrong for the development board. Those did also lead to the DT Schema
> checker to fail on multiple settings.
>
> We decided to remove this include in order to get the audio-codec
> settings correct and make the DT Schema checker return less warnings.
> This introduces some code duplication which we consider being mostly
> only configuration of the actual development/dahlia boards.
>
> This series of two patches removes the include for both Verdin boards we
> have at the moment.
>
> This issue was spotted by Rob Herring. [1]
>
> [1] https://lore.kernel.org/all/167182349408.373865.10339766752503211557.robh@kernel.org/
>
>
> Philippe Schenker (2):
> arm64: dts: imx8mm-verdin-dev: Do not include dahlia dtsi
> arm64: dts: imx8mp-verdin-dev: Do not include dahlia dtsi
Applied both, thanks!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Philippe Schenker <dev@pschenker.ch>
Cc: devicetree@vger.kernel.org, Rob Herring <robh@kernel.org>,
Philippe Schenker <philippe.schenker@toradex.com>,
Emanuele Ghidoli <emanuele.ghidoli@toradex.com>,
Fabio Estevam <festevam@gmail.com>,
Francesco Dolcini <francesco.dolcini@toradex.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Marcel Ziswiler <marcel.ziswiler@toradex.com>,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Rob Herring <robh+dt@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] arm64: dts: (imx8mm|imx8mp)-verdin-dev: Do not include dahlia dtsi
Date: Thu, 26 Jan 2023 16:06:13 +0800 [thread overview]
Message-ID: <20230126080611.GC20713@T480> (raw)
In-Reply-To: <20230118105251.6035-1-dev@pschenker.ch>
On Wed, Jan 18, 2023 at 11:52:49AM +0100, Philippe Schenker wrote:
> From: Philippe Schenker <philippe.schenker@toradex.com>
>
>
> We so far included the Dahlia device-tree in the development board
> devicetree in order to try to minimize code duplication.
>
> This mainly gets rid of ''status = "okay"' lines. Plus we saw that some
> settings in the audio-codec of verdin-imx8mm are inherited that are
> wrong for the development board. Those did also lead to the DT Schema
> checker to fail on multiple settings.
>
> We decided to remove this include in order to get the audio-codec
> settings correct and make the DT Schema checker return less warnings.
> This introduces some code duplication which we consider being mostly
> only configuration of the actual development/dahlia boards.
>
> This series of two patches removes the include for both Verdin boards we
> have at the moment.
>
> This issue was spotted by Rob Herring. [1]
>
> [1] https://lore.kernel.org/all/167182349408.373865.10339766752503211557.robh@kernel.org/
>
>
> Philippe Schenker (2):
> arm64: dts: imx8mm-verdin-dev: Do not include dahlia dtsi
> arm64: dts: imx8mp-verdin-dev: Do not include dahlia dtsi
Applied both, thanks!
next prev parent reply other threads:[~2023-01-26 8:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-18 10:52 [PATCH 0/2] arm64: dts: (imx8mm|imx8mp)-verdin-dev: Do not include dahlia dtsi Philippe Schenker
2023-01-18 10:52 ` Philippe Schenker
2023-01-18 10:52 ` [PATCH 1/2] arm64: dts: imx8mm-verdin-dev: " Philippe Schenker
2023-01-18 10:52 ` Philippe Schenker
2023-01-18 10:52 ` [PATCH 2/2] arm64: dts: imx8mp-verdin-dev: " Philippe Schenker
2023-01-18 10:52 ` Philippe Schenker
2023-01-18 15:04 ` Laurent Pinchart
2023-01-18 15:04 ` Laurent Pinchart
2023-01-26 8:06 ` Shawn Guo [this message]
2023-01-26 8:06 ` [PATCH 0/2] arm64: dts: (imx8mm|imx8mp)-verdin-dev: " Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230126080611.GC20713@T480 \
--to=shawnguo@kernel.org \
--cc=dev@pschenker.ch \
--cc=devicetree@vger.kernel.org \
--cc=emanuele.ghidoli@toradex.com \
--cc=festevam@gmail.com \
--cc=francesco.dolcini@toradex.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel.ziswiler@toradex.com \
--cc=philippe.schenker@toradex.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.