* [to-be-updated] mm-highmem-align-down-to-page-the-address-for-kunmap_flush_on_unmap.patch removed from -mm tree
@ 2023-01-26 22:49 Andrew Morton
0 siblings, 0 replies; only message in thread
From: Andrew Morton @ 2023-01-26 22:49 UTC (permalink / raw)
To: mm-commits, willy, viro, tony.luck, tglx, keescook, ira.weiny,
glider, dsterba, deller, bigeasy, bagasdotme, andreyknvl,
fmdefrancesco, akpm
The quilt patch titled
Subject: mm/highmem: align-down to page the address for kunmap_flush_on_unmap()
has been removed from the -mm tree. Its filename was
mm-highmem-align-down-to-page-the-address-for-kunmap_flush_on_unmap.patch
This patch was dropped because an updated version will be merged
------------------------------------------------------
From: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Subject: mm/highmem: align-down to page the address for kunmap_flush_on_unmap()
Date: Thu, 26 Jan 2023 15:33:46 +0100
If ARCH_HAS_FLUSH_ON_KUNMAP is defined (PA-RISC case), __kunmap_local()
calls kunmap_flush_on_unmap(). The latter currently flushes the wrong
address (as confirmed by Matthew Wilcox and Helge Deller). Al Viro
proposed to call kunmap_flush_on_unmap() on an aligned-down to page
address in order to fix this issue. Consensus has been reached on this
solution.
Therefore, if ARCH_HAS_FLUSH_ON_KUNMAP is defined, call
kunmap_flush_on_unmap() on an aligned-down to page address computed with
the PTR_ALIGN_DOWN() macro.
Link: https://lkml.kernel.org/r/20230126143346.12086-1-fmdefrancesco@gmail.com
Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
Fixes: f3ba3c710ac5 ("mm/highmem: Provide kmap_local*")
Suggested-by: Al Viro <viro@zeniv.linux.org.uk>
Cc: Ira Weiny <ira.weiny@intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Helge Deller <deller@gmx.de>
Cc: Matthew Wilcox <willy@infradead.org>
Cc: Alexander Potapenko <glider@google.com>
Cc: Andrey Konovalov <andreyknvl@gmail.com>
Cc: Bagas Sanjaya <bagasdotme@gmail.com>
Cc: David Sterba <dsterba@suse.com>
Cc: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Cc: Kees Cook <keescook@chromium.org>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Tony Luck <tony.luck@intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
include/linux/highmem-internal.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/include/linux/highmem-internal.h~mm-highmem-align-down-to-page-the-address-for-kunmap_flush_on_unmap
+++ a/include/linux/highmem-internal.h
@@ -200,7 +200,7 @@ static inline void *kmap_local_pfn(unsig
static inline void __kunmap_local(const void *addr)
{
#ifdef ARCH_HAS_FLUSH_ON_KUNMAP
- kunmap_flush_on_unmap(addr);
+ kunmap_flush_on_unmap(PTR_ALIGN_DOWN(addr, PAGE_SIZE));
#endif
}
_
Patches currently in -mm which might be from fmdefrancesco@gmail.com are
mm-highmem-add-notes-about-conversions-from-kmap_atomic.patch
mm-highmem-add-notes-about-conversions-from-kmap_atomic-v3.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-01-26 22:49 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-26 22:49 [to-be-updated] mm-highmem-align-down-to-page-the-address-for-kunmap_flush_on_unmap.patch removed from -mm tree Andrew Morton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.