* + lib-zlib-remove-redundation-assignement-of-avail_in-dfltcc_gdht.patch added to mm-nonmm-unstable branch
@ 2023-01-29 21:21 Andrew Morton
0 siblings, 0 replies; only message in thread
From: Andrew Morton @ 2023-01-29 21:21 UTC (permalink / raw)
To: mm-commits, iii, trix, akpm
The patch titled
Subject: lib/zlib: remove redundation assignement of avail_in dfltcc_gdht()
has been added to the -mm mm-nonmm-unstable branch. Its filename is
lib-zlib-remove-redundation-assignement-of-avail_in-dfltcc_gdht.patch
This patch will shortly appear at
https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/lib-zlib-remove-redundation-assignement-of-avail_in-dfltcc_gdht.patch
This patch will later appear in the mm-nonmm-unstable branch at
git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next via the mm-everything
branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
and is updated there every 2-3 working days
------------------------------------------------------
From: Tom Rix <trix@redhat.com>
Subject: lib/zlib: remove redundation assignement of avail_in dfltcc_gdht()
Date: Sat, 28 Jan 2023 08:50:48 -0800
cppcheck reports
lib/zlib_dfltcc/dfltcc_deflate.c:65:21: warning: Redundant assignment of 'avail_in' to itself. [selfAssignment]
size_t avail_in = avail_in = strm->avail_in;
Only setting avail_in once is needed.
Link: https://lkml.kernel.org/r/20230128165048.1245792-1-trix@redhat.com
Fixes: aa5b395b69b6 ("lib/zlib: add s390 hardware support for kernel zlib_deflate")
Signed-off-by: Tom Rix <trix@redhat.com>
Acked-by: Ilya Leoshkevich <iii@linux.ibm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
--- a/lib/zlib_dfltcc/dfltcc_deflate.c~lib-zlib-remove-redundation-assignement-of-avail_in-dfltcc_gdht
+++ a/lib/zlib_dfltcc/dfltcc_deflate.c
@@ -62,7 +62,7 @@ static void dfltcc_gdht(
{
deflate_state *state = (deflate_state *)strm->state;
struct dfltcc_param_v0 *param = &GET_DFLTCC_STATE(state)->param;
- size_t avail_in = avail_in = strm->avail_in;
+ size_t avail_in = strm->avail_in;
dfltcc(DFLTCC_GDHT,
param, NULL, NULL,
_
Patches currently in -mm which might be from trix@redhat.com are
lib-zlib-remove-redundation-assignement-of-avail_in-dfltcc_gdht.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-01-29 21:21 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-29 21:21 + lib-zlib-remove-redundation-assignement-of-avail_in-dfltcc_gdht.patch added to mm-nonmm-unstable branch Andrew Morton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.