* [Buildroot] [PATCH 1/1] package/fxdiv: fix build without C++ toolchain
@ 2023-01-30 4:29 James Hilliard
2023-01-30 7:08 ` Yann E. MORIN
0 siblings, 1 reply; 2+ messages in thread
From: James Hilliard @ 2023-01-30 4:29 UTC (permalink / raw)
To: buildroot; +Cc: James Hilliard
The cmake project for fxdiv sets the project language to C and CXX
even when only C is required.
Add a patch which disables CXX unless required.
Fixes:
- http://autobuild.buildroot.net/results/b0f/b0f3b6352429a5156a8c3a2b932331753887b65b
- http://autobuild.buildroot.net/results/52f/52f634c06bdfe983280a2c01bb9fec4b0e1a4b34
- http://autobuild.buildroot.net/results/181/181b85d9dd505693ed23fab823085b001aa785f4
Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
---
...le-CXX-unless-building-tests-benchma.patch | 49 +++++++++++++++++++
1 file changed, 49 insertions(+)
create mode 100644 package/fxdiv/0001-CMake-don-t-enable-CXX-unless-building-tests-benchma.patch
diff --git a/package/fxdiv/0001-CMake-don-t-enable-CXX-unless-building-tests-benchma.patch b/package/fxdiv/0001-CMake-don-t-enable-CXX-unless-building-tests-benchma.patch
new file mode 100644
index 0000000000..0336f5e1cc
--- /dev/null
+++ b/package/fxdiv/0001-CMake-don-t-enable-CXX-unless-building-tests-benchma.patch
@@ -0,0 +1,49 @@
+From 8c2d8fc60306a8edd21182a1f5f267a7aca55763 Mon Sep 17 00:00:00 2001
+From: James Hilliard <james.hilliard1@gmail.com>
+Date: Sun, 29 Jan 2023 21:18:28 -0700
+Subject: [PATCH] CMake: don't enable CXX unless building tests/benchmarks
+
+We only need CXX support when building tests/benchmarks.
+
+Fixes:
+CMake Error at CMakeLists.txt:4 (PROJECT):
+ No CMAKE_CXX_COMPILER could be found.
+
+ Tell CMake where to find the compiler by setting either the environment
+ variable "CXX" or the CMake cache entry CMAKE_CXX_COMPILER to the full path
+ to the compiler, or to the compiler name if it is in the PATH.
+
+Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
+[Upstream status:
+https://github.com/Maratyszcza/FXdiv/pull/3]
+---
+ CMakeLists.txt | 6 +++++-
+ 1 file changed, 5 insertions(+), 1 deletion(-)
+
+diff --git a/CMakeLists.txt b/CMakeLists.txt
+index bcae6b5..c75f558 100644
+--- a/CMakeLists.txt
++++ b/CMakeLists.txt
+@@ -1,7 +1,7 @@
+ CMAKE_MINIMUM_REQUIRED(VERSION 3.5 FATAL_ERROR)
+
+ # ---[ Project
+-PROJECT(FXdiv C CXX)
++PROJECT(FXdiv C)
+
+ # ---[ Options.
+ OPTION(FXDIV_USE_INLINE_ASSEMBLY "Allow use of inline assembly in FXdiv" OFF)
+@@ -16,6 +16,10 @@ ENDIF()
+ # ---[ CMake options
+ INCLUDE(GNUInstallDirs)
+
++IF(FXDIV_BUILD_TESTS OR FXDIV_BUILD_BENCHMARKS)
++ ENABLE_LANGUAGE(CXX)
++ENDIF()
++
+ IF(FXDIV_BUILD_TESTS)
+ ENABLE_TESTING()
+ ENDIF()
+--
+2.34.1
+
--
2.34.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/fxdiv: fix build without C++ toolchain
2023-01-30 4:29 [Buildroot] [PATCH 1/1] package/fxdiv: fix build without C++ toolchain James Hilliard
@ 2023-01-30 7:08 ` Yann E. MORIN
0 siblings, 0 replies; 2+ messages in thread
From: Yann E. MORIN @ 2023-01-30 7:08 UTC (permalink / raw)
To: James Hilliard; +Cc: buildroot
James, All,
On 2023-01-29 21:29 -0700, James Hilliard spake thusly:
> The cmake project for fxdiv sets the project language to C and CXX
> even when only C is required.
>
> Add a patch which disables CXX unless required.
>
> Fixes:
> - http://autobuild.buildroot.net/results/b0f/b0f3b6352429a5156a8c3a2b932331753887b65b
> - http://autobuild.buildroot.net/results/52f/52f634c06bdfe983280a2c01bb9fec4b0e1a4b34
> - http://autobuild.buildroot.net/results/181/181b85d9dd505693ed23fab823085b001aa785f4
>
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> ...le-CXX-unless-building-tests-benchma.patch | 49 +++++++++++++++++++
> 1 file changed, 49 insertions(+)
> create mode 100644 package/fxdiv/0001-CMake-don-t-enable-CXX-unless-building-tests-benchma.patch
>
> diff --git a/package/fxdiv/0001-CMake-don-t-enable-CXX-unless-building-tests-benchma.patch b/package/fxdiv/0001-CMake-don-t-enable-CXX-unless-building-tests-benchma.patch
> new file mode 100644
> index 0000000000..0336f5e1cc
> --- /dev/null
> +++ b/package/fxdiv/0001-CMake-don-t-enable-CXX-unless-building-tests-benchma.patch
> @@ -0,0 +1,49 @@
> +From 8c2d8fc60306a8edd21182a1f5f267a7aca55763 Mon Sep 17 00:00:00 2001
> +From: James Hilliard <james.hilliard1@gmail.com>
> +Date: Sun, 29 Jan 2023 21:18:28 -0700
> +Subject: [PATCH] CMake: don't enable CXX unless building tests/benchmarks
> +
> +We only need CXX support when building tests/benchmarks.
> +
> +Fixes:
> +CMake Error at CMakeLists.txt:4 (PROJECT):
> + No CMAKE_CXX_COMPILER could be found.
> +
> + Tell CMake where to find the compiler by setting either the environment
> + variable "CXX" or the CMake cache entry CMAKE_CXX_COMPILER to the full path
> + to the compiler, or to the compiler name if it is in the PATH.
> +
> +Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> +[Upstream status:
> +https://github.com/Maratyszcza/FXdiv/pull/3]
> +---
> + CMakeLists.txt | 6 +++++-
> + 1 file changed, 5 insertions(+), 1 deletion(-)
> +
> +diff --git a/CMakeLists.txt b/CMakeLists.txt
> +index bcae6b5..c75f558 100644
> +--- a/CMakeLists.txt
> ++++ b/CMakeLists.txt
> +@@ -1,7 +1,7 @@
> + CMAKE_MINIMUM_REQUIRED(VERSION 3.5 FATAL_ERROR)
> +
> + # ---[ Project
> +-PROJECT(FXdiv C CXX)
> ++PROJECT(FXdiv C)
> +
> + # ---[ Options.
> + OPTION(FXDIV_USE_INLINE_ASSEMBLY "Allow use of inline assembly in FXdiv" OFF)
> +@@ -16,6 +16,10 @@ ENDIF()
> + # ---[ CMake options
> + INCLUDE(GNUInstallDirs)
> +
> ++IF(FXDIV_BUILD_TESTS OR FXDIV_BUILD_BENCHMARKS)
> ++ ENABLE_LANGUAGE(CXX)
> ++ENDIF()
> ++
> + IF(FXDIV_BUILD_TESTS)
> + ENABLE_TESTING()
> + ENDIF()
> +--
> +2.34.1
> +
> --
> 2.34.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-30 7:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-30 4:29 [Buildroot] [PATCH 1/1] package/fxdiv: fix build without C++ toolchain James Hilliard
2023-01-30 7:08 ` Yann E. MORIN
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.