From: Jakub Kicinski <kuba@kernel.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Jonas Suhr Christensen <jsc@umbraculum.org>,
netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, michal.simek@xilinx.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, esben@geanix.com
Subject: Re: [PATCH 1/2] net: ll_temac: fix DMA resources leak
Date: Mon, 30 Jan 2023 16:20:41 -0800 [thread overview]
Message-ID: <20230130162041.556b34b3@kernel.org> (raw)
In-Reply-To: <810730f9-5097-4fb1-bea0-13e3e7084f9c@wanadoo.fr>
On Mon, 30 Jan 2023 22:56:04 +0100 Christophe JAILLET wrote:
> > - dma_unmap_single(ndev->dev.parent, lp->rx_bd_v[i].phys,
> > +
> > + bd = &lp->rx_bd_v[1];
>
> Hi,
> just a naive question from s.o. who knows nothing of this code:
>
> Is really [1] ([one]) expected here?
> [i] would look more "standard" in a 'for' loop.
Wow, good eye.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Jonas Suhr Christensen <jsc@umbraculum.org>,
netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, michal.simek@xilinx.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, esben@geanix.com
Subject: Re: [PATCH 1/2] net: ll_temac: fix DMA resources leak
Date: Mon, 30 Jan 2023 16:20:41 -0800 [thread overview]
Message-ID: <20230130162041.556b34b3@kernel.org> (raw)
In-Reply-To: <810730f9-5097-4fb1-bea0-13e3e7084f9c@wanadoo.fr>
On Mon, 30 Jan 2023 22:56:04 +0100 Christophe JAILLET wrote:
> > - dma_unmap_single(ndev->dev.parent, lp->rx_bd_v[i].phys,
> > +
> > + bd = &lp->rx_bd_v[1];
>
> Hi,
> just a naive question from s.o. who knows nothing of this code:
>
> Is really [1] ([one]) expected here?
> [i] would look more "standard" in a 'for' loop.
Wow, good eye.
next prev parent reply other threads:[~2023-01-31 0:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-26 10:16 [PATCH 1/2] net: ll_temac: fix DMA resources leak Jonas Suhr Christensen
2023-01-26 10:16 ` Jonas Suhr Christensen
2023-01-26 10:16 ` [PATCH 2/2] net: ll_temac: improve reset of buffer on dma mapping Jonas Suhr Christensen
2023-01-26 10:16 ` Jonas Suhr Christensen
2023-01-28 7:13 ` Jakub Kicinski
2023-01-28 7:13 ` Jakub Kicinski
2023-01-30 12:40 ` esben
2023-01-30 12:40 ` esben
2023-01-30 20:42 ` Jakub Kicinski
2023-01-30 20:42 ` Jakub Kicinski
2023-01-28 7:20 ` [PATCH 1/2] net: ll_temac: fix DMA resources leak Jakub Kicinski
2023-01-28 7:20 ` Jakub Kicinski
2023-01-30 12:30 ` esben
2023-01-30 12:30 ` esben
2023-01-30 21:56 ` Christophe JAILLET
2023-01-30 21:56 ` Christophe JAILLET
2023-01-31 0:20 ` Jakub Kicinski [this message]
2023-01-31 0:20 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230130162041.556b34b3@kernel.org \
--to=kuba@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=esben@geanix.com \
--cc=jsc@umbraculum.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.