From: "Michael S. Tsirkin" <mst@redhat.com>
To: Laurent Vivier <lvivier@redhat.com>
Cc: "Cindy Lu" <lulu@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
"Eugenio Pérez" <eperezma@redhat.com>,
"Eli Cohen" <elic@nvidia.com>,
"Gautam Dawar" <gautam.dawar@xilinx.com>
Subject: Re: [PATCH v3 1/2] virtio_net: disable VIRTIO_NET_F_STANDBY if VIRTIO_NET_F_MAC is not set
Date: Tue, 31 Jan 2023 17:09:30 -0500 [thread overview]
Message-ID: <20230131170923-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20230127204500.51930-2-lvivier@redhat.com>
On Fri, Jan 27, 2023 at 09:44:59PM +0100, Laurent Vivier wrote:
> failover relies on the MAC address to pair the primary and the standby
> devices:
>
> "[...] the hypervisor needs to enable VIRTIO_NET_F_STANDBY
> feature on the virtio-net interface and assign the same MAC address
> to both virtio-net and VF interfaces."
>
> Documentation/networking/net_failover.rst
>
> This patch disables the STANDBY feature if the MAC address is not
> provided by the hypervisor.
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> drivers/net/virtio_net.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> index 7723b2a49d8e..7d700f8e545a 100644
> --- a/drivers/net/virtio_net.c
> +++ b/drivers/net/virtio_net.c
> @@ -3688,6 +3688,12 @@ static int virtnet_validate(struct virtio_device *vdev)
> __virtio_clear_bit(vdev, VIRTIO_NET_F_MTU);
> }
>
> + if (virtio_has_feature(vdev, VIRTIO_NET_F_STANDBY) &&
> + !virtio_has_feature(vdev, VIRTIO_NET_F_MAC)) {
> + dev_warn(&vdev->dev, "device advertises feature VIRTIO_NET_F_STANDBY but not VIRTIO_NET_F_MAC, disabling standby");
> + __virtio_clear_bit(vdev, VIRTIO_NET_F_STANDBY);
> + }
> +
> return 0;
> }
>
> --
> 2.39.1
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Laurent Vivier <lvivier@redhat.com>
Cc: linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
virtualization@lists.linux-foundation.org,
"Cindy Lu" <lulu@redhat.com>, "Eli Cohen" <elic@nvidia.com>,
"Gautam Dawar" <gautam.dawar@xilinx.com>,
"Eugenio Pérez" <eperezma@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
netdev@vger.kernel.org, "Parav Pandit" <parav@nvidia.com>
Subject: Re: [PATCH v3 1/2] virtio_net: disable VIRTIO_NET_F_STANDBY if VIRTIO_NET_F_MAC is not set
Date: Tue, 31 Jan 2023 17:09:30 -0500 [thread overview]
Message-ID: <20230131170923-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20230127204500.51930-2-lvivier@redhat.com>
On Fri, Jan 27, 2023 at 09:44:59PM +0100, Laurent Vivier wrote:
> failover relies on the MAC address to pair the primary and the standby
> devices:
>
> "[...] the hypervisor needs to enable VIRTIO_NET_F_STANDBY
> feature on the virtio-net interface and assign the same MAC address
> to both virtio-net and VF interfaces."
>
> Documentation/networking/net_failover.rst
>
> This patch disables the STANDBY feature if the MAC address is not
> provided by the hypervisor.
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> drivers/net/virtio_net.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> index 7723b2a49d8e..7d700f8e545a 100644
> --- a/drivers/net/virtio_net.c
> +++ b/drivers/net/virtio_net.c
> @@ -3688,6 +3688,12 @@ static int virtnet_validate(struct virtio_device *vdev)
> __virtio_clear_bit(vdev, VIRTIO_NET_F_MTU);
> }
>
> + if (virtio_has_feature(vdev, VIRTIO_NET_F_STANDBY) &&
> + !virtio_has_feature(vdev, VIRTIO_NET_F_MAC)) {
> + dev_warn(&vdev->dev, "device advertises feature VIRTIO_NET_F_STANDBY but not VIRTIO_NET_F_MAC, disabling standby");
> + __virtio_clear_bit(vdev, VIRTIO_NET_F_STANDBY);
> + }
> +
> return 0;
> }
>
> --
> 2.39.1
next prev parent reply other threads:[~2023-01-31 22:09 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-27 20:44 [PATCH v3 0/2] virtio_net: vdpa: update MAC address when it is generated by virtio-net Laurent Vivier
2023-01-27 20:44 ` Laurent Vivier
2023-01-27 20:44 ` [PATCH v3 1/2] virtio_net: disable VIRTIO_NET_F_STANDBY if VIRTIO_NET_F_MAC is not set Laurent Vivier
2023-01-27 20:44 ` Laurent Vivier
2023-01-31 22:09 ` Michael S. Tsirkin [this message]
2023-01-31 22:09 ` Michael S. Tsirkin
2023-01-27 20:45 ` [PATCH v3 2/2] virtio_net: notify MAC address change on device initialization Laurent Vivier
2023-01-27 20:45 ` Laurent Vivier
2023-01-31 9:01 ` Paolo Abeni
2023-01-31 9:01 ` Paolo Abeni
2023-01-31 9:32 ` Laurent Vivier
2023-01-31 9:32 ` Laurent Vivier
2023-01-31 11:41 ` Paolo Abeni
2023-01-31 11:41 ` Paolo Abeni
2023-01-31 13:43 ` Michael S. Tsirkin
2023-01-31 13:43 ` Michael S. Tsirkin
2023-01-31 14:40 ` Paolo Abeni
2023-01-31 14:40 ` Paolo Abeni
2023-01-31 22:09 ` Michael S. Tsirkin
2023-01-31 22:09 ` Michael S. Tsirkin
2023-02-02 5:00 ` [PATCH v3 0/2] virtio_net: vdpa: update MAC address when it is generated by virtio-net patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230131170923-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=davem@davemloft.net \
--cc=elic@nvidia.com \
--cc=eperezma@redhat.com \
--cc=gautam.dawar@xilinx.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lulu@redhat.com \
--cc=lvivier@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.