From: Diederik de Haas <didi.debian@cknow.org>
To: Carsten Haitzler <carsten.haitzler@arm.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
Diederik de Haas <didi.debian@cknow.org>
Subject: [PATCH 0/2] Script style improvements in lib/coresight.sh
Date: Wed, 1 Feb 2023 22:49:43 +0100 [thread overview]
Message-ID: <20230201214945.127474-1-didi.debian@cknow.org> (raw)
These 2 patches improve the efficiency and quality of the
lib/coresight.sh script.
The first one uses grep's `-c` parameter to count the results instead of
piping it to `wc -l`.
The second one replaces the use of backticks (`...`) with $(...) as the
former has several potential issues while the latter does not.
Diederik de Haas (2):
perf test: Replace 'grep | wc -l' with 'grep -c'
perf test: Replace legacy `...` with $(...)
tools/perf/tests/shell/lib/coresight.sh | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
--
2.39.1
next reply other threads:[~2023-02-01 21:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 21:49 Diederik de Haas [this message]
2023-02-01 21:49 ` [PATCH 1/2] perf test: Replace 'grep | wc -l' with 'grep -c' Diederik de Haas
2023-02-01 21:49 ` [PATCH 2/2] perf test: Replace legacy `...` with $(...) Diederik de Haas
2023-02-02 1:53 ` [PATCH 0/2] Script style improvements in lib/coresight.sh Arnaldo Carvalho de Melo
2023-02-02 8:38 ` Carsten Haitzler
2023-02-02 13:00 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230201214945.127474-1-didi.debian@cknow.org \
--to=didi.debian@cknow.org \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=carsten.haitzler@arm.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.