From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Diederik de Haas <didi.debian@cknow.org>
Cc: Carsten Haitzler <carsten.haitzler@arm.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] Script style improvements in lib/coresight.sh
Date: Wed, 1 Feb 2023 22:53:13 -0300 [thread overview]
Message-ID: <Y9sXiRPNoo03YRyq@kernel.org> (raw)
In-Reply-To: <20230201214945.127474-1-didi.debian@cknow.org>
Em Wed, Feb 01, 2023 at 10:49:43PM +0100, Diederik de Haas escreveu:
> These 2 patches improve the efficiency and quality of the
> lib/coresight.sh script.
>
> The first one uses grep's `-c` parameter to count the results instead of
> piping it to `wc -l`.
> The second one replaces the use of backticks (`...`) with $(...) as the
> former has several potential issues while the latter does not.
>
> Diederik de Haas (2):
> perf test: Replace 'grep | wc -l' with 'grep -c'
> perf test: Replace legacy `...` with $(...)
Thanks, applied.
- Arnaldo
next prev parent reply other threads:[~2023-02-02 1:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 21:49 [PATCH 0/2] Script style improvements in lib/coresight.sh Diederik de Haas
2023-02-01 21:49 ` [PATCH 1/2] perf test: Replace 'grep | wc -l' with 'grep -c' Diederik de Haas
2023-02-01 21:49 ` [PATCH 2/2] perf test: Replace legacy `...` with $(...) Diederik de Haas
2023-02-02 1:53 ` Arnaldo Carvalho de Melo [this message]
2023-02-02 8:38 ` [PATCH 0/2] Script style improvements in lib/coresight.sh Carsten Haitzler
2023-02-02 13:00 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9sXiRPNoo03YRyq@kernel.org \
--to=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=carsten.haitzler@arm.com \
--cc=didi.debian@cknow.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.