All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Parav Pandit <parav@nvidia.com>
Cc: jasowang@redhat.com, davem@davemloft.net, kuba@kernel.org,
	netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
	ast@kernel.org, daniel@iogearbox.net, hawk@kernel.org,
	virtualization@lists.linux-foundation.org, bpf@vger.kernel.org
Subject: Re: [PATCH 0/2] virtio-net: close() to follow mirror of open()
Date: Thu, 2 Feb 2023 05:56:57 -0500	[thread overview]
Message-ID: <20230202055630-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20230202050038.3187-1-parav@nvidia.com>

On Thu, Feb 02, 2023 at 07:00:36AM +0200, Parav Pandit wrote:
> Hi,
> 
> This two small patches improves ndo_close() callback to follow
> the mirror sequence of ndo_open() callback. This improves the code auditing
> and also ensure that xdp rxq info is not unregistered while NAPI on
> RXQ is ongoing.


Acked-by: Michael S. Tsirkin <mst@redhat.com>

I'm guessing -net and 1/2 for stable?

> Please review.
> 
> Patch summary:
> patch-1 ensures that xdp rq info is unregistered after rq napi is disabled
> patch-2 keeps the mirror sequence for close() be mirror of open()
> 
> Parav Pandit (2):
>   virtio-net: Keep stop() to follow mirror sequence of open()
>   virtio-net: Maintain reverse cleanup order
> 
>  drivers/net/virtio_net.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> -- 
> 2.26.2


WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Parav Pandit <parav@nvidia.com>
Cc: hawk@kernel.org, daniel@iogearbox.net, netdev@vger.kernel.org,
	ast@kernel.org, virtualization@lists.linux-foundation.org,
	edumazet@google.com, kuba@kernel.org, bpf@vger.kernel.org,
	pabeni@redhat.com, davem@davemloft.net
Subject: Re: [PATCH 0/2] virtio-net: close() to follow mirror of open()
Date: Thu, 2 Feb 2023 05:56:57 -0500	[thread overview]
Message-ID: <20230202055630-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20230202050038.3187-1-parav@nvidia.com>

On Thu, Feb 02, 2023 at 07:00:36AM +0200, Parav Pandit wrote:
> Hi,
> 
> This two small patches improves ndo_close() callback to follow
> the mirror sequence of ndo_open() callback. This improves the code auditing
> and also ensure that xdp rxq info is not unregistered while NAPI on
> RXQ is ongoing.


Acked-by: Michael S. Tsirkin <mst@redhat.com>

I'm guessing -net and 1/2 for stable?

> Please review.
> 
> Patch summary:
> patch-1 ensures that xdp rq info is unregistered after rq napi is disabled
> patch-2 keeps the mirror sequence for close() be mirror of open()
> 
> Parav Pandit (2):
>   virtio-net: Keep stop() to follow mirror sequence of open()
>   virtio-net: Maintain reverse cleanup order
> 
>  drivers/net/virtio_net.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> -- 
> 2.26.2

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

  parent reply	other threads:[~2023-02-02 10:57 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-02  5:00 [PATCH 0/2] virtio-net: close() to follow mirror of open() Parav Pandit
2023-02-02  5:00 ` Parav Pandit via Virtualization
2023-02-02  5:00 ` [PATCH 1/2] virtio-net: Keep stop() to follow mirror sequence " Parav Pandit
2023-02-02  5:00   ` Parav Pandit via Virtualization
2023-02-02 12:23   ` Jiri Pirko
2023-02-02 12:23     ` Jiri Pirko
2023-02-02  5:00 ` [PATCH 2/2] virtio-net: Maintain reverse cleanup order Parav Pandit
2023-02-02  5:00   ` Parav Pandit
2023-02-02 12:26   ` Jiri Pirko
2023-02-02 12:26     ` Jiri Pirko
2023-02-02 15:10     ` Parav Pandit
2023-02-02 15:10       ` Parav Pandit via Virtualization
2023-02-02 15:46       ` Jiri Pirko
2023-02-02 15:46         ` Jiri Pirko
2023-02-02 16:33         ` Parav Pandit
2023-02-02 16:33           ` Parav Pandit via Virtualization
2023-02-02 10:56 ` Michael S. Tsirkin [this message]
2023-02-02 10:56   ` [PATCH 0/2] virtio-net: close() to follow mirror of open() Michael S. Tsirkin
2023-02-02 18:40 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230202055630-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hawk@kernel.org \
    --cc=jasowang@redhat.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=parav@nvidia.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.