All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Shunsuke Mie <mie@igel.co.jp>
Cc: "Lorenzo Pieralisi" <lpieralisi@kernel.org>,
	"Krzysztof Wilczyński" <kw@linux.com>,
	"Manivannan Sadhasivam" <mani@kernel.org>,
	"Kishon Vijay Abraham I" <kishon@kernel.org>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Jason Wang" <jasowang@redhat.com>, "Frank Li" <Frank.Li@nxp.com>,
	"Jon Mason" <jdmason@kudzu.us>,
	"Ren Zhijie" <renzhijie2@huawei.com>,
	"Takanari Hayama" <taki@igel.co.jp>,
	linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
	virtualization@lists.linux-foundation.org
Subject: Re: [RFC PATCH 1/4] virtio_pci: add a definition of queue flag in ISR
Date: Fri, 3 Feb 2023 05:16:45 -0500	[thread overview]
Message-ID: <20230203051445-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20230203100418.2981144-2-mie@igel.co.jp>

On Fri, Feb 03, 2023 at 07:04:15PM +0900, Shunsuke Mie wrote:
> Already it has beed defined a config changed flag of ISR, but not the queue
> flag. Add a macro for it.
> 
> Signed-off-by: Shunsuke Mie <mie@igel.co.jp>
> Signed-off-by: Takanari Hayama <taki@igel.co.jp>
> ---
>  include/uapi/linux/virtio_pci.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/include/uapi/linux/virtio_pci.h b/include/uapi/linux/virtio_pci.h
> index f703afc7ad31..fa82afd6171a 100644
> --- a/include/uapi/linux/virtio_pci.h
> +++ b/include/uapi/linux/virtio_pci.h
> @@ -94,6 +94,8 @@
>  
>  #endif /* VIRTIO_PCI_NO_LEGACY */
>  
> +/* Ths bit of the ISR which indicates a queue entry update */

typo

Something to add here:
	Note: only when MSI-X is disabled



> +#define VIRTIO_PCI_ISR_QUEUE		0x1
>  /* The bit of the ISR which indicates a device configuration change. */
>  #define VIRTIO_PCI_ISR_CONFIG		0x2
>  /* Vector value used to disable MSI for queue */
> -- 
> 2.25.1


WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Shunsuke Mie <mie@igel.co.jp>
Cc: "Kishon Vijay Abraham I" <kishon@kernel.org>,
	"Krzysztof Wilczyński" <kw@linux.com>,
	"Takanari Hayama" <taki@igel.co.jp>,
	"Manivannan Sadhasivam" <mani@kernel.org>,
	linux-pci@vger.kernel.org,
	"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
	"Frank Li" <Frank.Li@nxp.com>,
	linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	"Ren Zhijie" <renzhijie2@huawei.com>,
	"Jon Mason" <jdmason@kudzu.us>,
	"Bjorn Helgaas" <bhelgaas@google.com>
Subject: Re: [RFC PATCH 1/4] virtio_pci: add a definition of queue flag in ISR
Date: Fri, 3 Feb 2023 05:16:45 -0500	[thread overview]
Message-ID: <20230203051445-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20230203100418.2981144-2-mie@igel.co.jp>

On Fri, Feb 03, 2023 at 07:04:15PM +0900, Shunsuke Mie wrote:
> Already it has beed defined a config changed flag of ISR, but not the queue
> flag. Add a macro for it.
> 
> Signed-off-by: Shunsuke Mie <mie@igel.co.jp>
> Signed-off-by: Takanari Hayama <taki@igel.co.jp>
> ---
>  include/uapi/linux/virtio_pci.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/include/uapi/linux/virtio_pci.h b/include/uapi/linux/virtio_pci.h
> index f703afc7ad31..fa82afd6171a 100644
> --- a/include/uapi/linux/virtio_pci.h
> +++ b/include/uapi/linux/virtio_pci.h
> @@ -94,6 +94,8 @@
>  
>  #endif /* VIRTIO_PCI_NO_LEGACY */
>  
> +/* Ths bit of the ISR which indicates a queue entry update */

typo

Something to add here:
	Note: only when MSI-X is disabled



> +#define VIRTIO_PCI_ISR_QUEUE		0x1
>  /* The bit of the ISR which indicates a device configuration change. */
>  #define VIRTIO_PCI_ISR_CONFIG		0x2
>  /* Vector value used to disable MSI for queue */
> -- 
> 2.25.1

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

  reply	other threads:[~2023-02-03 10:18 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-03 10:04 [RFC PATCH 0/4] PCI: endpoint: Introduce a virtio-net EP function Shunsuke Mie
2023-02-03 10:04 ` Shunsuke Mie
2023-02-03 10:04 ` [RFC PATCH 1/4] virtio_pci: add a definition of queue flag in ISR Shunsuke Mie
2023-02-03 10:04   ` Shunsuke Mie
2023-02-03 10:16   ` Michael S. Tsirkin [this message]
2023-02-03 10:16     ` Michael S. Tsirkin
2023-02-07 10:06     ` Shunsuke Mie
2023-02-07 10:06       ` Shunsuke Mie
2023-02-03 10:04 ` [RFC PATCH 2/4] virtio_ring: remove const from vring getter Shunsuke Mie
2023-02-03 10:04   ` Shunsuke Mie
2023-02-03 10:04 ` [RFC PATCH 3/4] PCI: endpoint: Introduce virtio library for EP functions Shunsuke Mie
2023-02-03 10:04   ` Shunsuke Mie
2023-02-03 10:20   ` Michael S. Tsirkin
2023-02-03 10:20     ` Michael S. Tsirkin
2023-02-07 11:05     ` Shunsuke Mie
2023-02-07 11:05       ` Shunsuke Mie
2023-02-03 10:04 ` [RFC PATCH 4/4] PCI: endpoint: function: Add EP function driver to provide virtio net device Shunsuke Mie
2023-02-03 10:04   ` Shunsuke Mie
2023-02-03 10:22   ` Michael S. Tsirkin
2023-02-03 10:22     ` Michael S. Tsirkin
2023-02-03 22:15     ` [EXT] " Frank Li
2023-02-07 10:56       ` Shunsuke Mie
2023-02-07 10:56         ` Shunsuke Mie
2023-02-07 15:37         ` Frank Li
2023-02-08  5:46           ` Shunsuke Mie
2023-02-08  5:46             ` Shunsuke Mie
2023-02-07 10:47     ` Shunsuke Mie
2023-02-07 10:47       ` Shunsuke Mie
2023-02-03 11:58   ` kernel test robot
2023-02-04  1:05   ` kernel test robot
2023-02-03 16:45 ` [EXT] [RFC PATCH 0/4] PCI: endpoint: Introduce a virtio-net EP function Frank Li
2023-02-07 10:29   ` Shunsuke Mie
2023-02-07 10:29     ` Shunsuke Mie
2023-02-07 16:02     ` Frank Li
2023-02-14  3:27       ` Shunsuke Mie
2023-02-14  3:27         ` Shunsuke Mie
2023-03-29 16:46         ` Frank Li
2023-04-05  1:22           ` Shunsuke Mie
2023-04-05  1:22             ` Shunsuke Mie
2023-04-11 10:22           ` Shunsuke Mie
2023-04-11 10:22             ` Shunsuke Mie
2023-02-03 21:48 ` Frank Li
2023-02-07  1:43   ` Shunsuke Mie
2023-02-07  1:43     ` Shunsuke Mie
2023-02-07  3:27     ` Shunsuke Mie
2023-02-07  3:27       ` Shunsuke Mie
2023-02-05 10:01 ` Michael S. Tsirkin
2023-02-05 10:01   ` Michael S. Tsirkin
2023-02-07 10:17   ` Shunsuke Mie
2023-02-07 10:17     ` Shunsuke Mie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230203051445-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=Frank.Li@nxp.com \
    --cc=bhelgaas@google.com \
    --cc=jasowang@redhat.com \
    --cc=jdmason@kudzu.us \
    --cc=kishon@kernel.org \
    --cc=kw@linux.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=mani@kernel.org \
    --cc=mie@igel.co.jp \
    --cc=renzhijie2@huawei.com \
    --cc=taki@igel.co.jp \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.