All of lore.kernel.org
 help / color / mirror / Atom feed
* [merged mm-nonmm-stable] fs-ext4-use-try_cmpxchg-in-ext4_update_bh_state.patch removed from -mm tree
@ 2023-02-03  6:51 Andrew Morton
  0 siblings, 0 replies; only message in thread
From: Andrew Morton @ 2023-02-03  6:51 UTC (permalink / raw)
  To: mm-commits, tytso, adilger.kernel, ubizjak, akpm


The quilt patch titled
     Subject: fs/ext4: use try_cmpxchg in ext4_update_bh_state
has been removed from the -mm tree.  Its filename was
     fs-ext4-use-try_cmpxchg-in-ext4_update_bh_state.patch

This patch was dropped because it was merged into the mm-nonmm-stable branch
of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

------------------------------------------------------
From: Uros Bizjak <ubizjak@gmail.com>
Subject: fs/ext4: use try_cmpxchg in ext4_update_bh_state
Date: Wed, 2 Nov 2022 08:11:47 +0100

Use try_cmpxchg instead of cmpxchg (*ptr, old, new) == old in
ext4_update_bh_state.  x86 CMPXCHG instruction returns success in ZF flag,
so this change saves a compare after cmpxchg (and related move instruction
in front of cmpxchg).

Also, try_cmpxchg implicitly assigns old *ptr value to "old" when cmpxchg
fails.  There is no need to re-read the value in the loop.

No functional change intended.

Link: https://lkml.kernel.org/r/20221102071147.6642-1-ubizjak@gmail.com
Signed-off-by: Uros Bizjak <ubizjak@gmail.com>
Cc: "Theodore Ts'o" <tytso@mit.edu>
Cc: Andreas Dilger <adilger.kernel@dilger.ca>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---


--- a/fs/ext4/inode.c~fs-ext4-use-try_cmpxchg-in-ext4_update_bh_state
+++ a/fs/ext4/inode.c
@@ -786,11 +786,10 @@ static void ext4_update_bh_state(struct
 	 * once we get rid of using bh as a container for mapping information
 	 * to pass to / from get_block functions, this can go away.
 	 */
+	old_state = READ_ONCE(bh->b_state);
 	do {
-		old_state = READ_ONCE(bh->b_state);
 		new_state = (old_state & ~EXT4_MAP_FLAGS) | flags;
-	} while (unlikely(
-		 cmpxchg(&bh->b_state, old_state, new_state) != old_state));
+	} while (unlikely(!try_cmpxchg(&bh->b_state, &old_state, new_state)));
 }
 
 static int _ext4_get_block(struct inode *inode, sector_t iblock,
_

Patches currently in -mm which might be from ubizjak@gmail.com are



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-02-03  6:52 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-03  6:51 [merged mm-nonmm-stable] fs-ext4-use-try_cmpxchg-in-ext4_update_bh_state.patch removed from -mm tree Andrew Morton

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.