All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: kvm-riscv@lists.infradead.org
Subject: [PATCH 1/7] KVM: Standardize on "int" return types instead of "long" in kvm_main.c
Date: Fri,  3 Feb 2023 10:42:24 +0100	[thread overview]
Message-ID: <20230203094230.266952-2-thuth@redhat.com> (raw)
In-Reply-To: <20230203094230.266952-1-thuth@redhat.com>

KVM functions use "long" return values for functions that are wired up
to "struct file_operations", but otherwise use "int" return values for
functions that can return 0/-errno in order to avoid unintentional
divergences between 32-bit and 64-bit kernels.
Some code still uses "long" in unnecessary spots, though, which can
cause a little bit of confusion and unnecessary size casts. Let's
change these spots to use "int" types, too.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 virt/kvm/kvm_main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
index 9c60384b5ae0..cd46467252a9 100644
--- a/virt/kvm/kvm_main.c
+++ b/virt/kvm/kvm_main.c
@@ -4475,7 +4475,7 @@ static int kvm_ioctl_create_device(struct kvm *kvm,
 	return 0;
 }
 
-static long kvm_vm_ioctl_check_extension_generic(struct kvm *kvm, long arg)
+static int kvm_vm_ioctl_check_extension_generic(struct kvm *kvm, long arg)
 {
 	switch (arg) {
 	case KVM_CAP_USER_MEMORY:
@@ -5053,7 +5053,7 @@ static int kvm_dev_ioctl_create_vm(unsigned long type)
 static long kvm_dev_ioctl(struct file *filp,
 			  unsigned int ioctl, unsigned long arg)
 {
-	long r = -EINVAL;
+	int r = -EINVAL;
 
 	switch (ioctl) {
 	case KVM_GET_API_VERSION:
-- 
2.31.1



WARNING: multiple messages have this Message-ID (diff)
From: Thomas Huth <thuth@redhat.com>
To: kvm@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>,
	Sean Christopherson <seanjc@google.com>
Cc: kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org,
	kvm-riscv@lists.infradead.org, Marc Zyngier <maz@kernel.org>,
	James Morse <james.morse@arm.com>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Oliver Upton <oliver.upton@linux.dev>,
	Zenghui Yu <yuzenghui@huawei.com>,
	Christian Borntraeger <borntraeger@linux.ibm.com>,
	Janosch Frank <frankja@linux.ibm.com>,
	Claudio Imbrenda <imbrenda@linux.ibm.com>,
	David Hildenbrand <david@redhat.com>,
	linuxppc-dev@lists.ozlabs.org
Subject: [PATCH 1/7] KVM: Standardize on "int" return types instead of "long" in kvm_main.c
Date: Fri,  3 Feb 2023 10:42:24 +0100	[thread overview]
Message-ID: <20230203094230.266952-2-thuth@redhat.com> (raw)
In-Reply-To: <20230203094230.266952-1-thuth@redhat.com>

KVM functions use "long" return values for functions that are wired up
to "struct file_operations", but otherwise use "int" return values for
functions that can return 0/-errno in order to avoid unintentional
divergences between 32-bit and 64-bit kernels.
Some code still uses "long" in unnecessary spots, though, which can
cause a little bit of confusion and unnecessary size casts. Let's
change these spots to use "int" types, too.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 virt/kvm/kvm_main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
index 9c60384b5ae0..cd46467252a9 100644
--- a/virt/kvm/kvm_main.c
+++ b/virt/kvm/kvm_main.c
@@ -4475,7 +4475,7 @@ static int kvm_ioctl_create_device(struct kvm *kvm,
 	return 0;
 }
 
-static long kvm_vm_ioctl_check_extension_generic(struct kvm *kvm, long arg)
+static int kvm_vm_ioctl_check_extension_generic(struct kvm *kvm, long arg)
 {
 	switch (arg) {
 	case KVM_CAP_USER_MEMORY:
@@ -5053,7 +5053,7 @@ static int kvm_dev_ioctl_create_vm(unsigned long type)
 static long kvm_dev_ioctl(struct file *filp,
 			  unsigned int ioctl, unsigned long arg)
 {
-	long r = -EINVAL;
+	int r = -EINVAL;
 
 	switch (ioctl) {
 	case KVM_GET_API_VERSION:
-- 
2.31.1


WARNING: multiple messages have this Message-ID (diff)
From: Thomas Huth <thuth@redhat.com>
To: kvm@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>,
	Sean Christopherson <seanjc@google.com>
Cc: Claudio Imbrenda <imbrenda@linux.ibm.com>,
	Janosch Frank <frankja@linux.ibm.com>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Marc Zyngier <maz@kernel.org>,
	David Hildenbrand <david@redhat.com>,
	linux-kernel@vger.kernel.org,
	Oliver Upton <oliver.upton@linux.dev>,
	Zenghui Yu <yuzenghui@huawei.com>,
	James Morse <james.morse@arm.com>,
	kvm-riscv@lists.infradead.org, kvmarm@lists.linux.dev,
	Christian Borntraeger <borntraeger@linux.ibm.com>,
	linuxppc-dev@lists.ozlabs.org
Subject: [PATCH 1/7] KVM: Standardize on "int" return types instead of "long" in kvm_main.c
Date: Fri,  3 Feb 2023 10:42:24 +0100	[thread overview]
Message-ID: <20230203094230.266952-2-thuth@redhat.com> (raw)
In-Reply-To: <20230203094230.266952-1-thuth@redhat.com>

KVM functions use "long" return values for functions that are wired up
to "struct file_operations", but otherwise use "int" return values for
functions that can return 0/-errno in order to avoid unintentional
divergences between 32-bit and 64-bit kernels.
Some code still uses "long" in unnecessary spots, though, which can
cause a little bit of confusion and unnecessary size casts. Let's
change these spots to use "int" types, too.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 virt/kvm/kvm_main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
index 9c60384b5ae0..cd46467252a9 100644
--- a/virt/kvm/kvm_main.c
+++ b/virt/kvm/kvm_main.c
@@ -4475,7 +4475,7 @@ static int kvm_ioctl_create_device(struct kvm *kvm,
 	return 0;
 }
 
-static long kvm_vm_ioctl_check_extension_generic(struct kvm *kvm, long arg)
+static int kvm_vm_ioctl_check_extension_generic(struct kvm *kvm, long arg)
 {
 	switch (arg) {
 	case KVM_CAP_USER_MEMORY:
@@ -5053,7 +5053,7 @@ static int kvm_dev_ioctl_create_vm(unsigned long type)
 static long kvm_dev_ioctl(struct file *filp,
 			  unsigned int ioctl, unsigned long arg)
 {
-	long r = -EINVAL;
+	int r = -EINVAL;
 
 	switch (ioctl) {
 	case KVM_GET_API_VERSION:
-- 
2.31.1


  reply	other threads:[~2023-02-03  9:42 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-03  9:42 [PATCH 0/7] KVM: Standardize on "int" return types instead of "long" Thomas Huth
2023-02-03  9:42 ` Thomas Huth
2023-02-03  9:42 ` Thomas Huth
2023-02-03  9:42 ` Thomas Huth [this message]
2023-02-03  9:42   ` [PATCH 1/7] KVM: Standardize on "int" return types instead of "long" in kvm_main.c Thomas Huth
2023-02-03  9:42   ` Thomas Huth
2023-02-03  9:42 ` [PATCH 2/7] KVM: x86: Improve return type handling in kvm_vm_ioctl_get_nr_mmu_pages() Thomas Huth
2023-02-03  9:42   ` Thomas Huth
2023-02-03  9:42   ` Thomas Huth
2023-02-03 17:48   ` Sean Christopherson
2023-02-03 17:48     ` Sean Christopherson
2023-02-03 17:48     ` Sean Christopherson
2023-02-07  9:26     ` Thomas Huth
2023-02-07  9:26       ` Thomas Huth
2023-02-07  9:26       ` Thomas Huth
2023-02-07 16:25       ` Sean Christopherson
2023-02-07 16:25         ` Sean Christopherson
2023-02-07 16:25         ` Sean Christopherson
2023-02-03  9:42 ` [PATCH 3/7] KVM: Move KVM_GET_NR_MMU_PAGES into the deprecation section Thomas Huth
2023-02-03  9:42   ` Thomas Huth
2023-02-03  9:42   ` Thomas Huth
2023-02-03 10:16   ` Nicholas Piggin
2023-02-03 10:16     ` Nicholas Piggin
2023-02-03 10:16     ` Nicholas Piggin
2023-02-03 10:54     ` Thomas Huth
2023-02-03 10:54       ` Thomas Huth
2023-02-03 10:54       ` Thomas Huth
2023-02-03  9:42 ` [PATCH 4/7] KVM: PPC: Standardize on "int" return types in the powerpc KVM code Thomas Huth
2023-02-03  9:42   ` Thomas Huth
2023-02-03  9:42   ` Thomas Huth
2023-02-03 10:21   ` Nicholas Piggin
2023-02-03 10:21     ` Nicholas Piggin
2023-02-03 10:21     ` Nicholas Piggin
2023-02-03  9:42 ` [PATCH 5/7] KVM: s390: Use "int" as return type for kvm_s390_get/set_skeys() Thomas Huth
2023-02-03  9:42   ` Thomas Huth
2023-02-03  9:42   ` Thomas Huth
2023-02-07 15:36   ` Claudio Imbrenda
2023-02-07 15:36     ` Claudio Imbrenda
2023-02-07 15:36     ` Claudio Imbrenda
2023-02-03  9:42 ` [PATCH 6/7] KVM: arm64: Change return type of kvm_vm_ioctl_mte_copy_tags() to "int" Thomas Huth
2023-02-03  9:42   ` Thomas Huth
2023-02-03  9:42   ` Thomas Huth
2023-02-07  0:09   ` Gavin Shan
2023-02-07  0:09     ` Gavin Shan
2023-02-07  0:09     ` Gavin Shan
2023-02-07 10:09     ` Thomas Huth
2023-02-07 10:09       ` Thomas Huth
2023-02-07 10:09       ` Thomas Huth
2023-02-07 22:16       ` Gavin Shan
2023-02-07 22:16         ` Gavin Shan
2023-02-07 22:16         ` Gavin Shan
2023-02-08  8:49         ` Cornelia Huck
2023-02-08  8:49           ` Cornelia Huck
2023-02-08  8:49           ` Cornelia Huck
2023-02-08 11:51           ` Steven Price
2023-02-08 11:51             ` Steven Price
2023-02-08 11:51             ` Steven Price
2023-02-08 12:16             ` Thomas Huth
2023-02-08 12:16               ` Thomas Huth
2023-02-08 12:16               ` Thomas Huth
2023-02-03  9:42 ` [PATCH 7/7] KVM: Change return type of kvm_arch_vm_ioctl() " Thomas Huth
2023-02-03  9:42   ` Thomas Huth
2023-02-03  9:42   ` Thomas Huth
2023-02-08 17:35   ` Claudio Imbrenda
2023-02-08 17:35     ` Claudio Imbrenda
2023-02-08 17:35     ` Claudio Imbrenda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230203094230.266952-2-thuth@redhat.com \
    --to=thuth@redhat.com \
    --cc=kvm-riscv@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.