From: Jakub Kicinski <kuba@kernel.org>
To: Dawei Li <set_pte_at@outlook.com>
Cc: alsa-devel@alsa-project.org, linux-scsi@vger.kernel.org,
mpe@ellerman.id.au, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org, christophe.leroy@csgroup.eu,
linux-ide@vger.kernel.org, npiggin@gmail.com,
linux-serial@vger.kernel.org, netdev@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v3] powerpc: macio: Make remove callback of macio driver void returned
Date: Fri, 3 Feb 2023 10:27:04 -0800 [thread overview]
Message-ID: <20230203102704.66f6b59a@kernel.org> (raw)
In-Reply-To: <TYCP286MB232391520CB471E7C8D6EA84CAD19@TYCP286MB2323.JPNP286.PROD.OUTLOOK.COM>
On Wed, 1 Feb 2023 22:36:19 +0800 Dawei Li wrote:
> Commit fc7a6209d571 ("bus: Make remove callback return void") forces
> bus_type::remove be void-returned, it doesn't make much sense for any
> bus based driver implementing remove callbalk to return non-void to
> its caller.
>
> This change is for macio bus based drivers.
>
> Signed-off-by: Dawei Li <set_pte_at@outlook.com>
Acked-by: Jakub Kicinski <kuba@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Dawei Li <set_pte_at@outlook.com>
Cc: mpe@ellerman.id.au, npiggin@gmail.com,
christophe.leroy@csgroup.eu, linuxppc-dev@lists.ozlabs.org,
linux-ide@vger.kernel.org, netdev@vger.kernel.org,
linux-wireless@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-serial@vger.kernel.org, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] powerpc: macio: Make remove callback of macio driver void returned
Date: Fri, 3 Feb 2023 10:27:04 -0800 [thread overview]
Message-ID: <20230203102704.66f6b59a@kernel.org> (raw)
In-Reply-To: <TYCP286MB232391520CB471E7C8D6EA84CAD19@TYCP286MB2323.JPNP286.PROD.OUTLOOK.COM>
On Wed, 1 Feb 2023 22:36:19 +0800 Dawei Li wrote:
> Commit fc7a6209d571 ("bus: Make remove callback return void") forces
> bus_type::remove be void-returned, it doesn't make much sense for any
> bus based driver implementing remove callbalk to return non-void to
> its caller.
>
> This change is for macio bus based drivers.
>
> Signed-off-by: Dawei Li <set_pte_at@outlook.com>
Acked-by: Jakub Kicinski <kuba@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Dawei Li <set_pte_at@outlook.com>
Cc: alsa-devel@alsa-project.org, linux-scsi@vger.kernel.org,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-ide@vger.kernel.org, npiggin@gmail.com,
linux-serial@vger.kernel.org, netdev@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v3] powerpc: macio: Make remove callback of macio driver void returned
Date: Fri, 3 Feb 2023 10:27:04 -0800 [thread overview]
Message-ID: <20230203102704.66f6b59a@kernel.org> (raw)
In-Reply-To: <TYCP286MB232391520CB471E7C8D6EA84CAD19@TYCP286MB2323.JPNP286.PROD.OUTLOOK.COM>
On Wed, 1 Feb 2023 22:36:19 +0800 Dawei Li wrote:
> Commit fc7a6209d571 ("bus: Make remove callback return void") forces
> bus_type::remove be void-returned, it doesn't make much sense for any
> bus based driver implementing remove callbalk to return non-void to
> its caller.
>
> This change is for macio bus based drivers.
>
> Signed-off-by: Dawei Li <set_pte_at@outlook.com>
Acked-by: Jakub Kicinski <kuba@kernel.org>
next prev parent reply other threads:[~2023-02-03 18:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 14:36 [PATCH v3] powerpc: macio: Make remove callback of macio driver void returned Dawei Li
2023-02-01 14:36 ` Dawei Li
2023-02-01 14:36 ` Dawei Li
2023-02-01 21:06 ` Damien Le Moal
2023-02-01 21:06 ` Damien Le Moal
2023-02-01 21:06 ` Damien Le Moal
2023-02-03 18:27 ` Jakub Kicinski [this message]
2023-02-03 18:27 ` Jakub Kicinski
2023-02-03 18:27 ` Jakub Kicinski
2024-02-20 16:12 ` Christophe Leroy
2024-02-20 16:12 ` Christophe Leroy
2024-03-06 12:40 ` Dawei Li
2024-03-06 12:40 ` Dawei Li
2024-03-07 12:32 ` Michael Ellerman
2024-03-07 12:32 ` Michael Ellerman
2024-03-13 13:19 ` Michael Ellerman
2024-03-13 13:19 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230203102704.66f6b59a@kernel.org \
--to=kuba@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=christophe.leroy@csgroup.eu \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=netdev@vger.kernel.org \
--cc=npiggin@gmail.com \
--cc=set_pte_at@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.