From: Christoph Hellwig <hch@lst.de>
To: op-tee@lists.trustedfirmware.org
Subject: Re: [PATCH v2 1/4] highmem: Enhance is_kmap_addr() to check kmap_local_page() mappings
Date: Sat, 04 Feb 2023 06:50:07 +0000 [thread overview]
Message-ID: <20230204065001.GA18482@lst.de> (raw)
In-Reply-To: <20230203-get_kernel_pages-v2-1-f1dc4af273f1@intel.com>
[-- Attachment #1: Type: text/plain, Size: 326 bytes --]
On Fri, Feb 03, 2023 at 08:06:32PM -0800, Ira Weiny wrote:
> - return addr >= PKMAP_ADDR(0) && addr < PKMAP_ADDR(LAST_PKMAP);
> +
> + return (addr >= PKMAP_ADDR(0) && addr < PKMAP_ADDR(LAST_PKMAP)) ||
> + (addr >= __fix_to_virt(FIX_KMAP_END) &&
> + addr < __fix_to_virt(FIX_KMAP_BEGIN));
Isn't the second check inverted?
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Ira Weiny <ira.weiny@intel.com>
Cc: Sumit Garg <sumit.garg@linaro.org>,
Andrew Morton <akpm@linux-foundation.org>,
Al Viro <viro@zeniv.linux.org.uk>, Christoph Hellwig <hch@lst.de>,
linux-kernel@vger.kernel.org, op-tee@lists.trustedfirmware.org,
linux-mm@kvack.org, Jens Wiklander <jens.wiklander@linaro.org>,
"Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
John Hubbard <jhubbard@nvidia.com>,
Matthew Wilcox <willy@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v2 1/4] highmem: Enhance is_kmap_addr() to check kmap_local_page() mappings
Date: Sat, 4 Feb 2023 07:50:01 +0100 [thread overview]
Message-ID: <20230204065001.GA18482@lst.de> (raw)
In-Reply-To: <20230203-get_kernel_pages-v2-1-f1dc4af273f1@intel.com>
On Fri, Feb 03, 2023 at 08:06:32PM -0800, Ira Weiny wrote:
> - return addr >= PKMAP_ADDR(0) && addr < PKMAP_ADDR(LAST_PKMAP);
> +
> + return (addr >= PKMAP_ADDR(0) && addr < PKMAP_ADDR(LAST_PKMAP)) ||
> + (addr >= __fix_to_virt(FIX_KMAP_END) &&
> + addr < __fix_to_virt(FIX_KMAP_BEGIN));
Isn't the second check inverted?
next prev parent reply other threads:[~2023-02-04 6:50 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-04 4:06 [PATCH v2 0/4] Remove get_kernel_pages() Ira Weiny
2023-02-04 4:06 ` Ira Weiny
2023-02-04 4:06 ` [PATCH v2 1/4] highmem: Enhance is_kmap_addr() to check kmap_local_page() mappings Ira Weiny
2023-02-04 4:06 ` Ira Weiny
2023-02-04 6:50 ` Christoph Hellwig [this message]
2023-02-04 6:50 ` Christoph Hellwig
2023-02-04 18:37 ` Ira Weiny
2023-02-04 18:37 ` Ira Weiny
2023-02-10 21:59 ` Andrew Morton
2023-02-10 21:59 ` Andrew Morton
2023-02-13 15:53 ` Jens Wiklander
2023-02-13 15:53 ` Jens Wiklander
2023-02-04 4:06 ` [PATCH v2 2/4] tee: Remove vmalloc page support Ira Weiny
2023-02-04 4:06 ` Ira Weiny
2023-02-04 6:51 ` Christoph Hellwig
2023-02-04 6:51 ` Christoph Hellwig
2023-02-06 6:16 ` Sumit Garg
2023-02-06 6:16 ` Sumit Garg
2023-02-13 15:54 ` Jens Wiklander
2023-02-13 15:54 ` Jens Wiklander
2023-02-04 4:06 ` [PATCH v2 3/4] tee: Remove call to get_kernel_pages() Ira Weiny
2023-02-04 4:06 ` Ira Weiny
2023-02-04 6:51 ` Christoph Hellwig
2023-02-04 6:51 ` Christoph Hellwig
2023-02-06 6:17 ` Sumit Garg
2023-02-06 6:17 ` Sumit Garg
2023-02-13 15:55 ` Jens Wiklander
2023-02-13 15:55 ` Jens Wiklander
2023-02-04 4:06 ` [PATCH v2 4/4] mm: Remove get_kernel_pages() Ira Weiny
2023-02-04 4:06 ` Ira Weiny
2023-02-04 6:51 ` Christoph Hellwig
2023-02-04 6:51 ` Christoph Hellwig
2023-02-06 6:17 ` Sumit Garg
2023-02-06 6:17 ` Sumit Garg
2023-02-10 21:59 ` Andrew Morton
2023-02-10 21:59 ` Andrew Morton
2023-02-13 15:55 ` Jens Wiklander
2023-02-13 15:55 ` Jens Wiklander
2023-02-04 19:50 ` [PATCH v2 0/4] " Linus Torvalds
2023-02-04 19:51 ` Linus Torvalds
2023-02-06 6:22 ` Sumit Garg
2023-02-06 6:22 ` Sumit Garg
[not found] < <CAFA6WYM5tzs3T1tDgspA=R=VxfWrknm2YPHMCZihx405pF-ftA@mail.gmail.com>
2023-02-07 16:19 ` Ira Weiny
2023-02-07 16:19 ` Ira Weiny
2023-02-10 20:27 ` Ira Weiny
2023-02-10 20:27 ` Ira Weiny
2023-02-13 15:02 ` Jens Wiklander
2023-02-13 15:02 ` Jens Wiklander
2023-02-13 19:02 ` Linus Torvalds
2023-02-13 19:03 ` Linus Torvalds
[not found] < <CAHUa44GAM=meibiSDjjWb0wKmHzud6JddE3W=zG3XCFfgP+Sag@mail.gmail.com>
2023-02-13 18:53 ` Ira Weiny
2023-02-13 18:53 ` Ira Weiny
[not found] < <CAHk-=wh3+moi98rbiMnwnxPNZcYBaVY57TM2EP6NgXgNwFeP7Q@mail.gmail.com>
2023-02-14 8:53 ` Jens Wiklander
2023-02-14 8:53 ` Jens Wiklander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230204065001.GA18482@lst.de \
--to=hch@lst.de \
--cc=op-tee@lists.trustedfirmware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.