[virtio-dev] Re: [PATCH v2] virtio-net: Mention VIRTIO_NET_F_HASH_REPORT dependency on VIRTIO_NET_F_CTRL_VQ

["Michael S. Tsirkin" <mst@redhat.com>]

On Sun, Feb 05, 2023 at 05:19:11PM +0200, Alvaro Karsz wrote:
> If the VIRTIO_NET_F_HASH_REPORT feature is negotiated, the driver may
> send VIRTIO_NET_CTRL_MQ_HASH_CONFIG commands, thus, the control VQ
> feature should be negotiated.
> 
> ---
> v2: Use SHOULD instead of Feature bit requirement, version 1.2 is already
>     out and doesn't include this depencency.
> 
> Signed-off-by: Alvaro Karsz <alvaro.karsz@solid-run.com>
> 
>  device-types/net/description.tex | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/device-types/net/description.tex b/device-types/net/description.tex
> index 700a1cb..4270481 100644
> --- a/device-types/net/description.tex
> +++ b/device-types/net/description.tex
> @@ -256,6 +256,9 @@ \subsection{Device configuration layout}\label{sec:Device Types / Network Device
>  \field{duplex} fields as long as VIRTIO_NET_S_LINK_UP is set in
>  the \field{status}.
>  
> +The device SHOULD offer VIRTIO_NET_F_HASH_REPORT only if it offers
> +VIRTIO_NET_F_CTRL_VQ as well.
> +

That only is confusing. Either say if A then B or if not A then not be.

>  \drivernormative{\subsubsection}{Device configuration layout}{Device Types / Network Device / Device configuration layout}
>  
>  A driver SHOULD negotiate VIRTIO_NET_F_MAC if the device offers it.
> @@ -289,6 +292,8 @@ \subsection{Device configuration layout}\label{sec:Device Types / Network Device
>  SHOULD re-read \field{speed} and \field{duplex} after a
>  configuration change notification.
>  
> +The driver SHOULD negotiate VIRTIO_NET_F_HASH_REPORT only if it negotiates VIRTIO_NET_F_CTRL_VQ.
> +

Same.

>  \subsubsection{Legacy Interface: Device configuration layout}\label{sec:Device Types / Network Device / Device configuration layout / Legacy Interface: Device configuration layout}
>  \label{sec:Device Types / Block Device / Feature bits / Device configuration layout / Legacy Interface: Device configuration layout}
>  When using the legacy interface, transitional devices and drivers
> -- 
> 2.34.1


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org