[virtio-dev] [PATCH] virtio-net: Mention that VIRTIO_NET_F_HASH_REPORT requires VIRTIO_NET_F_CTRL_VQ

[virtio-dev] [PATCH] virtio-net: Mention that VIRTIO_NET_F_HASH_REPORT requires VIRTIO_NET_F_CTRL_VQ

[Alvaro Karsz]

If the VIRTIO_NET_F_HASH_REPORT feature is negotiated, the driver may
send VIRTIO_NET_CTRL_MQ_HASH_CONFIG commands, thus, the control VQ
feature must be negotiated.

Signed-off-by: Alvaro Karsz <alvaro.karsz@solid-run.com>
---
 device-types/net/description.tex | 1 +
 1 file changed, 1 insertion(+)

diff --git a/device-types/net/description.tex b/device-types/net/description.tex
index 700a1cb..83cfe94 100644
--- a/device-types/net/description.tex
+++ b/device-types/net/description.tex
@@ -139,6 +139,7 @@ \subsubsection{Feature bit requirements}\label{sec:Device Types / Network Device
 \item[VIRTIO_NET_F_NOTF_COAL] Requires VIRTIO_NET_F_CTRL_VQ.
 \item[VIRTIO_NET_F_RSC_EXT] Requires VIRTIO_NET_F_HOST_TSO4 or VIRTIO_NET_F_HOST_TSO6.
 \item[VIRTIO_NET_F_RSS] Requires VIRTIO_NET_F_CTRL_VQ.
+\item[VIRTIO_NET_F_HASH_REPORT] Requires VIRTIO_NET_F_CTRL_VQ.
 \end{description}
 
 \subsubsection{Legacy Interface: Feature bits}\label{sec:Device Types / Network Device / Feature bits / Legacy Interface: Feature bits}
-- 
2.34.1


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org

[virtio-comment] Re: [virtio-dev] [PATCH] virtio-net: Mention that VIRTIO_NET_F_HASH_REPORT requires VIRTIO_NET_F_CTRL_VQ

[Michael S. Tsirkin]

On Sun, Feb 05, 2023 at 02:08:01PM +0200, Alvaro Karsz wrote:
> If the VIRTIO_NET_F_HASH_REPORT feature is negotiated, the driver may
> send VIRTIO_NET_CTRL_MQ_HASH_CONFIG commands, thus, the control VQ
> feature must be negotiated.
> 
> Signed-off-by: Alvaro Karsz <alvaro.karsz@solid-run.com>

Unfortunately we did not make this a dependency in 1.2.

So we can make it a SHOULD but not a MUST.


> ---
>  device-types/net/description.tex | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/device-types/net/description.tex b/device-types/net/description.tex
> index 700a1cb..83cfe94 100644
> --- a/device-types/net/description.tex
> +++ b/device-types/net/description.tex
> @@ -139,6 +139,7 @@ \subsubsection{Feature bit requirements}\label{sec:Device Types / Network Device
>  \item[VIRTIO_NET_F_NOTF_COAL] Requires VIRTIO_NET_F_CTRL_VQ.
>  \item[VIRTIO_NET_F_RSC_EXT] Requires VIRTIO_NET_F_HOST_TSO4 or VIRTIO_NET_F_HOST_TSO6.
>  \item[VIRTIO_NET_F_RSS] Requires VIRTIO_NET_F_CTRL_VQ.
> +\item[VIRTIO_NET_F_HASH_REPORT] Requires VIRTIO_NET_F_CTRL_VQ.
>  \end{description}
>  
>  \subsubsection{Legacy Interface: Feature bits}\label{sec:Device Types / Network Device / Feature bits / Legacy Interface: Feature bits}
> -- 
> 2.34.1
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
> For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org


This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.

Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/

[virtio-dev] [PATCH v2] virtio-net: Mention VIRTIO_NET_F_HASH_REPORT dependency on VIRTIO_NET_F_CTRL_VQ

[Alvaro Karsz]

If the VIRTIO_NET_F_HASH_REPORT feature is negotiated, the driver may
send VIRTIO_NET_CTRL_MQ_HASH_CONFIG commands, thus, the control VQ
feature should be negotiated.

---
v2: Use SHOULD instead of Feature bit requirement, version 1.2 is already
    out and doesn't include this depencency.

Signed-off-by: Alvaro Karsz <alvaro.karsz@solid-run.com>

 device-types/net/description.tex | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/device-types/net/description.tex b/device-types/net/description.tex
index 700a1cb..4270481 100644
--- a/device-types/net/description.tex
+++ b/device-types/net/description.tex
@@ -256,6 +256,9 @@ \subsection{Device configuration layout}\label{sec:Device Types / Network Device
 \field{duplex} fields as long as VIRTIO_NET_S_LINK_UP is set in
 the \field{status}.
 
+The device SHOULD offer VIRTIO_NET_F_HASH_REPORT only if it offers
+VIRTIO_NET_F_CTRL_VQ as well.
+
 \drivernormative{\subsubsection}{Device configuration layout}{Device Types / Network Device / Device configuration layout}
 
 A driver SHOULD negotiate VIRTIO_NET_F_MAC if the device offers it.
@@ -289,6 +292,8 @@ \subsection{Device configuration layout}\label{sec:Device Types / Network Device
 SHOULD re-read \field{speed} and \field{duplex} after a
 configuration change notification.
 
+The driver SHOULD negotiate VIRTIO_NET_F_HASH_REPORT only if it negotiates VIRTIO_NET_F_CTRL_VQ.
+
 \subsubsection{Legacy Interface: Device configuration layout}\label{sec:Device Types / Network Device / Device configuration layout / Legacy Interface: Device configuration layout}
 \label{sec:Device Types / Block Device / Feature bits / Device configuration layout / Legacy Interface: Device configuration layout}
 When using the legacy interface, transitional devices and drivers
-- 
2.34.1


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org

[virtio-dev] Re: [PATCH v2] virtio-net: Mention VIRTIO_NET_F_HASH_REPORT dependency on VIRTIO_NET_F_CTRL_VQ

[Michael S. Tsirkin]

On Sun, Feb 05, 2023 at 05:19:11PM +0200, Alvaro Karsz wrote:
> If the VIRTIO_NET_F_HASH_REPORT feature is negotiated, the driver may
> send VIRTIO_NET_CTRL_MQ_HASH_CONFIG commands, thus, the control VQ
> feature should be negotiated.
> 
> ---
> v2: Use SHOULD instead of Feature bit requirement, version 1.2 is already
>     out and doesn't include this depencency.
> 
> Signed-off-by: Alvaro Karsz <alvaro.karsz@solid-run.com>
> 
>  device-types/net/description.tex | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/device-types/net/description.tex b/device-types/net/description.tex
> index 700a1cb..4270481 100644
> --- a/device-types/net/description.tex
> +++ b/device-types/net/description.tex
> @@ -256,6 +256,9 @@ \subsection{Device configuration layout}\label{sec:Device Types / Network Device
>  \field{duplex} fields as long as VIRTIO_NET_S_LINK_UP is set in
>  the \field{status}.
>  
> +The device SHOULD offer VIRTIO_NET_F_HASH_REPORT only if it offers
> +VIRTIO_NET_F_CTRL_VQ as well.
> +

That only is confusing. Either say if A then B or if not A then not be.

>  \drivernormative{\subsubsection}{Device configuration layout}{Device Types / Network Device / Device configuration layout}
>  
>  A driver SHOULD negotiate VIRTIO_NET_F_MAC if the device offers it.
> @@ -289,6 +292,8 @@ \subsection{Device configuration layout}\label{sec:Device Types / Network Device
>  SHOULD re-read \field{speed} and \field{duplex} after a
>  configuration change notification.
>  
> +The driver SHOULD negotiate VIRTIO_NET_F_HASH_REPORT only if it negotiates VIRTIO_NET_F_CTRL_VQ.
> +

Same.

>  \subsubsection{Legacy Interface: Device configuration layout}\label{sec:Device Types / Network Device / Device configuration layout / Legacy Interface: Device configuration layout}
>  \label{sec:Device Types / Block Device / Feature bits / Device configuration layout / Legacy Interface: Device configuration layout}
>  When using the legacy interface, transitional devices and drivers
> -- 
> 2.34.1


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org