* [PATCH net] net: ethernet: mtk_eth_soc: enable special tag when any MAC uses DSA
@ 2023-02-05 17:53 ` arinc9.unal
0 siblings, 0 replies; 18+ messages in thread
From: arinc9.unal @ 2023-02-05 17:53 UTC (permalink / raw)
To: Felix Fietkau, John Crispin, Sean Wang, Mark Lee,
Lorenzo Bianconi, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Matthias Brugger, AngeloGioacchino Del Regno
Cc: Arınç ÜNAL, Richard van Schagen, netdev,
linux-kernel, linux-arm-kernel, linux-mediatek, erkin.bozoglu
From: Arınç ÜNAL <arinc.unal@arinc9.com>
The special tag is only enabled when the first MAC uses DSA. However, it
must be enabled when any MAC uses DSA. Change the check accordingly.
This fixes hardware DSA untagging not working on the second MAC of the
MT7621 and MT7623 SoCs, and likely other SoCs too. Therefore, remove the
check that disables hardware DSA untagging for the second MAC of the MT7621
and MT7623 SoCs.
Fixes: a1f47752fd62 ("net: ethernet: mtk_eth_soc: disable hardware DSA untagging for second MAC")
Co-developed-by: Richard van Schagen <richard@routerhints.com>
Signed-off-by: Richard van Schagen <richard@routerhints.com>
Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
---
drivers/net/ethernet/mediatek/mtk_eth_soc.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
index f1cb1efc94cf..b5b99f417c86 100644
--- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
+++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
@@ -3177,7 +3177,7 @@ static void mtk_gdm_config(struct mtk_eth *eth, u32 config)
val |= config;
- if (!i && eth->netdev[0] && netdev_uses_dsa(eth->netdev[0]))
+ if (eth->netdev[i] && netdev_uses_dsa(eth->netdev[i]))
val |= MTK_GDMA_SPECIAL_TAG;
mtk_w32(eth, val, MTK_GDMA_FWD_CFG(i));
@@ -3243,8 +3243,7 @@ static int mtk_open(struct net_device *dev)
struct mtk_eth *eth = mac->hw;
int i, err;
- if ((mtk_uses_dsa(dev) && !eth->prog) &&
- !(mac->id == 1 && MTK_HAS_CAPS(eth->soc->caps, MTK_GMAC1_TRGMII))) {
+ if (mtk_uses_dsa(dev) && !eth->prog) {
for (i = 0; i < ARRAY_SIZE(eth->dsa_meta); i++) {
struct metadata_dst *md_dst = eth->dsa_meta[i];
@@ -3261,8 +3260,7 @@ static int mtk_open(struct net_device *dev)
}
} else {
/* Hardware special tag parsing needs to be disabled if at least
- * one MAC does not use DSA, or the second MAC of the MT7621 and
- * MT7623 SoCs is being used.
+ * one MAC does not use DSA.
*/
u32 val = mtk_r32(eth, MTK_CDMP_IG_CTRL);
val &= ~MTK_CDMP_STAG_EN;
--
2.37.2
^ permalink raw reply related [flat|nested] 18+ messages in thread* [PATCH net] net: ethernet: mtk_eth_soc: enable special tag when any MAC uses DSA @ 2023-02-05 17:53 ` arinc9.unal 0 siblings, 0 replies; 18+ messages in thread From: arinc9.unal @ 2023-02-05 17:53 UTC (permalink / raw) To: Felix Fietkau, John Crispin, Sean Wang, Mark Lee, Lorenzo Bianconi, David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, Matthias Brugger, AngeloGioacchino Del Regno Cc: Arınç ÜNAL, Richard van Schagen, netdev, linux-kernel, linux-arm-kernel, linux-mediatek, erkin.bozoglu From: Arınç ÜNAL <arinc.unal@arinc9.com> The special tag is only enabled when the first MAC uses DSA. However, it must be enabled when any MAC uses DSA. Change the check accordingly. This fixes hardware DSA untagging not working on the second MAC of the MT7621 and MT7623 SoCs, and likely other SoCs too. Therefore, remove the check that disables hardware DSA untagging for the second MAC of the MT7621 and MT7623 SoCs. Fixes: a1f47752fd62 ("net: ethernet: mtk_eth_soc: disable hardware DSA untagging for second MAC") Co-developed-by: Richard van Schagen <richard@routerhints.com> Signed-off-by: Richard van Schagen <richard@routerhints.com> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> --- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c index f1cb1efc94cf..b5b99f417c86 100644 --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c @@ -3177,7 +3177,7 @@ static void mtk_gdm_config(struct mtk_eth *eth, u32 config) val |= config; - if (!i && eth->netdev[0] && netdev_uses_dsa(eth->netdev[0])) + if (eth->netdev[i] && netdev_uses_dsa(eth->netdev[i])) val |= MTK_GDMA_SPECIAL_TAG; mtk_w32(eth, val, MTK_GDMA_FWD_CFG(i)); @@ -3243,8 +3243,7 @@ static int mtk_open(struct net_device *dev) struct mtk_eth *eth = mac->hw; int i, err; - if ((mtk_uses_dsa(dev) && !eth->prog) && - !(mac->id == 1 && MTK_HAS_CAPS(eth->soc->caps, MTK_GMAC1_TRGMII))) { + if (mtk_uses_dsa(dev) && !eth->prog) { for (i = 0; i < ARRAY_SIZE(eth->dsa_meta); i++) { struct metadata_dst *md_dst = eth->dsa_meta[i]; @@ -3261,8 +3260,7 @@ static int mtk_open(struct net_device *dev) } } else { /* Hardware special tag parsing needs to be disabled if at least - * one MAC does not use DSA, or the second MAC of the MT7621 and - * MT7623 SoCs is being used. + * one MAC does not use DSA. */ u32 val = mtk_r32(eth, MTK_CDMP_IG_CTRL); val &= ~MTK_CDMP_STAG_EN; -- 2.37.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [PATCH net] net: ethernet: mtk_eth_soc: enable special tag when any MAC uses DSA 2023-02-05 17:53 ` arinc9.unal @ 2023-02-07 18:56 ` Jakub Kicinski -1 siblings, 0 replies; 18+ messages in thread From: Jakub Kicinski @ 2023-02-07 18:56 UTC (permalink / raw) To: arinc9.unal Cc: Felix Fietkau, John Crispin, Sean Wang, Mark Lee, Lorenzo Bianconi, David S. Miller, Eric Dumazet, Paolo Abeni, Matthias Brugger, AngeloGioacchino Del Regno, Arınç ÜNAL, Richard van Schagen, netdev, linux-kernel, linux-arm-kernel, linux-mediatek, erkin.bozoglu On Sun, 5 Feb 2023 20:53:31 +0300 arinc9.unal@gmail.com wrote: > From: Arınç ÜNAL <arinc.unal@arinc9.com> > > The special tag is only enabled when the first MAC uses DSA. However, it > must be enabled when any MAC uses DSA. Change the check accordingly. > > This fixes hardware DSA untagging not working on the second MAC of the > MT7621 and MT7623 SoCs, and likely other SoCs too. Therefore, remove the > check that disables hardware DSA untagging for the second MAC of the MT7621 > and MT7623 SoCs. > > Fixes: a1f47752fd62 ("net: ethernet: mtk_eth_soc: disable hardware DSA untagging for second MAC") As Paolo pointed out to me off-list this is pretty much a revert of commit under Fixes. Is this an actual regression fix, or second MAC as DSA port never worked but now you found a way to make it work? ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH net] net: ethernet: mtk_eth_soc: enable special tag when any MAC uses DSA @ 2023-02-07 18:56 ` Jakub Kicinski 0 siblings, 0 replies; 18+ messages in thread From: Jakub Kicinski @ 2023-02-07 18:56 UTC (permalink / raw) To: arinc9.unal Cc: Felix Fietkau, John Crispin, Sean Wang, Mark Lee, Lorenzo Bianconi, David S. Miller, Eric Dumazet, Paolo Abeni, Matthias Brugger, AngeloGioacchino Del Regno, Arınç ÜNAL, Richard van Schagen, netdev, linux-kernel, linux-arm-kernel, linux-mediatek, erkin.bozoglu On Sun, 5 Feb 2023 20:53:31 +0300 arinc9.unal@gmail.com wrote: > From: Arınç ÜNAL <arinc.unal@arinc9.com> > > The special tag is only enabled when the first MAC uses DSA. However, it > must be enabled when any MAC uses DSA. Change the check accordingly. > > This fixes hardware DSA untagging not working on the second MAC of the > MT7621 and MT7623 SoCs, and likely other SoCs too. Therefore, remove the > check that disables hardware DSA untagging for the second MAC of the MT7621 > and MT7623 SoCs. > > Fixes: a1f47752fd62 ("net: ethernet: mtk_eth_soc: disable hardware DSA untagging for second MAC") As Paolo pointed out to me off-list this is pretty much a revert of commit under Fixes. Is this an actual regression fix, or second MAC as DSA port never worked but now you found a way to make it work? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH net] net: ethernet: mtk_eth_soc: enable special tag when any MAC uses DSA 2023-02-07 18:56 ` Jakub Kicinski @ 2023-02-07 20:24 ` Arınç ÜNAL -1 siblings, 0 replies; 18+ messages in thread From: Arınç ÜNAL @ 2023-02-07 20:24 UTC (permalink / raw) To: Jakub Kicinski, arinc9.unal Cc: Felix Fietkau, John Crispin, Sean Wang, Mark Lee, Lorenzo Bianconi, David S. Miller, Eric Dumazet, Paolo Abeni, Matthias Brugger, AngeloGioacchino Del Regno, Richard van Schagen, netdev, linux-kernel, linux-arm-kernel, linux-mediatek, erkin.bozoglu On 7.02.2023 21:56, Jakub Kicinski wrote: > On Sun, 5 Feb 2023 20:53:31 +0300 arinc9.unal@gmail.com wrote: >> From: Arınç ÜNAL <arinc.unal@arinc9.com> >> >> The special tag is only enabled when the first MAC uses DSA. However, it >> must be enabled when any MAC uses DSA. Change the check accordingly. >> >> This fixes hardware DSA untagging not working on the second MAC of the >> MT7621 and MT7623 SoCs, and likely other SoCs too. Therefore, remove the >> check that disables hardware DSA untagging for the second MAC of the MT7621 >> and MT7623 SoCs. >> >> Fixes: a1f47752fd62 ("net: ethernet: mtk_eth_soc: disable hardware DSA untagging for second MAC") > > As Paolo pointed out to me off-list this is pretty much a revert of > commit under Fixes. Is this an actual regression fix, or second MAC > as DSA port never worked but now you found a way to make it work? Second MAC as DSA master after hardware DSA untagging was enabled never worked. I first disabled it to make the communication work again, then, with this patch, I found a way to make it work which is what should've been done with the commit for adding hardware DSA untagging support. Arınç ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH net] net: ethernet: mtk_eth_soc: enable special tag when any MAC uses DSA @ 2023-02-07 20:24 ` Arınç ÜNAL 0 siblings, 0 replies; 18+ messages in thread From: Arınç ÜNAL @ 2023-02-07 20:24 UTC (permalink / raw) To: Jakub Kicinski, arinc9.unal Cc: Felix Fietkau, John Crispin, Sean Wang, Mark Lee, Lorenzo Bianconi, David S. Miller, Eric Dumazet, Paolo Abeni, Matthias Brugger, AngeloGioacchino Del Regno, Richard van Schagen, netdev, linux-kernel, linux-arm-kernel, linux-mediatek, erkin.bozoglu On 7.02.2023 21:56, Jakub Kicinski wrote: > On Sun, 5 Feb 2023 20:53:31 +0300 arinc9.unal@gmail.com wrote: >> From: Arınç ÜNAL <arinc.unal@arinc9.com> >> >> The special tag is only enabled when the first MAC uses DSA. However, it >> must be enabled when any MAC uses DSA. Change the check accordingly. >> >> This fixes hardware DSA untagging not working on the second MAC of the >> MT7621 and MT7623 SoCs, and likely other SoCs too. Therefore, remove the >> check that disables hardware DSA untagging for the second MAC of the MT7621 >> and MT7623 SoCs. >> >> Fixes: a1f47752fd62 ("net: ethernet: mtk_eth_soc: disable hardware DSA untagging for second MAC") > > As Paolo pointed out to me off-list this is pretty much a revert of > commit under Fixes. Is this an actual regression fix, or second MAC > as DSA port never worked but now you found a way to make it work? Second MAC as DSA master after hardware DSA untagging was enabled never worked. I first disabled it to make the communication work again, then, with this patch, I found a way to make it work which is what should've been done with the commit for adding hardware DSA untagging support. Arınç _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH net] net: ethernet: mtk_eth_soc: enable special tag when any MAC uses DSA 2023-02-07 20:24 ` Arınç ÜNAL @ 2023-02-07 20:25 ` Arınç ÜNAL -1 siblings, 0 replies; 18+ messages in thread From: Arınç ÜNAL @ 2023-02-07 20:25 UTC (permalink / raw) To: Jakub Kicinski, arinc9.unal Cc: Felix Fietkau, John Crispin, Sean Wang, Mark Lee, Lorenzo Bianconi, David S. Miller, Eric Dumazet, Paolo Abeni, Matthias Brugger, AngeloGioacchino Del Regno, Richard van Schagen, netdev, linux-kernel, linux-arm-kernel, linux-mediatek, erkin.bozoglu On 7.02.2023 23:24, Arınç ÜNAL wrote: > On 7.02.2023 21:56, Jakub Kicinski wrote: >> On Sun, 5 Feb 2023 20:53:31 +0300 arinc9.unal@gmail.com wrote: >>> From: Arınç ÜNAL <arinc.unal@arinc9.com> >>> >>> The special tag is only enabled when the first MAC uses DSA. However, it >>> must be enabled when any MAC uses DSA. Change the check accordingly. >>> >>> This fixes hardware DSA untagging not working on the second MAC of the >>> MT7621 and MT7623 SoCs, and likely other SoCs too. Therefore, remove the >>> check that disables hardware DSA untagging for the second MAC of the >>> MT7621 >>> and MT7623 SoCs. >>> >>> Fixes: a1f47752fd62 ("net: ethernet: mtk_eth_soc: disable hardware >>> DSA untagging for second MAC") >> >> As Paolo pointed out to me off-list this is pretty much a revert of >> commit under Fixes. Is this an actual regression fix, or second MAC >> as DSA port never worked but now you found a way to make it work? > > Second MAC as DSA master after hardware DSA untagging was enabled never > worked. I first disabled it to make the communication work again, then, > with this patch, I found a way to make it work which is what should've > been done with the commit for adding hardware DSA untagging support. Should both commits be mentioned with Fixes tag? Arınç ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH net] net: ethernet: mtk_eth_soc: enable special tag when any MAC uses DSA @ 2023-02-07 20:25 ` Arınç ÜNAL 0 siblings, 0 replies; 18+ messages in thread From: Arınç ÜNAL @ 2023-02-07 20:25 UTC (permalink / raw) To: Jakub Kicinski, arinc9.unal Cc: Felix Fietkau, John Crispin, Sean Wang, Mark Lee, Lorenzo Bianconi, David S. Miller, Eric Dumazet, Paolo Abeni, Matthias Brugger, AngeloGioacchino Del Regno, Richard van Schagen, netdev, linux-kernel, linux-arm-kernel, linux-mediatek, erkin.bozoglu On 7.02.2023 23:24, Arınç ÜNAL wrote: > On 7.02.2023 21:56, Jakub Kicinski wrote: >> On Sun, 5 Feb 2023 20:53:31 +0300 arinc9.unal@gmail.com wrote: >>> From: Arınç ÜNAL <arinc.unal@arinc9.com> >>> >>> The special tag is only enabled when the first MAC uses DSA. However, it >>> must be enabled when any MAC uses DSA. Change the check accordingly. >>> >>> This fixes hardware DSA untagging not working on the second MAC of the >>> MT7621 and MT7623 SoCs, and likely other SoCs too. Therefore, remove the >>> check that disables hardware DSA untagging for the second MAC of the >>> MT7621 >>> and MT7623 SoCs. >>> >>> Fixes: a1f47752fd62 ("net: ethernet: mtk_eth_soc: disable hardware >>> DSA untagging for second MAC") >> >> As Paolo pointed out to me off-list this is pretty much a revert of >> commit under Fixes. Is this an actual regression fix, or second MAC >> as DSA port never worked but now you found a way to make it work? > > Second MAC as DSA master after hardware DSA untagging was enabled never > worked. I first disabled it to make the communication work again, then, > with this patch, I found a way to make it work which is what should've > been done with the commit for adding hardware DSA untagging support. Should both commits be mentioned with Fixes tag? Arınç _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH net] net: ethernet: mtk_eth_soc: enable special tag when any MAC uses DSA 2023-02-07 20:25 ` Arınç ÜNAL (?) @ 2023-02-07 23:58 ` Jakub Kicinski -1 siblings, 0 replies; 18+ messages in thread From: Jakub Kicinski @ 2023-02-07 23:58 UTC (permalink / raw) To: Arınç ÜNAL Cc: AngeloGioacchino Del Regno, erkin.bozoglu, netdev, Sean Wang, linux-kernel, David S. Miller, Richard van Schagen, Eric Dumazet, linux-mediatek, arinc9.unal, John Crispin, Matthias Brugger, Paolo Abeni, Lorenzo Bianconi, Mark Lee, linux-arm-kernel, Felix Fietkau On Tue, 7 Feb 2023 23:25:32 +0300 Arınç ÜNAL wrote: > >> As Paolo pointed out to me off-list this is pretty much a revert of > >> commit under Fixes. Is this an actual regression fix, or second MAC > >> as DSA port never worked but now you found a way to make it work? > > > > Second MAC as DSA master after hardware DSA untagging was enabled never > > worked. I first disabled it to make the communication work again, then, > > with this patch, I found a way to make it work which is what should've > > been done with the commit for adding hardware DSA untagging support. > > Should both commits be mentioned with Fixes tag? No strong preference, TBH. The motivation for my question was to try to figure out how long we should wait with applying this patch. I applied the commit under Fixes without waiting for a test from Frank, which made me feel a bit guilty :) ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH net] net: ethernet: mtk_eth_soc: enable special tag when any MAC uses DSA @ 2023-02-07 23:58 ` Jakub Kicinski 0 siblings, 0 replies; 18+ messages in thread From: Jakub Kicinski @ 2023-02-07 23:58 UTC (permalink / raw) To: Arınç ÜNAL Cc: arinc9.unal, Felix Fietkau, John Crispin, Sean Wang, Mark Lee, Lorenzo Bianconi, David S. Miller, Eric Dumazet, Paolo Abeni, Matthias Brugger, AngeloGioacchino Del Regno, Richard van Schagen, netdev, linux-kernel, linux-arm-kernel, linux-mediatek, erkin.bozoglu, Frank Wunderlich On Tue, 7 Feb 2023 23:25:32 +0300 Arınç ÜNAL wrote: > >> As Paolo pointed out to me off-list this is pretty much a revert of > >> commit under Fixes. Is this an actual regression fix, or second MAC > >> as DSA port never worked but now you found a way to make it work? > > > > Second MAC as DSA master after hardware DSA untagging was enabled never > > worked. I first disabled it to make the communication work again, then, > > with this patch, I found a way to make it work which is what should've > > been done with the commit for adding hardware DSA untagging support. > > Should both commits be mentioned with Fixes tag? No strong preference, TBH. The motivation for my question was to try to figure out how long we should wait with applying this patch. I applied the commit under Fixes without waiting for a test from Frank, which made me feel a bit guilty :) ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH net] net: ethernet: mtk_eth_soc: enable special tag when any MAC uses DSA @ 2023-02-07 23:58 ` Jakub Kicinski 0 siblings, 0 replies; 18+ messages in thread From: Jakub Kicinski @ 2023-02-07 23:58 UTC (permalink / raw) To: Arınç ÜNAL Cc: arinc9.unal, Felix Fietkau, John Crispin, Sean Wang, Mark Lee, Lorenzo Bianconi, David S. Miller, Eric Dumazet, Paolo Abeni, Matthias Brugger, AngeloGioacchino Del Regno, Richard van Schagen, netdev, linux-kernel, linux-arm-kernel, linux-mediatek, erkin.bozoglu, Frank Wunderlich On Tue, 7 Feb 2023 23:25:32 +0300 Arınç ÜNAL wrote: > >> As Paolo pointed out to me off-list this is pretty much a revert of > >> commit under Fixes. Is this an actual regression fix, or second MAC > >> as DSA port never worked but now you found a way to make it work? > > > > Second MAC as DSA master after hardware DSA untagging was enabled never > > worked. I first disabled it to make the communication work again, then, > > with this patch, I found a way to make it work which is what should've > > been done with the commit for adding hardware DSA untagging support. > > Should both commits be mentioned with Fixes tag? No strong preference, TBH. The motivation for my question was to try to figure out how long we should wait with applying this patch. I applied the commit under Fixes without waiting for a test from Frank, which made me feel a bit guilty :) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH net] net: ethernet: mtk_eth_soc: enable special tag when any MAC uses DSA 2023-02-07 23:58 ` Jakub Kicinski (?) @ 2023-02-08 8:13 ` Arınç ÜNAL -1 siblings, 0 replies; 18+ messages in thread From: Arınç ÜNAL @ 2023-02-08 8:13 UTC (permalink / raw) To: Jakub Kicinski Cc: AngeloGioacchino Del Regno, erkin.bozoglu, netdev, Sean Wang, linux-kernel, David S. Miller, Richard van Schagen, Eric Dumazet, linux-mediatek, arinc9.unal, John Crispin, Matthias Brugger, Paolo Abeni, Lorenzo Bianconi, Mark Lee, linux-arm-kernel, Felix Fietkau On 8.02.2023 02:58, Jakub Kicinski wrote: > On Tue, 7 Feb 2023 23:25:32 +0300 Arınç ÜNAL wrote: >>>> As Paolo pointed out to me off-list this is pretty much a revert of >>>> commit under Fixes. Is this an actual regression fix, or second MAC >>>> as DSA port never worked but now you found a way to make it work? >>> >>> Second MAC as DSA master after hardware DSA untagging was enabled never >>> worked. I first disabled it to make the communication work again, then, >>> with this patch, I found a way to make it work which is what should've >>> been done with the commit for adding hardware DSA untagging support. >> >> Should both commits be mentioned with Fixes tag? > > No strong preference, TBH. > > The motivation for my question was to try to figure out how long we > should wait with applying this patch. I applied the commit under Fixes > without waiting for a test from Frank, which made me feel a bit guilty > :) Oh that's fine, they were going to test on the same hardware I've got anyway. You can apply this one whenever is convenient. Arınç ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH net] net: ethernet: mtk_eth_soc: enable special tag when any MAC uses DSA @ 2023-02-08 8:13 ` Arınç ÜNAL 0 siblings, 0 replies; 18+ messages in thread From: Arınç ÜNAL @ 2023-02-08 8:13 UTC (permalink / raw) To: Jakub Kicinski Cc: arinc9.unal, Felix Fietkau, John Crispin, Sean Wang, Mark Lee, Lorenzo Bianconi, David S. Miller, Eric Dumazet, Paolo Abeni, Matthias Brugger, AngeloGioacchino Del Regno, Richard van Schagen, netdev, linux-kernel, linux-arm-kernel, linux-mediatek, erkin.bozoglu, Frank Wunderlich On 8.02.2023 02:58, Jakub Kicinski wrote: > On Tue, 7 Feb 2023 23:25:32 +0300 Arınç ÜNAL wrote: >>>> As Paolo pointed out to me off-list this is pretty much a revert of >>>> commit under Fixes. Is this an actual regression fix, or second MAC >>>> as DSA port never worked but now you found a way to make it work? >>> >>> Second MAC as DSA master after hardware DSA untagging was enabled never >>> worked. I first disabled it to make the communication work again, then, >>> with this patch, I found a way to make it work which is what should've >>> been done with the commit for adding hardware DSA untagging support. >> >> Should both commits be mentioned with Fixes tag? > > No strong preference, TBH. > > The motivation for my question was to try to figure out how long we > should wait with applying this patch. I applied the commit under Fixes > without waiting for a test from Frank, which made me feel a bit guilty > :) Oh that's fine, they were going to test on the same hardware I've got anyway. You can apply this one whenever is convenient. Arınç ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH net] net: ethernet: mtk_eth_soc: enable special tag when any MAC uses DSA @ 2023-02-08 8:13 ` Arınç ÜNAL 0 siblings, 0 replies; 18+ messages in thread From: Arınç ÜNAL @ 2023-02-08 8:13 UTC (permalink / raw) To: Jakub Kicinski Cc: arinc9.unal, Felix Fietkau, John Crispin, Sean Wang, Mark Lee, Lorenzo Bianconi, David S. Miller, Eric Dumazet, Paolo Abeni, Matthias Brugger, AngeloGioacchino Del Regno, Richard van Schagen, netdev, linux-kernel, linux-arm-kernel, linux-mediatek, erkin.bozoglu, Frank Wunderlich On 8.02.2023 02:58, Jakub Kicinski wrote: > On Tue, 7 Feb 2023 23:25:32 +0300 Arınç ÜNAL wrote: >>>> As Paolo pointed out to me off-list this is pretty much a revert of >>>> commit under Fixes. Is this an actual regression fix, or second MAC >>>> as DSA port never worked but now you found a way to make it work? >>> >>> Second MAC as DSA master after hardware DSA untagging was enabled never >>> worked. I first disabled it to make the communication work again, then, >>> with this patch, I found a way to make it work which is what should've >>> been done with the commit for adding hardware DSA untagging support. >> >> Should both commits be mentioned with Fixes tag? > > No strong preference, TBH. > > The motivation for my question was to try to figure out how long we > should wait with applying this patch. I applied the commit under Fixes > without waiting for a test from Frank, which made me feel a bit guilty > :) Oh that's fine, they were going to test on the same hardware I've got anyway. You can apply this one whenever is convenient. Arınç _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH net] net: ethernet: mtk_eth_soc: enable special tag when any MAC uses DSA 2023-02-07 23:58 ` Jakub Kicinski @ 2023-02-08 14:30 ` Frank Wunderlich -1 siblings, 0 replies; 18+ messages in thread From: Frank Wunderlich @ 2023-02-08 14:30 UTC (permalink / raw) To: Jakub Kicinski, Arınç ÜNAL Cc: arinc9.unal, Felix Fietkau, John Crispin, Sean Wang, Mark Lee, Lorenzo Bianconi, David S. Miller, Eric Dumazet, Paolo Abeni, Matthias Brugger, AngeloGioacchino Del Regno, Richard van Schagen, netdev, linux-kernel, linux-arm-kernel, linux-mediatek, erkin.bozoglu Am 8. Februar 2023 00:58:01 MEZ schrieb Jakub Kicinski <kuba@kernel.org>: > >No strong preference, TBH. > >The motivation for my question was to try to figure out how long we >should wait with applying this patch. I applied the commit under Fixes >without waiting for a test from Frank, which made me feel a bit guilty >:) No worry. You don't have to feel guilty for it. My limited time currently does not allow test all patches in all circumstances...i trust arinc to make it better than before...there are many patches floating around which fixing some corner cases in mtk eth driver. I hope these are applied i had tested and for the others i report a bug when i notice any problem :) Would be nice if felix' series can be merged for fixing sw vlan on non-dsa mac and the one from vladimir fixing the vlan_aware bridge without breaking dsa port outside the bridge on same gmac. regards Frank ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH net] net: ethernet: mtk_eth_soc: enable special tag when any MAC uses DSA @ 2023-02-08 14:30 ` Frank Wunderlich 0 siblings, 0 replies; 18+ messages in thread From: Frank Wunderlich @ 2023-02-08 14:30 UTC (permalink / raw) To: Jakub Kicinski, Arınç ÜNAL Cc: arinc9.unal, Felix Fietkau, John Crispin, Sean Wang, Mark Lee, Lorenzo Bianconi, David S. Miller, Eric Dumazet, Paolo Abeni, Matthias Brugger, AngeloGioacchino Del Regno, Richard van Schagen, netdev, linux-kernel, linux-arm-kernel, linux-mediatek, erkin.bozoglu Am 8. Februar 2023 00:58:01 MEZ schrieb Jakub Kicinski <kuba@kernel.org>: > >No strong preference, TBH. > >The motivation for my question was to try to figure out how long we >should wait with applying this patch. I applied the commit under Fixes >without waiting for a test from Frank, which made me feel a bit guilty >:) No worry. You don't have to feel guilty for it. My limited time currently does not allow test all patches in all circumstances...i trust arinc to make it better than before...there are many patches floating around which fixing some corner cases in mtk eth driver. I hope these are applied i had tested and for the others i report a bug when i notice any problem :) Would be nice if felix' series can be merged for fixing sw vlan on non-dsa mac and the one from vladimir fixing the vlan_aware bridge without breaking dsa port outside the bridge on same gmac. regards Frank _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH net] net: ethernet: mtk_eth_soc: enable special tag when any MAC uses DSA 2023-02-05 17:53 ` arinc9.unal @ 2023-02-08 9:10 ` patchwork-bot+netdevbpf -1 siblings, 0 replies; 18+ messages in thread From: patchwork-bot+netdevbpf @ 2023-02-08 9:10 UTC (permalink / raw) To: Willem-Jan de Hoog Cc: nbd, john, sean.wang, Mark-MC.Lee, lorenzo, davem, edumazet, kuba, pabeni, matthias.bgg, angelogioacchino.delregno, arinc.unal, richard, netdev, linux-kernel, linux-arm-kernel, linux-mediatek, erkin.bozoglu Hello: This patch was applied to netdev/net.git (master) by David S. Miller <davem@davemloft.net>: On Sun, 5 Feb 2023 20:53:31 +0300 you wrote: > From: Arınç ÜNAL <arinc.unal@arinc9.com> > > The special tag is only enabled when the first MAC uses DSA. However, it > must be enabled when any MAC uses DSA. Change the check accordingly. > > This fixes hardware DSA untagging not working on the second MAC of the > MT7621 and MT7623 SoCs, and likely other SoCs too. Therefore, remove the > check that disables hardware DSA untagging for the second MAC of the MT7621 > and MT7623 SoCs. > > [...] Here is the summary with links: - [net] net: ethernet: mtk_eth_soc: enable special tag when any MAC uses DSA https://git.kernel.org/netdev/net/c/21386e692613 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH net] net: ethernet: mtk_eth_soc: enable special tag when any MAC uses DSA @ 2023-02-08 9:10 ` patchwork-bot+netdevbpf 0 siblings, 0 replies; 18+ messages in thread From: patchwork-bot+netdevbpf @ 2023-02-08 9:10 UTC (permalink / raw) To: Willem-Jan de Hoog Cc: nbd, john, sean.wang, Mark-MC.Lee, lorenzo, davem, edumazet, kuba, pabeni, matthias.bgg, angelogioacchino.delregno, arinc.unal, richard, netdev, linux-kernel, linux-arm-kernel, linux-mediatek, erkin.bozoglu Hello: This patch was applied to netdev/net.git (master) by David S. Miller <davem@davemloft.net>: On Sun, 5 Feb 2023 20:53:31 +0300 you wrote: > From: Arınç ÜNAL <arinc.unal@arinc9.com> > > The special tag is only enabled when the first MAC uses DSA. However, it > must be enabled when any MAC uses DSA. Change the check accordingly. > > This fixes hardware DSA untagging not working on the second MAC of the > MT7621 and MT7623 SoCs, and likely other SoCs too. Therefore, remove the > check that disables hardware DSA untagging for the second MAC of the MT7621 > and MT7623 SoCs. > > [...] Here is the summary with links: - [net] net: ethernet: mtk_eth_soc: enable special tag when any MAC uses DSA https://git.kernel.org/netdev/net/c/21386e692613 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 18+ messages in thread
end of thread, other threads:[~2023-02-08 14:32 UTC | newest] Thread overview: 18+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-02-05 17:53 [PATCH net] net: ethernet: mtk_eth_soc: enable special tag when any MAC uses DSA arinc9.unal 2023-02-05 17:53 ` arinc9.unal 2023-02-07 18:56 ` Jakub Kicinski 2023-02-07 18:56 ` Jakub Kicinski 2023-02-07 20:24 ` Arınç ÜNAL 2023-02-07 20:24 ` Arınç ÜNAL 2023-02-07 20:25 ` Arınç ÜNAL 2023-02-07 20:25 ` Arınç ÜNAL 2023-02-07 23:58 ` Jakub Kicinski 2023-02-07 23:58 ` Jakub Kicinski 2023-02-07 23:58 ` Jakub Kicinski 2023-02-08 8:13 ` Arınç ÜNAL 2023-02-08 8:13 ` Arınç ÜNAL 2023-02-08 8:13 ` Arınç ÜNAL 2023-02-08 14:30 ` Frank Wunderlich 2023-02-08 14:30 ` Frank Wunderlich 2023-02-08 9:10 ` patchwork-bot+netdevbpf 2023-02-08 9:10 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.