From: Titus Rwantare <titusr@google.com>
To: philmd@linaro.org, minyard@acm.org, eddie.dong@intel.com
Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org, joel@jms.id.au,
Titus Rwantare <titusr@google.com>, Hao Wu <wuhaotsh@google.com>
Subject: [PATCH v2 3/4] hw/gpio: add PCA9536 i2c gpio expander
Date: Wed, 8 Feb 2023 22:43:38 +0000 [thread overview]
Message-ID: <20230208224339.270589-4-titusr@google.com> (raw)
In-Reply-To: <20230208224339.270589-1-titusr@google.com>
This device has the same register layout as the pca9538, but 4 fewer
gpio pins. This commit lowers the number of pins initialised, and reuses
the pca9538 logic.
Reviewed-by: Hao Wu <wuhaotsh@google.com>
Signed-off-by: Titus Rwantare <titusr@google.com>
---
hw/gpio/pca_i2c_gpio.c | 18 ++++++++++++++++++
include/hw/gpio/pca_i2c_gpio.h | 2 ++
2 files changed, 20 insertions(+)
diff --git a/hw/gpio/pca_i2c_gpio.c b/hw/gpio/pca_i2c_gpio.c
index fa69523556..8e30064990 100644
--- a/hw/gpio/pca_i2c_gpio.c
+++ b/hw/gpio/pca_i2c_gpio.c
@@ -426,6 +426,19 @@ static void pca9538_gpio_class_init(ObjectClass *klass, void *data)
k->send = pca9538_send;
}
+static void pca9536_gpio_class_init(ObjectClass *klass, void *data)
+{
+ DeviceClass *dc = DEVICE_CLASS(klass);
+ I2CSlaveClass *k = I2C_SLAVE_CLASS(klass);
+ PCAGPIOClass *pc = PCA_I2C_GPIO_CLASS(klass);
+
+ dc->desc = "PCA9536 4-bit I/O expander";
+ pc->num_pins = PCA9536_NUM_PINS;
+
+ k->recv = pca9538_recv;
+ k->send = pca9538_send;
+}
+
static void pca_i2c_gpio_class_init(ObjectClass *klass, void *data)
{
DeviceClass *dc = DEVICE_CLASS(klass);
@@ -477,6 +490,11 @@ static const TypeInfo pca_gpio_types[] = {
.parent = TYPE_PCA_I2C_GPIO,
.class_init = pca9538_gpio_class_init,
},
+ {
+ .name = TYPE_PCA9536_GPIO,
+ .parent = TYPE_PCA_I2C_GPIO,
+ .class_init = pca9536_gpio_class_init,
+ },
};
DEFINE_TYPES(pca_gpio_types);
diff --git a/include/hw/gpio/pca_i2c_gpio.h b/include/hw/gpio/pca_i2c_gpio.h
index 3ab7d19a97..6f8260a8c6 100644
--- a/include/hw/gpio/pca_i2c_gpio.h
+++ b/include/hw/gpio/pca_i2c_gpio.h
@@ -20,6 +20,7 @@
#define PCA_I2C_MAX_PINS 16
#define PCA6416_NUM_PINS 16
#define PCA9538_NUM_PINS 8
+#define PCA9536_NUM_PINS 4
typedef struct PCAGPIOClass {
I2CSlaveClass parent;
@@ -72,5 +73,6 @@ OBJECT_DECLARE_TYPE(PCAGPIOState, PCAGPIOClass, PCA_I2C_GPIO)
#define TYPE_PCA6416_GPIO "pca6416"
#define TYPE_PCA9538_GPIO "pca9538"
+#define TYPE_PCA9536_GPIO "pca9536"
#endif
--
2.39.1.581.gbfd45094c4-goog
next prev parent reply other threads:[~2023-02-08 22:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-08 22:43 [PATCH v2 0/4] PCA I2C GPIO expanders Titus Rwantare
2023-02-08 22:43 ` [PATCH v2 1/4] hw/gpio: add PCA6416 i2c GPIO expander Titus Rwantare
2023-02-09 7:44 ` Philippe Mathieu-Daudé
2023-02-08 22:43 ` [PATCH v2 2/4] hw/gpio: add PCA9538 8-bit " Titus Rwantare
2023-02-09 7:57 ` Philippe Mathieu-Daudé
2023-02-08 22:43 ` Titus Rwantare [this message]
2023-02-09 8:00 ` [PATCH v2 3/4] hw/gpio: add PCA9536 i2c gpio expander Philippe Mathieu-Daudé
2023-02-08 22:43 ` [PATCH v2 4/4] hw/i2c: add canonical path to i2c event traces Titus Rwantare
2023-02-09 8:01 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230208224339.270589-4-titusr@google.com \
--to=titusr@google.com \
--cc=eddie.dong@intel.com \
--cc=joel@jms.id.au \
--cc=minyard@acm.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=wuhaotsh@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.