From: Titus Rwantare <titusr@google.com>
To: philmd@linaro.org, minyard@acm.org, eddie.dong@intel.com
Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org, joel@jms.id.au,
Titus Rwantare <titusr@google.com>
Subject: [PATCH v2 4/4] hw/i2c: add canonical path to i2c event traces
Date: Wed, 8 Feb 2023 22:43:39 +0000 [thread overview]
Message-ID: <20230208224339.270589-5-titusr@google.com> (raw)
In-Reply-To: <20230208224339.270589-1-titusr@google.com>
Signed-off-by: Titus Rwantare <titusr@google.com>
---
hw/i2c/core.c | 8 +++++---
hw/i2c/trace-events | 2 +-
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/hw/i2c/core.c b/hw/i2c/core.c
index d4ba8146bf..c583c1497a 100644
--- a/hw/i2c/core.c
+++ b/hw/i2c/core.c
@@ -161,7 +161,8 @@ static int i2c_do_start_transfer(I2CBus *bus, uint8_t address,
start condition. */
if (sc->event) {
- trace_i2c_event(event == I2C_START_SEND ? "start" : "start_async",
+ trace_i2c_event(DEVICE(s)->canonical_path,
+ event == I2C_START_SEND ? "start" : "start_async",
s->address);
rv = sc->event(s, event);
if (rv && !bus->broadcast) {
@@ -227,7 +228,7 @@ void i2c_end_transfer(I2CBus *bus)
I2CSlave *s = node->elt;
sc = I2C_SLAVE_GET_CLASS(s);
if (sc->event) {
- trace_i2c_event("finish", s->address);
+ trace_i2c_event(DEVICE(s)->canonical_path, "finish", s->address);
sc->event(s, I2C_FINISH);
}
QLIST_REMOVE(node, next);
@@ -314,7 +315,8 @@ void i2c_nack(I2CBus *bus)
QLIST_FOREACH(node, &bus->current_devs, next) {
sc = I2C_SLAVE_GET_CLASS(node->elt);
if (sc->event) {
- trace_i2c_event("nack", node->elt->address);
+ trace_i2c_event(DEVICE(node->elt)->canonical_path,
+ "nack", node->elt->address);
sc->event(node->elt, I2C_NACK);
}
}
diff --git a/hw/i2c/trace-events b/hw/i2c/trace-events
index 8e88aa24c1..f42a1ff539 100644
--- a/hw/i2c/trace-events
+++ b/hw/i2c/trace-events
@@ -9,7 +9,7 @@ bitbang_i2c_data(unsigned dat, unsigned clk, unsigned old_out, unsigned new_out)
# core.c
-i2c_event(const char *event, uint8_t address) "%s(addr:0x%02x)"
+i2c_event(const char *id, const char *event, uint8_t address) "%s: %s(addr:0x%02x)"
i2c_send(uint8_t address, uint8_t data) "send(addr:0x%02x) data:0x%02x"
i2c_send_async(uint8_t address, uint8_t data) "send_async(addr:0x%02x) data:0x%02x"
i2c_recv(uint8_t address, uint8_t data) "recv(addr:0x%02x) data:0x%02x"
--
2.39.1.581.gbfd45094c4-goog
next prev parent reply other threads:[~2023-02-08 22:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-08 22:43 [PATCH v2 0/4] PCA I2C GPIO expanders Titus Rwantare
2023-02-08 22:43 ` [PATCH v2 1/4] hw/gpio: add PCA6416 i2c GPIO expander Titus Rwantare
2023-02-09 7:44 ` Philippe Mathieu-Daudé
2023-02-08 22:43 ` [PATCH v2 2/4] hw/gpio: add PCA9538 8-bit " Titus Rwantare
2023-02-09 7:57 ` Philippe Mathieu-Daudé
2023-02-08 22:43 ` [PATCH v2 3/4] hw/gpio: add PCA9536 i2c gpio expander Titus Rwantare
2023-02-09 8:00 ` Philippe Mathieu-Daudé
2023-02-08 22:43 ` Titus Rwantare [this message]
2023-02-09 8:01 ` [PATCH v2 4/4] hw/i2c: add canonical path to i2c event traces Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230208224339.270589-5-titusr@google.com \
--to=titusr@google.com \
--cc=eddie.dong@intel.com \
--cc=joel@jms.id.au \
--cc=minyard@acm.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.