[meta-arago][kirkstone/master][PATCH] arago-image: Remove unneeded make_bootfiles_symlinks_relative

[meta-arago][kirkstone/master][PATCH] arago-image: Remove unneeded make_bootfiles_symlinks_relative

[Andrew Davis]

This post process step is not currently used and will not be needed
as non-relative symlinks are no longer created in the boot files.

Signed-off-by: Andrew Davis <afd@ti.com>
---
 .../recipes-core/images/arago-image.inc       | 19 -------------------
 1 file changed, 19 deletions(-)

diff --git a/meta-arago-distro/recipes-core/images/arago-image.inc b/meta-arago-distro/recipes-core/images/arago-image.inc
index 0bb3634b..923bc84f 100644
--- a/meta-arago-distro/recipes-core/images/arago-image.inc
+++ b/meta-arago-distro/recipes-core/images/arago-image.inc
@@ -22,25 +22,6 @@ IMAGE_LINGUAS = ""
 TOOLCHAIN_HOST_TASK += "nativesdk-buildtools-perl-dummy"
 SDK_PACKAGE_ARCHS += "buildtools-dummy-${SDKPKGSUFFIX}"
 
-# FIXME: remove bashisms from this function (currently disabled)
-make_bootfiles_symlinks_relative() {
-    for f in "${IMAGE_ROOTFS}/boot"/*
-    do
-        [ -L "$f" ] || continue
-
-        l=$(readlink "$f")
-        if [ "${l:0:6}" == "/boot/" ]
-        then
-            ln -sf "${l##/boot/}" "$f"
-        elif ["${l:0:1}" == "/" ]
-        then
-            ln -sf "..$l" "$f"
-        fi
-    done
-}
-
-#ROOTFS_POSTPROCESS_COMMAND += "make_bootfiles_symlinks_relative;"
-
 BAD_RECOMMENDATIONS += " \
     ti-llvm3.6-dev \
     opencl-monitor-dev \
-- 
2.39.1

Re: [meta-arago][kirkstone/master][PATCH] arago-image: Remove unneeded make_bootfiles_symlinks_relative

[Denys Dmytriyenko]

On Wed, Feb 08, 2023 at 05:33:02PM -0600, Andrew Davis via lists.yoctoproject.org wrote:
> This post process step is not currently used and will not be needed
> as non-relative symlinks are no longer created in the boot files.

FWIW, this was already removed in dunfell and was pending porting to kirkstone 
by the next sync up patchset:
https://git.yoctoproject.org/meta-arago/commit/?h=dunfell&id=f683ed96f90fcfea01f03a7f7ea1f285181af03e


> Signed-off-by: Andrew Davis <afd@ti.com>
> ---
>  .../recipes-core/images/arago-image.inc       | 19 -------------------
>  1 file changed, 19 deletions(-)
> 
> diff --git a/meta-arago-distro/recipes-core/images/arago-image.inc b/meta-arago-distro/recipes-core/images/arago-image.inc
> index 0bb3634b..923bc84f 100644
> --- a/meta-arago-distro/recipes-core/images/arago-image.inc
> +++ b/meta-arago-distro/recipes-core/images/arago-image.inc
> @@ -22,25 +22,6 @@ IMAGE_LINGUAS = ""
>  TOOLCHAIN_HOST_TASK += "nativesdk-buildtools-perl-dummy"
>  SDK_PACKAGE_ARCHS += "buildtools-dummy-${SDKPKGSUFFIX}"
>  
> -# FIXME: remove bashisms from this function (currently disabled)
> -make_bootfiles_symlinks_relative() {
> -    for f in "${IMAGE_ROOTFS}/boot"/*
> -    do
> -        [ -L "$f" ] || continue
> -
> -        l=$(readlink "$f")
> -        if [ "${l:0:6}" == "/boot/" ]
> -        then
> -            ln -sf "${l##/boot/}" "$f"
> -        elif ["${l:0:1}" == "/" ]
> -        then
> -            ln -sf "..$l" "$f"
> -        fi
> -    done
> -}
> -
> -#ROOTFS_POSTPROCESS_COMMAND += "make_bootfiles_symlinks_relative;"
> -
>  BAD_RECOMMENDATIONS += " \
>      ti-llvm3.6-dev \
>      opencl-monitor-dev \
> -- 
> 2.39.1