From: "Michael S. Tsirkin" <mst@redhat.com>
To: Parav Pandit <parav@nvidia.com>
Cc: David Edmondson <david.edmondson@oracle.com>,
"virtio-dev@lists.oasis-open.org"
<virtio-dev@lists.oasis-open.org>,
"cohuck@redhat.com" <cohuck@redhat.com>,
Shahaf Shuler <shahafs@nvidia.com>,
"virtio-comment@lists.oasis-open.org"
<virtio-comment@lists.oasis-open.org>
Subject: Re: [virtio-comment] [PATCH v3] virtio-net: Improve introductory description
Date: Thu, 9 Feb 2023 07:48:05 -0500 [thread overview]
Message-ID: <20230209074712-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <PH0PR12MB548195947918089961CEE699DCD99@PH0PR12MB5481.namprd12.prod.outlook.com>
On Thu, Feb 09, 2023 at 12:45:09PM +0000, Parav Pandit wrote:
>
> > From: David Edmondson <david.edmondson@oracle.com>
> > Sent: Thursday, February 9, 2023 7:03 AM
> >
>
> [..]
> > > +to the Ethernet network. The device has transmit and receive queues.
> > > +The driver posts empty buffers in the receive virtqueue.
> > > +The device receives the incoming packets from the link; the device
> > > +places these incoming packets in the receive virtqueue buffers.
> > > +The driver enqueues outgoing packets to the transmit virtqueue. The
> > > device
> >
> > We "post" receive buffers, yet "enqueue" transmit buffers. These actions seem
> > the same.
> >
> > Maybe "submits" in both cases?
> >
> At virtqueue level it is same.
> In context of virtio net device, transmit operation is queued that awaits processing (to send) by device.
> While receive side, its unsolicited operation done by driver that doesn't await processing by device.
> Whenever/if in future when a packet arrives, the posted buffer is consumed.
>
> So enqueue and post were capturing this contextual detail.
> But maybe I am trying to be too precise here but above wording were more natural to me at net level. :)
> Let me know..
Just "add" - this is what happens at vq level:
Driver makes requests available to device by adding
an available buffer to the queue, i.e., adding a buffer
--
MST
next prev parent reply other threads:[~2023-02-09 12:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-09 1:41 [PATCH v3] virtio-net: Improve introductory description Parav Pandit
2023-02-09 11:38 ` [virtio-comment] " Cornelia Huck
2023-02-09 12:38 ` Parav Pandit
2023-02-09 12:02 ` [virtio-comment] " David Edmondson
2023-02-09 12:45 ` Parav Pandit
2023-02-09 12:48 ` Michael S. Tsirkin [this message]
2023-02-09 13:16 ` David Edmondson
2023-02-09 12:18 ` Michael S. Tsirkin
2023-02-09 12:29 ` [virtio-dev] " Cornelia Huck
2023-02-09 12:31 ` Michael S. Tsirkin
2023-02-09 12:47 ` Parav Pandit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230209074712-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=cohuck@redhat.com \
--cc=david.edmondson@oracle.com \
--cc=parav@nvidia.com \
--cc=shahafs@nvidia.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtio-dev@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.