All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/ssdp-responder; drop systemd unit installation, not needed
@ 2023-02-10 18:47 Joachim Wiberg
  2023-02-10 22:38 ` Thomas Petazzoni via buildroot
  2023-02-28 20:34 ` Peter Korsgaard
  0 siblings, 2 replies; 3+ messages in thread
From: Joachim Wiberg @ 2023-02-10 18:47 UTC (permalink / raw)
  To: buildroot; +Cc: Joachim Wiberg

When systemd is enabled the ssdp-responder build system already installs
the unit file, with the correct name, so we can safely drop this.

This fixes the recurring autobuilder problems that cropped up the last
week+ or so after fixing the spelling error in 6e0ba6b.

 - http://autobuild.buildroot.net/results/f6912d6f79155c5d12811beeb6cb43860e37e7e7
 - http://autobuild.buildroot.net/results/7ee4ed26de7e45b52a9f6f36b839e578d2319247
 - http://autobuild.buildroot.net/results/33d9c10ea58a7cd3b3e2ed75d586007a92ccdaf0
 - http://autobuild.buildroot.net/results/f1238081fc94e3004aebb8e849fdd567a92a2d39
 - http://autobuild.buildroot.net/results/f7f2cf790f51e6224dca258c52bd31d21d621074

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
---
 package/ssdp-responder/ssdp-responder.mk | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/package/ssdp-responder/ssdp-responder.mk b/package/ssdp-responder/ssdp-responder.mk
index d40f6f8c57..5193966908 100644
--- a/package/ssdp-responder/ssdp-responder.mk
+++ b/package/ssdp-responder/ssdp-responder.mk
@@ -25,9 +25,4 @@ define SSDP_RESPONDER_INSTALL_INIT_SYSV
 		$(TARGET_DIR)/etc/init.d/S50ssdpd
 endef
 
-define SSDP_RESPONDER_INSTALL_INIT_SYSTEMD
-	$(INSTALL) -D -m 644 $(@D)/ssdp-responder.service \
-		$(TARGET_DIR)/usr/lib/systemd/system/ssdp-responder.service
-endef
-
 $(eval $(autotools-package))
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/ssdp-responder; drop systemd unit installation, not needed
  2023-02-10 18:47 [Buildroot] [PATCH 1/1] package/ssdp-responder; drop systemd unit installation, not needed Joachim Wiberg
@ 2023-02-10 22:38 ` Thomas Petazzoni via buildroot
  2023-02-28 20:34 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni via buildroot @ 2023-02-10 22:38 UTC (permalink / raw)
  To: Joachim Wiberg; +Cc: buildroot

On Fri, 10 Feb 2023 19:47:04 +0100
Joachim Wiberg <troglobit@gmail.com> wrote:

> When systemd is enabled the ssdp-responder build system already installs
> the unit file, with the correct name, so we can safely drop this.
> 
> This fixes the recurring autobuilder problems that cropped up the last
> week+ or so after fixing the spelling error in 6e0ba6b.
> 
>  - http://autobuild.buildroot.net/results/f6912d6f79155c5d12811beeb6cb43860e37e7e7
>  - http://autobuild.buildroot.net/results/7ee4ed26de7e45b52a9f6f36b839e578d2319247
>  - http://autobuild.buildroot.net/results/33d9c10ea58a7cd3b3e2ed75d586007a92ccdaf0
>  - http://autobuild.buildroot.net/results/f1238081fc94e3004aebb8e849fdd567a92a2d39
>  - http://autobuild.buildroot.net/results/f7f2cf790f51e6224dca258c52bd31d21d621074
> 
> Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
> ---
>  package/ssdp-responder/ssdp-responder.mk | 5 -----
>  1 file changed, 5 deletions(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/ssdp-responder; drop systemd unit installation, not needed
  2023-02-10 18:47 [Buildroot] [PATCH 1/1] package/ssdp-responder; drop systemd unit installation, not needed Joachim Wiberg
  2023-02-10 22:38 ` Thomas Petazzoni via buildroot
@ 2023-02-28 20:34 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2023-02-28 20:34 UTC (permalink / raw)
  To: Joachim Wiberg; +Cc: buildroot

>>>>> "Joachim" == Joachim Wiberg <troglobit@gmail.com> writes:

 > When systemd is enabled the ssdp-responder build system already installs
 > the unit file, with the correct name, so we can safely drop this.

 > This fixes the recurring autobuilder problems that cropped up the last
 > week+ or so after fixing the spelling error in 6e0ba6b.

 >  - http://autobuild.buildroot.net/results/f6912d6f79155c5d12811beeb6cb43860e37e7e7
 >  - http://autobuild.buildroot.net/results/7ee4ed26de7e45b52a9f6f36b839e578d2319247
 >  - http://autobuild.buildroot.net/results/33d9c10ea58a7cd3b3e2ed75d586007a92ccdaf0
 >  - http://autobuild.buildroot.net/results/f1238081fc94e3004aebb8e849fdd567a92a2d39
 >  - http://autobuild.buildroot.net/results/f7f2cf790f51e6224dca258c52bd31d21d621074

 > Signed-off-by: Joachim Wiberg <troglobit@gmail.com>

Committed to 2022.11.x and 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-02-28 20:35 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-10 18:47 [Buildroot] [PATCH 1/1] package/ssdp-responder; drop systemd unit installation, not needed Joachim Wiberg
2023-02-10 22:38 ` Thomas Petazzoni via buildroot
2023-02-28 20:34 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.