* [trace:trace/urgent 13/13] kernel/trace/trace_events.c:158:5: warning: no previous prototype for 'trace_define_field_ext'
@ 2023-02-12 23:30 kernel test robot
2023-02-13 4:20 ` Yafang Shao
0 siblings, 1 reply; 4+ messages in thread
From: kernel test robot @ 2023-02-12 23:30 UTC (permalink / raw)
To: Yafang Shao; +Cc: oe-kbuild-all, Steven Rostedt (Google)
tree: git://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace trace/urgent
head: b6c7abd1c28a63ad633433d037ee15a1bc3023ba
commit: b6c7abd1c28a63ad633433d037ee15a1bc3023ba [13/13] tracing: Fix TASK_COMM_LEN in trace event format file
config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20230213/202302130750.679RaRog-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace.git/commit/?id=b6c7abd1c28a63ad633433d037ee15a1bc3023ba
git remote add trace git://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace
git fetch --no-tags trace trace/urgent
git checkout b6c7abd1c28a63ad633433d037ee15a1bc3023ba
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sh olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sh SHELL=/bin/bash kernel/trace/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202302130750.679RaRog-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> kernel/trace/trace_events.c:158:5: warning: no previous prototype for 'trace_define_field_ext' [-Wmissing-prototypes]
158 | int trace_define_field_ext(struct trace_event_call *call, const char *type,
| ^~~~~~~~~~~~~~~~~~~~~~
vim +/trace_define_field_ext +158 kernel/trace/trace_events.c
157
> 158 int trace_define_field_ext(struct trace_event_call *call, const char *type,
159 const char *name, int offset, int size, int is_signed,
160 int filter_type, int len)
161 {
162 struct list_head *head;
163
164 if (WARN_ON(!call->class))
165 return 0;
166
167 head = trace_get_fields(call);
168 return __trace_define_field(head, type, name, offset, size,
169 is_signed, filter_type, len);
170 }
171
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [trace:trace/urgent 13/13] kernel/trace/trace_events.c:158:5: warning: no previous prototype for 'trace_define_field_ext'
2023-02-12 23:30 [trace:trace/urgent 13/13] kernel/trace/trace_events.c:158:5: warning: no previous prototype for 'trace_define_field_ext' kernel test robot
@ 2023-02-13 4:20 ` Yafang Shao
2023-02-13 8:37 ` Steven Rostedt
0 siblings, 1 reply; 4+ messages in thread
From: Yafang Shao @ 2023-02-13 4:20 UTC (permalink / raw)
To: kernel test robot; +Cc: oe-kbuild-all, Steven Rostedt (Google)
On Mon, Feb 13, 2023 at 7:30 AM kernel test robot <lkp@intel.com> wrote:
>
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace trace/urgent
> head: b6c7abd1c28a63ad633433d037ee15a1bc3023ba
> commit: b6c7abd1c28a63ad633433d037ee15a1bc3023ba [13/13] tracing: Fix TASK_COMM_LEN in trace event format file
> config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20230213/202302130750.679RaRog-lkp@intel.com/config)
> compiler: sh4-linux-gcc (GCC) 12.1.0
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # https://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace.git/commit/?id=b6c7abd1c28a63ad633433d037ee15a1bc3023ba
> git remote add trace git://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace
> git fetch --no-tags trace trace/urgent
> git checkout b6c7abd1c28a63ad633433d037ee15a1bc3023ba
> # save the config file
> mkdir build_dir && cp config build_dir/.config
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sh olddefconfig
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sh SHELL=/bin/bash kernel/trace/
>
> If you fix the issue, kindly add following tag where applicable
> | Reported-by: kernel test robot <lkp@intel.com>
> | Link: https://lore.kernel.org/oe-kbuild-all/202302130750.679RaRog-lkp@intel.com/
>
> All warnings (new ones prefixed by >>):
>
> >> kernel/trace/trace_events.c:158:5: warning: no previous prototype for 'trace_define_field_ext' [-Wmissing-prototypes]
> 158 | int trace_define_field_ext(struct trace_event_call *call, const char *type,
> | ^~~~~~~~~~~~~~~~~~~~~~
>
Thanks for the report.
Should make trace_define_field_ext static.
I will send a fix.
>
> vim +/trace_define_field_ext +158 kernel/trace/trace_events.c
>
> 157
> > 158 int trace_define_field_ext(struct trace_event_call *call, const char *type,
> 159 const char *name, int offset, int size, int is_signed,
> 160 int filter_type, int len)
> 161 {
> 162 struct list_head *head;
> 163
> 164 if (WARN_ON(!call->class))
> 165 return 0;
> 166
> 167 head = trace_get_fields(call);
> 168 return __trace_define_field(head, type, name, offset, size,
> 169 is_signed, filter_type, len);
> 170 }
> 171
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests
--
Regards
Yafang
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [trace:trace/urgent 13/13] kernel/trace/trace_events.c:158:5: warning: no previous prototype for 'trace_define_field_ext'
2023-02-13 4:20 ` Yafang Shao
@ 2023-02-13 8:37 ` Steven Rostedt
2023-02-13 14:18 ` Yafang Shao
0 siblings, 1 reply; 4+ messages in thread
From: Steven Rostedt @ 2023-02-13 8:37 UTC (permalink / raw)
To: Yafang Shao, kernel test robot; +Cc: oe-kbuild-all
On February 12, 2023 11:20:59 PM EST, Yafang Shao <laoar.shao@gmail.com> wrote:
>On Mon, Feb 13, 2023 at 7:30 AM kernel test robot <lkp@intel.com> wrote:
>>
>> tree: git://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace trace/urgent
>> head: b6c7abd1c28a63ad633433d037ee15a1bc3023ba
>> commit: b6c7abd1c28a63ad633433d037ee15a1bc3023ba [13/13] tracing: Fix TASK_COMM_LEN in trace event format file
>> config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20230213/202302130750.679RaRog-lkp@intel.com/config)
>> compiler: sh4-linux-gcc (GCC) 12.1.0
>> reproduce (this is a W=1 build):
>> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>> chmod +x ~/bin/make.cross
>> # https://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace.git/commit/?id=b6c7abd1c28a63ad633433d037ee15a1bc3023ba
>> git remote add trace git://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace
>> git fetch --no-tags trace trace/urgent
>> git checkout b6c7abd1c28a63ad633433d037ee15a1bc3023ba
>> # save the config file
>> mkdir build_dir && cp config build_dir/.config
>> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sh olddefconfig
>> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sh SHELL=/bin/bash kernel/trace/
>>
>> If you fix the issue, kindly add following tag where applicable
>> | Reported-by: kernel test robot <lkp@intel.com>
>> | Link: https://lore.kernel.org/oe-kbuild-all/202302130750.679RaRog-lkp@intel.com/
>>
>> All warnings (new ones prefixed by >>):
>>
>> >> kernel/trace/trace_events.c:158:5: warning: no previous prototype for 'trace_define_field_ext' [-Wmissing-prototypes]
>> 158 | int trace_define_field_ext(struct trace_event_call *call, const char *type,
>> | ^~~~~~~~~~~~~~~~~~~~~~
>>
>
>Thanks for the report.
>Should make trace_define_field_ext static.
>I will send a fix.
No need, I already made one and it just passed my tests. I'll be sending a pull request shortly.
-- Steve
>
>>
>> vim +/trace_define_field_ext +158 kernel/trace/trace_events.c
>>
>> 157
>> > 158 int trace_define_field_ext(struct trace_event_call *call, const char *type,
>> 159 const char *name, int offset, int size, int is_signed,
>> 160 int filter_type, int len)
>> 161 {
>> 162 struct list_head *head;
>> 163
>> 164 if (WARN_ON(!call->class))
>> 165 return 0;
>> 166
>> 167 head = trace_get_fields(call);
>> 168 return __trace_define_field(head, type, name, offset, size,
>> 169 is_signed, filter_type, len);
>> 170 }
>> 171
>>
>> --
>> 0-DAY CI Kernel Test Service
>> https://github.com/intel/lkp-tests
>
>
>
--
Sent from my Android device with K-9 Mail. Please excuse my brevity and top posting.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [trace:trace/urgent 13/13] kernel/trace/trace_events.c:158:5: warning: no previous prototype for 'trace_define_field_ext'
2023-02-13 8:37 ` Steven Rostedt
@ 2023-02-13 14:18 ` Yafang Shao
0 siblings, 0 replies; 4+ messages in thread
From: Yafang Shao @ 2023-02-13 14:18 UTC (permalink / raw)
To: Steven Rostedt; +Cc: kernel test robot, oe-kbuild-all
On Mon, Feb 13, 2023 at 4:38 PM Steven Rostedt <rostedt@goodmis.org> wrote:
>
>
>
> On February 12, 2023 11:20:59 PM EST, Yafang Shao <laoar.shao@gmail.com> wrote:
> >On Mon, Feb 13, 2023 at 7:30 AM kernel test robot <lkp@intel.com> wrote:
> >>
> >> tree: git://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace trace/urgent
> >> head: b6c7abd1c28a63ad633433d037ee15a1bc3023ba
> >> commit: b6c7abd1c28a63ad633433d037ee15a1bc3023ba [13/13] tracing: Fix TASK_COMM_LEN in trace event format file
> >> config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20230213/202302130750.679RaRog-lkp@intel.com/config)
> >> compiler: sh4-linux-gcc (GCC) 12.1.0
> >> reproduce (this is a W=1 build):
> >> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> >> chmod +x ~/bin/make.cross
> >> # https://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace.git/commit/?id=b6c7abd1c28a63ad633433d037ee15a1bc3023ba
> >> git remote add trace git://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace
> >> git fetch --no-tags trace trace/urgent
> >> git checkout b6c7abd1c28a63ad633433d037ee15a1bc3023ba
> >> # save the config file
> >> mkdir build_dir && cp config build_dir/.config
> >> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sh olddefconfig
> >> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sh SHELL=/bin/bash kernel/trace/
> >>
> >> If you fix the issue, kindly add following tag where applicable
> >> | Reported-by: kernel test robot <lkp@intel.com>
> >> | Link: https://lore.kernel.org/oe-kbuild-all/202302130750.679RaRog-lkp@intel.com/
> >>
> >> All warnings (new ones prefixed by >>):
> >>
> >> >> kernel/trace/trace_events.c:158:5: warning: no previous prototype for 'trace_define_field_ext' [-Wmissing-prototypes]
> >> 158 | int trace_define_field_ext(struct trace_event_call *call, const char *type,
> >> | ^~~~~~~~~~~~~~~~~~~~~~
> >>
> >
> >Thanks for the report.
> >Should make trace_define_field_ext static.
> >I will send a fix.
>
> No need, I already made one and it just passed my tests. I'll be sending a pull request shortly.
Thanks for the work!
--
Regards
Yafang
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-02-13 14:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-12 23:30 [trace:trace/urgent 13/13] kernel/trace/trace_events.c:158:5: warning: no previous prototype for 'trace_define_field_ext' kernel test robot
2023-02-13 4:20 ` Yafang Shao
2023-02-13 8:37 ` Steven Rostedt
2023-02-13 14:18 ` Yafang Shao
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.