* [PATCH v2] firmware/efi sysfb_efi: Add quirk for Lenovo IdeaPad Duet 3
@ 2023-02-15 11:50 Darrell Kavanagh
2023-02-15 14:58 ` Hans de Goede
0 siblings, 1 reply; 3+ messages in thread
From: Darrell Kavanagh @ 2023-02-15 11:50 UTC (permalink / raw)
To: hdegoede, ardb, linux-efi, maxime; +Cc: Darrell Kavanagh
Another Lenovo convertable which reports a landscape resolution of
1920x1200 with a pitch of (1920 * 4) bytes, while the actual framebuffer
has a resolution of 1200x1920 with a pitch of (1200 * 4) bytes.
Signed-off-by: Darrell Kavanagh <darrell.kavanagh@gmail.com>
---
Changes in v2:
- Improve commit message
---
drivers/firmware/efi/sysfb_efi.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/firmware/efi/sysfb_efi.c b/drivers/firmware/efi/sysfb_efi.c
index 7882d4b3f2be..f06fdacc9bc8 100644
--- a/drivers/firmware/efi/sysfb_efi.c
+++ b/drivers/firmware/efi/sysfb_efi.c
@@ -264,6 +264,14 @@ static const struct dmi_system_id efifb_dmi_swap_width_height[] __initconst = {
"Lenovo ideapad D330-10IGM"),
},
},
+ {
+ /* Lenovo IdeaPad Duet 3 10IGL5 with 1200x1920 portrait screen */
+ .matches = {
+ DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+ DMI_EXACT_MATCH(DMI_PRODUCT_VERSION,
+ "IdeaPad Duet 3 10IGL5"),
+ },
+ },
{},
};
--
2.39.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] firmware/efi sysfb_efi: Add quirk for Lenovo IdeaPad Duet 3
2023-02-15 11:50 [PATCH v2] firmware/efi sysfb_efi: Add quirk for Lenovo IdeaPad Duet 3 Darrell Kavanagh
@ 2023-02-15 14:58 ` Hans de Goede
2023-02-17 15:32 ` Ard Biesheuvel
0 siblings, 1 reply; 3+ messages in thread
From: Hans de Goede @ 2023-02-15 14:58 UTC (permalink / raw)
To: Darrell Kavanagh, ardb, linux-efi, maxime
Hi,
On 2/15/23 12:50, Darrell Kavanagh wrote:
> Another Lenovo convertable which reports a landscape resolution of
> 1920x1200 with a pitch of (1920 * 4) bytes, while the actual framebuffer
> has a resolution of 1200x1920 with a pitch of (1200 * 4) bytes.
>
> Signed-off-by: Darrell Kavanagh <darrell.kavanagh@gmail.com>
> ---
> Changes in v2:
> - Improve commit message
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> drivers/firmware/efi/sysfb_efi.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/firmware/efi/sysfb_efi.c b/drivers/firmware/efi/sysfb_efi.c
> index 7882d4b3f2be..f06fdacc9bc8 100644
> --- a/drivers/firmware/efi/sysfb_efi.c
> +++ b/drivers/firmware/efi/sysfb_efi.c
> @@ -264,6 +264,14 @@ static const struct dmi_system_id efifb_dmi_swap_width_height[] __initconst = {
> "Lenovo ideapad D330-10IGM"),
> },
> },
> + {
> + /* Lenovo IdeaPad Duet 3 10IGL5 with 1200x1920 portrait screen */
> + .matches = {
> + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> + DMI_EXACT_MATCH(DMI_PRODUCT_VERSION,
> + "IdeaPad Duet 3 10IGL5"),
> + },
> + },
> {},
> };
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] firmware/efi sysfb_efi: Add quirk for Lenovo IdeaPad Duet 3
2023-02-15 14:58 ` Hans de Goede
@ 2023-02-17 15:32 ` Ard Biesheuvel
0 siblings, 0 replies; 3+ messages in thread
From: Ard Biesheuvel @ 2023-02-17 15:32 UTC (permalink / raw)
To: Hans de Goede; +Cc: Darrell Kavanagh, linux-efi, maxime
On Wed, 15 Feb 2023 at 15:58, Hans de Goede <hdegoede@redhat.com> wrote:
>
> Hi,
>
> On 2/15/23 12:50, Darrell Kavanagh wrote:
> > Another Lenovo convertable which reports a landscape resolution of
> > 1920x1200 with a pitch of (1920 * 4) bytes, while the actual framebuffer
> > has a resolution of 1200x1920 with a pitch of (1200 * 4) bytes.
> >
> > Signed-off-by: Darrell Kavanagh <darrell.kavanagh@gmail.com>
> > ---
> > Changes in v2:
> > - Improve commit message
>
> Thanks, patch looks good to me:
>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
>
Thanks. I've queued this up in efi/next.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-02-17 15:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-15 11:50 [PATCH v2] firmware/efi sysfb_efi: Add quirk for Lenovo IdeaPad Duet 3 Darrell Kavanagh
2023-02-15 14:58 ` Hans de Goede
2023-02-17 15:32 ` Ard Biesheuvel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.