* [Buildroot] [PATCH] package/rtl8821cu: disable package for s390x architecture @ 2023-02-14 10:50 Giulio Benetti 2023-02-14 11:18 ` yann.morin 2023-02-15 21:02 ` Thomas Petazzoni via buildroot 0 siblings, 2 replies; 5+ messages in thread From: Giulio Benetti @ 2023-02-14 10:50 UTC (permalink / raw) To: buildroot; +Cc: Giulio Benetti s390x doesn't support CONFIG_WIRELESS in Linux so let's disable this package for this architecture. Fixes: http://autobuild.buildroot.net/results/3a74d393cdbc308eab9ec3f0f9e420947669a0ea/ Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> --- package/rtl8821cu/Config.in | 2 ++ 1 file changed, 2 insertions(+) diff --git a/package/rtl8821cu/Config.in b/package/rtl8821cu/Config.in index a5a7b9d255..00a41b5196 100644 --- a/package/rtl8821cu/Config.in +++ b/package/rtl8821cu/Config.in @@ -1,8 +1,10 @@ comment "rtl8821cu needs a Linux kernel to be built" + depends on !BR2_s390x depends on !BR2_LINUX_KERNEL config BR2_PACKAGE_RTL8821CU bool "rtl8821cu" + depends on !BR2_s390x depends on BR2_LINUX_KERNEL help rtl8821cu wifi driver -- 2.34.1 _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH] package/rtl8821cu: disable package for s390x architecture 2023-02-14 10:50 [Buildroot] [PATCH] package/rtl8821cu: disable package for s390x architecture Giulio Benetti @ 2023-02-14 11:18 ` yann.morin 2023-02-14 12:16 ` Giulio Benetti 2023-02-15 21:02 ` Thomas Petazzoni via buildroot 1 sibling, 1 reply; 5+ messages in thread From: yann.morin @ 2023-02-14 11:18 UTC (permalink / raw) To: Giulio Benetti; +Cc: buildroot Giulio, All, On 2023-02-14 11:50 +0100, Giulio Benetti spake thusly: > s390x doesn't support CONFIG_WIRELESS in Linux so let's disable this > package for this architecture. Instead of fixing each and every rtlXXXX packages one by one when there is an autobuild failure, can we just exclude them in bulk, since they are all wireless drivers, and thus will never be available for s390x? Regards, Yann E. MORIN. > Fixes: > http://autobuild.buildroot.net/results/3a74d393cdbc308eab9ec3f0f9e420947669a0ea/ > > Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> > --- > package/rtl8821cu/Config.in | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/package/rtl8821cu/Config.in b/package/rtl8821cu/Config.in > index a5a7b9d255..00a41b5196 100644 > --- a/package/rtl8821cu/Config.in > +++ b/package/rtl8821cu/Config.in > @@ -1,8 +1,10 @@ > comment "rtl8821cu needs a Linux kernel to be built" > + depends on !BR2_s390x > depends on !BR2_LINUX_KERNEL > > config BR2_PACKAGE_RTL8821CU > bool "rtl8821cu" > + depends on !BR2_s390x > depends on BR2_LINUX_KERNEL > help > rtl8821cu wifi driver > -- > 2.34.1 > > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot -- ____________ .-----------------.--------------------: _ :------------------. | Yann E. MORIN | Real-Time Embedded | __/ ) | /"\ ASCII RIBBON | | | Software Designer | _/ - /' | \ / CAMPAIGN | | +33 638.411.245 '--------------------: (_ `--, | X AGAINST | | yann.morin (at) orange.com |_=" ,--' | / \ HTML MAIL | '--------------------------------------:______/_____:------------------' _________________________________________________________________________________________________________________________ Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration, Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci. This message and its attachments may contain confidential or privileged information that may be protected by law; they should not be distributed, used or copied without authorisation. If you have received this email in error, please notify the sender and delete this message and its attachments. As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified. Thank you. _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH] package/rtl8821cu: disable package for s390x architecture 2023-02-14 11:18 ` yann.morin @ 2023-02-14 12:16 ` Giulio Benetti 2023-02-14 13:15 ` yann.morin 0 siblings, 1 reply; 5+ messages in thread From: Giulio Benetti @ 2023-02-14 12:16 UTC (permalink / raw) To: yann.morin; +Cc: buildroot Hi Yann, On 14/02/23 12:18, yann.morin@orange.com wrote: > Giulio, All, > > On 2023-02-14 11:50 +0100, Giulio Benetti spake thusly: >> s390x doesn't support CONFIG_WIRELESS in Linux so let's disable this >> package for this architecture. > > Instead of fixing each and every rtlXXXX packages one by one when there > is an autobuild failure, can we just exclude them in bulk, since they > are all wireless drivers, and thus will never be available for s390x? something like this[0] seems to work, what about it? Of course I need to clean up all the packages that depends on !BR2_s390x but the idea works for me, at least I've tested on my side and it does. If you say it's ok I clean up, check better for other Wireless Drivers, create a good patch and send it while rejecting this one. [0]: https://patchwork.ozlabs.org/project/buildroot/patch/20230214120808.1282621-1-giulio.benetti@benettiengineering.com/ -- Giulio Benetti CEO/CTO@Benetti Engineering sas > Regards, > Yann E. MORIN. > >> Fixes: >> http://autobuild.buildroot.net/results/3a74d393cdbc308eab9ec3f0f9e420947669a0ea/ >> >> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> >> --- >> package/rtl8821cu/Config.in | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/package/rtl8821cu/Config.in b/package/rtl8821cu/Config.in >> index a5a7b9d255..00a41b5196 100644 >> --- a/package/rtl8821cu/Config.in >> +++ b/package/rtl8821cu/Config.in >> @@ -1,8 +1,10 @@ >> comment "rtl8821cu needs a Linux kernel to be built" >> + depends on !BR2_s390x >> depends on !BR2_LINUX_KERNEL >> >> config BR2_PACKAGE_RTL8821CU >> bool "rtl8821cu" >> + depends on !BR2_s390x >> depends on BR2_LINUX_KERNEL >> help >> rtl8821cu wifi driver >> -- >> 2.34.1 >> >> _______________________________________________ >> buildroot mailing list >> buildroot@buildroot.org >> https://lists.buildroot.org/mailman/listinfo/buildroot > _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH] package/rtl8821cu: disable package for s390x architecture 2023-02-14 12:16 ` Giulio Benetti @ 2023-02-14 13:15 ` yann.morin 0 siblings, 0 replies; 5+ messages in thread From: yann.morin @ 2023-02-14 13:15 UTC (permalink / raw) To: Giulio Benetti; +Cc: buildroot Giulio, All, On 2023-02-14 13:16 +0100, Giulio Benetti spake thusly: > On 14/02/23 12:18, yann.morin@orange.com wrote: > >On 2023-02-14 11:50 +0100, Giulio Benetti spake thusly: > >>s390x doesn't support CONFIG_WIRELESS in Linux so let's disable this > >>package for this architecture. > >Instead of fixing each and every rtlXXXX packages one by one when there > >is an autobuild failure, can we just exclude them in bulk, since they > >are all wireless drivers, and thus will never be available for s390x? > something like this[0] seems to work, what about it? > > Of course I need to clean up all the packages that depends on !BR2_s390x > but the idea works for me, at least I've tested on my side and it does. > > If you say it's ok I clean up, check better for other Wireless Drivers, > create a good patch and send it while rejecting this one. > > [0]: https://patchwork.ozlabs.org/project/buildroot/patch/20230214120808.1282621-1-giulio.benetti@benettiengineering.com/ That's not really what I meant... I was mostly thinking of sending a patch series that would add the !s390x dependency to all remaining wifi drivers without waiting for them to fail in an autobuilder... However, moving them all inside a common sub-menu that is itself guarded by !s390x sounds OK. At least, when we add a new wireless driver, we'd know where to add it, and we would not have to care about forgetting the !s390x dependency... (but note that, with this email, I'm no maintainer; let's see what the maintainers think). Regards, Yann E. MORIN. -- ____________ .-----------------.--------------------: _ :------------------. | Yann E. MORIN | Real-Time Embedded | __/ ) | /"\ ASCII RIBBON | | | Software Designer | _/ - /' | \ / CAMPAIGN | | +33 638.411.245 '--------------------: (_ `--, | X AGAINST | | yann.morin (at) orange.com |_=" ,--' | / \ HTML MAIL | '--------------------------------------:______/_____:------------------' _________________________________________________________________________________________________________________________ Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration, Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci. This message and its attachments may contain confidential or privileged information that may be protected by law; they should not be distributed, used or copied without authorisation. If you have received this email in error, please notify the sender and delete this message and its attachments. As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified. Thank you. _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH] package/rtl8821cu: disable package for s390x architecture 2023-02-14 10:50 [Buildroot] [PATCH] package/rtl8821cu: disable package for s390x architecture Giulio Benetti 2023-02-14 11:18 ` yann.morin @ 2023-02-15 21:02 ` Thomas Petazzoni via buildroot 1 sibling, 0 replies; 5+ messages in thread From: Thomas Petazzoni via buildroot @ 2023-02-15 21:02 UTC (permalink / raw) To: Giulio Benetti; +Cc: Yann E. MORIN, buildroot On Tue, 14 Feb 2023 11:50:33 +0100 Giulio Benetti <giulio.benetti@benettiengineering.com> wrote: > s390x doesn't support CONFIG_WIRELESS in Linux so let's disable this > package for this architecture. > > Fixes: > http://autobuild.buildroot.net/results/3a74d393cdbc308eab9ec3f0f9e420947669a0ea/ > > Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> > --- > package/rtl8821cu/Config.in | 2 ++ > 1 file changed, 2 insertions(+) Applied to master, thanks. Note: I have seen the discussion that Yann started, and I replied on your other patch proposal. For now I have applied this patch as-is because it fixes an autobuilder issue: it is the most obvious/immediate fix we have. Best regards, Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-02-15 21:03 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-02-14 10:50 [Buildroot] [PATCH] package/rtl8821cu: disable package for s390x architecture Giulio Benetti 2023-02-14 11:18 ` yann.morin 2023-02-14 12:16 ` Giulio Benetti 2023-02-14 13:15 ` yann.morin 2023-02-15 21:02 ` Thomas Petazzoni via buildroot
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.