* [Buildroot] [PATCH] package/flannel: use the github helper
@ 2023-02-13 20:06 Yann E. MORIN
2023-02-14 1:32 ` Geoff Levand
2023-02-15 21:38 ` Thomas Petazzoni via buildroot
0 siblings, 2 replies; 3+ messages in thread
From: Yann E. MORIN @ 2023-02-13 20:06 UTC (permalink / raw)
To: buildroot; +Cc: Geoff Levand, Yann E. MORIN
Currently, flannel uses an ad-hoc github URL and a version-only tarball
name, even though we already had the github helper (introduced in 2013)
when flannel was introduced (in 2016).
Switch to the github helper, which allows us to get a properly named
tarball.
Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
Cc: Geoff Levand <geoff@infradead.org>
---
package/flannel/flannel.hash | 2 +-
package/flannel/flannel.mk | 3 +--
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/package/flannel/flannel.hash b/package/flannel/flannel.hash
index 6a0223a20f..bafc453097 100644
--- a/package/flannel/flannel.hash
+++ b/package/flannel/flannel.hash
@@ -1,3 +1,3 @@
# Locally computed:
-sha256 e17164db3b158d13ce5e40bb7b233790cb186762d929fa4f626baf586d4d63ca v0.14.0.tar.gz
+sha256 e17164db3b158d13ce5e40bb7b233790cb186762d929fa4f626baf586d4d63ca flannel-0.14.0.tar.gz
sha256 cfc7749b96f63bd31c3c42b5c471bf756814053e847c10f3eb003417bc523d30 LICENSE
diff --git a/package/flannel/flannel.mk b/package/flannel/flannel.mk
index 231cf90dfd..b4e2b2f777 100644
--- a/package/flannel/flannel.mk
+++ b/package/flannel/flannel.mk
@@ -5,8 +5,7 @@
################################################################################
FLANNEL_VERSION = 0.14.0
-FLANNEL_SITE = https://github.com/flannel-io/flannel/archive
-FLANNEL_SOURCE = v$(FLANNEL_VERSION).tar.gz
+FLANNEL_SITE = $(call github,flannel-io,flannel,v$(FLANNEL_VERSION))
FLANNEL_LICENSE = Apache-2.0
FLANNEL_LICENSE_FILES = LICENSE
--
2.25.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH] package/flannel: use the github helper
2023-02-13 20:06 [Buildroot] [PATCH] package/flannel: use the github helper Yann E. MORIN
@ 2023-02-14 1:32 ` Geoff Levand
2023-02-15 21:38 ` Thomas Petazzoni via buildroot
1 sibling, 0 replies; 3+ messages in thread
From: Geoff Levand @ 2023-02-14 1:32 UTC (permalink / raw)
To: Yann E. MORIN, buildroot
On 2/13/23 12:06, Yann E. MORIN wrote:
> Currently, flannel uses an ad-hoc github URL and a version-only tarball
> name, even though we already had the github helper (introduced in 2013)
> when flannel was introduced (in 2016).
>
> Switch to the github helper, which allows us to get a properly named
> tarball.
>
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> Cc: Geoff Levand <geoff@infradead.org>
> ---
> package/flannel/flannel.hash | 2 +-
> package/flannel/flannel.mk | 3 +--
> 2 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/package/flannel/flannel.hash b/package/flannel/flannel.hash
> index 6a0223a20f..bafc453097 100644
> --- a/package/flannel/flannel.hash
> +++ b/package/flannel/flannel.hash
> @@ -1,3 +1,3 @@
> # Locally computed:
> -sha256 e17164db3b158d13ce5e40bb7b233790cb186762d929fa4f626baf586d4d63ca v0.14.0.tar.gz
> +sha256 e17164db3b158d13ce5e40bb7b233790cb186762d929fa4f626baf586d4d63ca flannel-0.14.0.tar.gz
> sha256 cfc7749b96f63bd31c3c42b5c471bf756814053e847c10f3eb003417bc523d30 LICENSE
> diff --git a/package/flannel/flannel.mk b/package/flannel/flannel.mk
> index 231cf90dfd..b4e2b2f777 100644
> --- a/package/flannel/flannel.mk
> +++ b/package/flannel/flannel.mk
> @@ -5,8 +5,7 @@
> ################################################################################
>
> FLANNEL_VERSION = 0.14.0
> -FLANNEL_SITE = https://github.com/flannel-io/flannel/archive
> -FLANNEL_SOURCE = v$(FLANNEL_VERSION).tar.gz
> +FLANNEL_SITE = $(call github,flannel-io,flannel,v$(FLANNEL_VERSION))
>
> FLANNEL_LICENSE = Apache-2.0
> FLANNEL_LICENSE_FILES = LICENSE
Looks good. Thanks for working it out.
Acked-by: Geoff Levand <geoff@infradead.org>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH] package/flannel: use the github helper
2023-02-13 20:06 [Buildroot] [PATCH] package/flannel: use the github helper Yann E. MORIN
2023-02-14 1:32 ` Geoff Levand
@ 2023-02-15 21:38 ` Thomas Petazzoni via buildroot
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni via buildroot @ 2023-02-15 21:38 UTC (permalink / raw)
To: Yann E. MORIN; +Cc: Geoff Levand, buildroot
On Mon, 13 Feb 2023 21:06:04 +0100
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> Currently, flannel uses an ad-hoc github URL and a version-only tarball
> name, even though we already had the github helper (introduced in 2013)
> when flannel was introduced (in 2016).
>
> Switch to the github helper, which allows us to get a properly named
> tarball.
>
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> Cc: Geoff Levand <geoff@infradead.org>
> ---
> package/flannel/flannel.hash | 2 +-
> package/flannel/flannel.mk | 3 +--
> 2 files changed, 2 insertions(+), 3 deletions(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-02-15 21:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-13 20:06 [Buildroot] [PATCH] package/flannel: use the github helper Yann E. MORIN
2023-02-14 1:32 ` Geoff Levand
2023-02-15 21:38 ` Thomas Petazzoni via buildroot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.