All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
To: dri-devel@lists.freedesktop.org
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Christian Koenig <christian.koenig@amd.com>,
	Dave Airlie <airlied@redhat.com>,
	intel-xe@lists.freedesktop.org
Subject: [Intel-xe] [PATCH 0/3] drm, drm/amd, drm/radeon: Introduce a generic suballocator
Date: Thu, 16 Feb 2023 15:48:44 +0100	[thread overview]
Message-ID: <20230216144847.216259-1-thomas.hellstrom@linux.intel.com> (raw)


This series (or at least the suballocator helper) is a prerequisite
for the new Xe driver.

A variant of the series has been on review before, making the
suballocator used by the amdgpu driver the generic one. However we
ran into a number of issues on Xe when using it for context-less
allocations, hence the comlplete rewrite with simplification in
mind. More specifics in the patch commit message and in the code.

There was an unresolved issue when the series was last up for review,
and that was the per allocation aligment. Last message was from
Maarten Lankhorst arguing that the larger per-driver alignment used
would only incur a small memory cost. It would be good to have that
resolved.

The generic suballocator has been extensively tested with the Xe driver.
The amd- and radeon adaptations are only compile-tested.


Maarten Lankhorst (2):
  drm/amd: Convert amdgpu to use suballocation helper.
  drm/radeon: Use the drm suballocation manager implementation.

Thomas Hellström (1):
  drm/suballoc: Introduce a generic suballocation manager

 drivers/gpu/drm/Kconfig                    |   5 +
 drivers/gpu/drm/Makefile                   |   3 +
 drivers/gpu/drm/amd/amdgpu/Kconfig         |   1 +
 drivers/gpu/drm/amd/amdgpu/amdgpu.h        |  26 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c     |   5 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_object.h |  23 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h   |   3 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_sa.c     | 320 ++-------------------
 drivers/gpu/drm/drm_suballoc.c             | 301 +++++++++++++++++++
 drivers/gpu/drm/radeon/radeon.h            |  55 +---
 drivers/gpu/drm/radeon/radeon_ib.c         |  12 +-
 drivers/gpu/drm/radeon/radeon_object.h     |  25 +-
 drivers/gpu/drm/radeon/radeon_sa.c         | 314 ++------------------
 drivers/gpu/drm/radeon/radeon_semaphore.c  |   6 +-
 include/drm/drm_suballoc.h                 | 112 ++++++++
 15 files changed, 518 insertions(+), 693 deletions(-)
 create mode 100644 drivers/gpu/drm/drm_suballoc.c
 create mode 100644 include/drm/drm_suballoc.h

-- 
2.34.1


WARNING: multiple messages have this Message-ID (diff)
From: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
To: dri-devel@lists.freedesktop.org
Cc: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
	"Daniel Vetter" <daniel.vetter@ffwll.ch>,
	"Christian Koenig" <christian.koenig@amd.com>,
	"Dave Airlie" <airlied@redhat.com>,
	intel-xe@lists.freedesktop.org
Subject: [PATCH 0/3] drm, drm/amd, drm/radeon: Introduce a generic suballocator
Date: Thu, 16 Feb 2023 15:48:44 +0100	[thread overview]
Message-ID: <20230216144847.216259-1-thomas.hellstrom@linux.intel.com> (raw)


This series (or at least the suballocator helper) is a prerequisite
for the new Xe driver.

A variant of the series has been on review before, making the
suballocator used by the amdgpu driver the generic one. However we
ran into a number of issues on Xe when using it for context-less
allocations, hence the comlplete rewrite with simplification in
mind. More specifics in the patch commit message and in the code.

There was an unresolved issue when the series was last up for review,
and that was the per allocation aligment. Last message was from
Maarten Lankhorst arguing that the larger per-driver alignment used
would only incur a small memory cost. It would be good to have that
resolved.

The generic suballocator has been extensively tested with the Xe driver.
The amd- and radeon adaptations are only compile-tested.


Maarten Lankhorst (2):
  drm/amd: Convert amdgpu to use suballocation helper.
  drm/radeon: Use the drm suballocation manager implementation.

Thomas Hellström (1):
  drm/suballoc: Introduce a generic suballocation manager

 drivers/gpu/drm/Kconfig                    |   5 +
 drivers/gpu/drm/Makefile                   |   3 +
 drivers/gpu/drm/amd/amdgpu/Kconfig         |   1 +
 drivers/gpu/drm/amd/amdgpu/amdgpu.h        |  26 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c     |   5 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_object.h |  23 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h   |   3 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_sa.c     | 320 ++-------------------
 drivers/gpu/drm/drm_suballoc.c             | 301 +++++++++++++++++++
 drivers/gpu/drm/radeon/radeon.h            |  55 +---
 drivers/gpu/drm/radeon/radeon_ib.c         |  12 +-
 drivers/gpu/drm/radeon/radeon_object.h     |  25 +-
 drivers/gpu/drm/radeon/radeon_sa.c         | 314 ++------------------
 drivers/gpu/drm/radeon/radeon_semaphore.c  |   6 +-
 include/drm/drm_suballoc.h                 | 112 ++++++++
 15 files changed, 518 insertions(+), 693 deletions(-)
 create mode 100644 drivers/gpu/drm/drm_suballoc.c
 create mode 100644 include/drm/drm_suballoc.h

-- 
2.34.1


             reply	other threads:[~2023-02-16 14:49 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-16 14:48 Thomas Hellström [this message]
2023-02-16 14:48 ` [PATCH 0/3] drm, drm/amd, drm/radeon: Introduce a generic suballocator Thomas Hellström
2023-02-16 14:48 ` [Intel-xe] [PATCH 1/3] drm/suballoc: Introduce a generic suballocation manager Thomas Hellström
2023-02-16 14:48   ` Thomas Hellström
2023-02-17 11:00   ` [Intel-xe] " Christian König
2023-02-17 11:00     ` Christian König
2023-02-17 11:21     ` [Intel-xe] " Thomas Hellström
2023-02-17 11:21       ` Thomas Hellström
2023-02-17 11:28       ` [Intel-xe] " Christian König
2023-02-17 11:28         ` Christian König
2023-02-17 12:24         ` [Intel-xe] " Thomas Hellström
2023-02-17 12:24           ` Thomas Hellström
2023-02-17 12:28           ` [Intel-xe] " Christian König
2023-02-17 12:28             ` Christian König
2023-02-17 13:10             ` [Intel-xe] " Thomas Hellström
2023-02-17 13:10               ` Thomas Hellström
2023-02-17 13:18               ` [Intel-xe] " Christian König
2023-02-17 13:18                 ` Christian König
2023-02-17 13:51                 ` [Intel-xe] " Thomas Hellström
2023-02-17 13:51                   ` Thomas Hellström
2023-02-22 11:00                   ` [Intel-xe] " Thomas Hellström
2023-02-22 11:00                     ` Thomas Hellström
2023-02-22 11:39                     ` Christian König
2023-02-22 11:39                       ` Christian König
2023-02-22 13:54                       ` Thomas Hellström
2023-02-22 13:54                         ` Thomas Hellström
2023-02-22 14:20                         ` Christian König
2023-02-22 14:20                           ` Christian König
2023-02-22 15:58                           ` Thomas Hellström
2023-02-22 15:58                             ` Thomas Hellström
2023-02-16 14:48 ` [Intel-xe] [PATCH 2/3] drm/amd: Convert amdgpu to use suballocation helper Thomas Hellström
2023-02-16 14:48   ` Thomas Hellström
2023-02-16 14:48 ` [Intel-xe] [PATCH 3/3] drm/radeon: Use the drm suballocation manager implementation Thomas Hellström
2023-02-16 14:48   ` Thomas Hellström
2023-02-17  1:52   ` kernel test robot
2023-02-17 12:32   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230216144847.216259-1-thomas.hellstrom@linux.intel.com \
    --to=thomas.hellstrom@linux.intel.com \
    --cc=airlied@redhat.com \
    --cc=christian.koenig@amd.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=maarten.lankhorst@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.