From: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: ogabbay@kernel.org, Abaci Robot <abaci@linux.alibaba.com>,
osharabi@habana.ai, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] habanalabs: make some functions static
Date: Fri, 17 Feb 2023 09:48:14 +0100 [thread overview]
Message-ID: <20230217084814.GA2862577@linux.intel.com> (raw)
In-Reply-To: <20230217062626.63213-1-jiapeng.chong@linux.alibaba.com>
On Fri, Feb 17, 2023 at 02:26:26PM +0800, Jiapeng Chong wrote:
> These functions are not used outside the file device.c, so the
> modification is defined as static.
>
> drivers/accel/habanalabs/common/device.c:2641:6: warning: no previous prototype for ‘hl_capture_fw_err’.
> drivers/accel/habanalabs/common/device.c:2619:6: warning: no previous prototype for ‘hl_capture_hw_err’.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4098
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Regards
Stanislaw
WARNING: multiple messages have this Message-ID (diff)
From: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: ogabbay@kernel.org, osharabi@habana.ai,
Abaci Robot <abaci@linux.alibaba.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] habanalabs: make some functions static
Date: Fri, 17 Feb 2023 09:48:14 +0100 [thread overview]
Message-ID: <20230217084814.GA2862577@linux.intel.com> (raw)
In-Reply-To: <20230217062626.63213-1-jiapeng.chong@linux.alibaba.com>
On Fri, Feb 17, 2023 at 02:26:26PM +0800, Jiapeng Chong wrote:
> These functions are not used outside the file device.c, so the
> modification is defined as static.
>
> drivers/accel/habanalabs/common/device.c:2641:6: warning: no previous prototype for ‘hl_capture_fw_err’.
> drivers/accel/habanalabs/common/device.c:2619:6: warning: no previous prototype for ‘hl_capture_hw_err’.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4098
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Regards
Stanislaw
next prev parent reply other threads:[~2023-02-17 8:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-17 6:26 [PATCH] habanalabs: make some functions static Jiapeng Chong
2023-02-17 6:26 ` Jiapeng Chong
2023-02-17 8:48 ` Stanislaw Gruszka [this message]
2023-02-17 8:48 ` Stanislaw Gruszka
2023-02-17 9:13 ` Stanislaw Gruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230217084814.GA2862577@linux.intel.com \
--to=stanislaw.gruszka@linux.intel.com \
--cc=abaci@linux.alibaba.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ogabbay@kernel.org \
--cc=osharabi@habana.ai \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.