All of lore.kernel.org
 help / color / mirror / Atom feed
From: Uday Shankar <ushankar@purestorage.com>
To: Mike Snitzer <snitzer@kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>,
	Jens Axboe <axboe@kernel.dk>,
	dm-devel@redhat.com, linux-block@vger.kernel.org,
	Alasdair Kergon <agk@redhat.com>
Subject: Re: [dm-devel] blk-mq: enforce op-specific segment limits in blk_insert_cloned_request
Date: Fri, 17 Feb 2023 14:41:52 -0700	[thread overview]
Message-ID: <20230217214152.GA1124853@dev-ushankar.dev.purestorage.com> (raw)
In-Reply-To: <Y++utrkJXuUsD0K4@redhat.com>

> Much easier to address a bug in a driver when seeing this message than
> figuring it out after more elaborate hunting. Not seeing the downside
> of preserving/fixing given it is a quick limit check. *shrug*

I tend to agree - considering the check has been here for a while, I
don't know if lower levels will have particularly enlightening logging
(if any at all) for these errors.

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel


WARNING: multiple messages have this Message-ID (diff)
From: Uday Shankar <ushankar@purestorage.com>
To: Mike Snitzer <snitzer@kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>,
	Jens Axboe <axboe@kernel.dk>, Alasdair Kergon <agk@redhat.com>,
	linux-block@vger.kernel.org, dm-devel@redhat.com
Subject: Re: blk-mq: enforce op-specific segment limits in blk_insert_cloned_request
Date: Fri, 17 Feb 2023 14:41:52 -0700	[thread overview]
Message-ID: <20230217214152.GA1124853@dev-ushankar.dev.purestorage.com> (raw)
In-Reply-To: <Y++utrkJXuUsD0K4@redhat.com>

> Much easier to address a bug in a driver when seeing this message than
> figuring it out after more elaborate hunting. Not seeing the downside
> of preserving/fixing given it is a quick limit check. *shrug*

I tend to agree - considering the check has been here for a while, I
don't know if lower levels will have particularly enlightening logging
(if any at all) for these errors.

  reply	other threads:[~2023-02-17 21:42 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-15 20:15 [dm-devel] [PATCH] blk-mq: enforce op-specific segment limits in blk_insert_cloned_request Uday Shankar
2023-02-15 20:15 ` Uday Shankar
2023-02-16  6:09 ` [dm-devel] " Christoph Hellwig
2023-02-16  6:09   ` Christoph Hellwig
2023-02-16 19:27   ` [dm-devel] " Uday Shankar
2023-02-16 19:27     ` Uday Shankar
2023-02-17  0:13     ` [dm-devel] " Mike Snitzer
2023-02-17  0:13       ` Mike Snitzer
2023-02-17 16:16     ` [dm-devel] [PATCH] " Christoph Hellwig
2023-02-17 16:16       ` Christoph Hellwig
2023-02-17 16:43       ` [dm-devel] " Mike Snitzer
2023-02-17 16:43         ` Mike Snitzer
2023-02-17 21:41         ` Uday Shankar [this message]
2023-02-17 21:41           ` Uday Shankar
2023-02-16 13:06 ` [dm-devel] [PATCH] " kernel test robot
2023-02-16 13:06   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230217214152.GA1124853@dev-ushankar.dev.purestorage.com \
    --to=ushankar@purestorage.com \
    --cc=agk@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=dm-devel@redhat.com \
    --cc=hch@infradead.org \
    --cc=linux-block@vger.kernel.org \
    --cc=snitzer@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.