* [PATCH 1/2] dt-bindings usb: typec: rt1711h: Use a generic node name
@ 2023-02-16 12:12 Konrad Dybcio
2023-02-16 12:12 ` Konrad Dybcio
2023-02-21 2:01 ` [PATCH 1/2] dt-bindings usb: typec: rt1711h: Use a generic node name Rob Herring
0 siblings, 2 replies; 4+ messages in thread
From: Konrad Dybcio @ 2023-02-16 12:12 UTC (permalink / raw)
To: linux-arm-msm, andersson, agross
Cc: marijn.suijten, Konrad Dybcio, Greg Kroah-Hartman, Rob Herring,
Krzysztof Kozlowski, Gene Chen, linux-usb, devicetree,
linux-kernel
Node names should be generic. Use typec-portc@ instead of rt1711h@.
Fixes: a72095ed8e65 ("dt-bindings usb: typec: rt1711h: Add binding for Richtek RT1711H")
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
Documentation/devicetree/bindings/usb/richtek,rt1711h.yaml | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/usb/richtek,rt1711h.yaml b/Documentation/devicetree/bindings/usb/richtek,rt1711h.yaml
index 1999f614c89b..7431c25d82ce 100644
--- a/Documentation/devicetree/bindings/usb/richtek,rt1711h.yaml
+++ b/Documentation/devicetree/bindings/usb/richtek,rt1711h.yaml
@@ -17,6 +17,9 @@ description: |
support for alternative interfaces of the Type-C specification.
properties:
+ $nodename:
+ pattern: "^typec-portc@[0-9a-f]+$"
+
compatible:
enum:
- richtek,rt1711h
@@ -55,7 +58,7 @@ examples:
#address-cells = <1>;
#size-cells = <0>;
- rt1711h@4e {
+ typec-portc@4e {
compatible = "richtek,rt1711h";
reg = <0x4e>;
interrupts-extended = <&gpio26 3 IRQ_TYPE_LEVEL_LOW>;
--
2.39.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/2] arm64: dts: hisilicon: hikey960: Use generic node name for rt1711h
2023-02-16 12:12 [PATCH 1/2] dt-bindings usb: typec: rt1711h: Use a generic node name Konrad Dybcio
@ 2023-02-16 12:12 ` Konrad Dybcio
2023-02-21 2:01 ` [PATCH 1/2] dt-bindings usb: typec: rt1711h: Use a generic node name Rob Herring
1 sibling, 0 replies; 4+ messages in thread
From: Konrad Dybcio @ 2023-02-16 12:12 UTC (permalink / raw)
To: linux-arm-msm, andersson, agross
Cc: marijn.suijten, Konrad Dybcio, Greg Kroah-Hartman, Rob Herring,
Krzysztof Kozlowski, Gene Chen, linux-usb, devicetree,
linux-kernel, Wei Xu, linux-arm-kernel
Align the name with what schema expects.
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
index 3f13a960f34e..98a87ba4d70f 100644
--- a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
+++ b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
@@ -527,7 +527,7 @@ &i2c0 {
&i2c1 {
status = "okay";
- rt1711h: rt1711h@4e {
+ rt1711h: typec-portc@4e {
compatible = "richtek,rt1711h";
reg = <0x4e>;
status = "okay";
--
2.39.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/2] arm64: dts: hisilicon: hikey960: Use generic node name for rt1711h
@ 2023-02-16 12:12 ` Konrad Dybcio
0 siblings, 0 replies; 4+ messages in thread
From: Konrad Dybcio @ 2023-02-16 12:12 UTC (permalink / raw)
To: linux-arm-msm, andersson, agross
Cc: marijn.suijten, Konrad Dybcio, Greg Kroah-Hartman, Rob Herring,
Krzysztof Kozlowski, Gene Chen, linux-usb, devicetree,
linux-kernel, Wei Xu, linux-arm-kernel
Align the name with what schema expects.
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
index 3f13a960f34e..98a87ba4d70f 100644
--- a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
+++ b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
@@ -527,7 +527,7 @@ &i2c0 {
&i2c1 {
status = "okay";
- rt1711h: rt1711h@4e {
+ rt1711h: typec-portc@4e {
compatible = "richtek,rt1711h";
reg = <0x4e>;
status = "okay";
--
2.39.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] dt-bindings usb: typec: rt1711h: Use a generic node name
2023-02-16 12:12 [PATCH 1/2] dt-bindings usb: typec: rt1711h: Use a generic node name Konrad Dybcio
2023-02-16 12:12 ` Konrad Dybcio
@ 2023-02-21 2:01 ` Rob Herring
1 sibling, 0 replies; 4+ messages in thread
From: Rob Herring @ 2023-02-21 2:01 UTC (permalink / raw)
To: Konrad Dybcio
Cc: linux-arm-msm, andersson, agross, marijn.suijten,
Greg Kroah-Hartman, Krzysztof Kozlowski, Gene Chen, linux-usb,
devicetree, linux-kernel
On Thu, Feb 16, 2023 at 01:12:10PM +0100, Konrad Dybcio wrote:
> Node names should be generic. Use typec-portc@ instead of rt1711h@.
What's generic? Others use just 'typec' IIRC. We must first define the
generic name for everyone, then do this. It doesn't really work defining
this in each binding either as there's no checking a generic name is in
fact used. We either need a class type schema (which don't work when
devices support multiple classes) or a meta-schema checking $nodename
patterns match a set of known node names.
>
> Fixes: a72095ed8e65 ("dt-bindings usb: typec: rt1711h: Add binding for Richtek RT1711H")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
> Documentation/devicetree/bindings/usb/richtek,rt1711h.yaml | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/usb/richtek,rt1711h.yaml b/Documentation/devicetree/bindings/usb/richtek,rt1711h.yaml
> index 1999f614c89b..7431c25d82ce 100644
> --- a/Documentation/devicetree/bindings/usb/richtek,rt1711h.yaml
> +++ b/Documentation/devicetree/bindings/usb/richtek,rt1711h.yaml
> @@ -17,6 +17,9 @@ description: |
> support for alternative interfaces of the Type-C specification.
>
> properties:
> + $nodename:
> + pattern: "^typec-portc@[0-9a-f]+$"
> +
> compatible:
> enum:
> - richtek,rt1711h
> @@ -55,7 +58,7 @@ examples:
> #address-cells = <1>;
> #size-cells = <0>;
>
> - rt1711h@4e {
> + typec-portc@4e {
> compatible = "richtek,rt1711h";
> reg = <0x4e>;
> interrupts-extended = <&gpio26 3 IRQ_TYPE_LEVEL_LOW>;
> --
> 2.39.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-02-21 2:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-16 12:12 [PATCH 1/2] dt-bindings usb: typec: rt1711h: Use a generic node name Konrad Dybcio
2023-02-16 12:12 ` [PATCH 2/2] arm64: dts: hisilicon: hikey960: Use generic node name for rt1711h Konrad Dybcio
2023-02-16 12:12 ` Konrad Dybcio
2023-02-21 2:01 ` [PATCH 1/2] dt-bindings usb: typec: rt1711h: Use a generic node name Rob Herring
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.