From: Christoph Hellwig <hch@lst.de>
To: Jiaxun Yang <jiaxun.yang@flygoat.com>
Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, tsbogend@alpha.franken.de,
mpe@ellerman.id.au, paul.walmsley@sifive.com, palmer@dabbelt.com,
robh+dt@kernel.org, hch@lst.de, m.szyprowski@samsung.com,
robin.murphy@arm.com
Subject: Re: [PATCH 1/7] MIPS: Remove DMA_PERDEV_COHERENT
Date: Tue, 21 Feb 2023 18:56:28 +0100 [thread overview]
Message-ID: <20230221175628.GB15247@lst.de> (raw)
In-Reply-To: <20230221124613.2859-2-jiaxun.yang@flygoat.com>
On Tue, Feb 21, 2023 at 12:46:07PM +0000, Jiaxun Yang wrote:
> As now we are always managing DMA coherence on per dev bias,
> there is no need to have such option. And it's not selected
> by any platform.
I think the real point here is that this is dead code, so it can
obviously go away, but:
> config MIPS_GENERIC_KERNEL
> bool "Generic board-agnostic MIPS kernel"
> - select ARCH_HAS_SETUP_DMA_OPS
> select MIPS_GENERIC
> select BOOT_RAW
> select BUILTIN_DTB
> @@ -1079,11 +1078,6 @@ config FW_CFE
> config ARCH_SUPPORTS_UPROBES
> bool
> @@ -1097,6 +1091,7 @@ config DMA_NONCOHERENT
> select ARCH_HAS_DMA_PREP_COHERENT
> select ARCH_HAS_SYNC_DMA_FOR_DEVICE
> select ARCH_HAS_DMA_SET_UNCACHED
> + select ARCH_HAS_SETUP_DMA_OPS
This is an unrelated und undocument change. If you want to do it,
please do that as a separate patch with a commit log documenting
the rationale.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Jiaxun Yang <jiaxun.yang@flygoat.com>
Cc: tsbogend@alpha.franken.de, linux-mips@vger.kernel.org,
linux-kernel@vger.kernel.org, robh+dt@kernel.org,
palmer@dabbelt.com, paul.walmsley@sifive.com,
robin.murphy@arm.com, linuxppc-dev@lists.ozlabs.org, hch@lst.de,
m.szyprowski@samsung.com
Subject: Re: [PATCH 1/7] MIPS: Remove DMA_PERDEV_COHERENT
Date: Tue, 21 Feb 2023 18:56:28 +0100 [thread overview]
Message-ID: <20230221175628.GB15247@lst.de> (raw)
In-Reply-To: <20230221124613.2859-2-jiaxun.yang@flygoat.com>
On Tue, Feb 21, 2023 at 12:46:07PM +0000, Jiaxun Yang wrote:
> As now we are always managing DMA coherence on per dev bias,
> there is no need to have such option. And it's not selected
> by any platform.
I think the real point here is that this is dead code, so it can
obviously go away, but:
> config MIPS_GENERIC_KERNEL
> bool "Generic board-agnostic MIPS kernel"
> - select ARCH_HAS_SETUP_DMA_OPS
> select MIPS_GENERIC
> select BOOT_RAW
> select BUILTIN_DTB
> @@ -1079,11 +1078,6 @@ config FW_CFE
> config ARCH_SUPPORTS_UPROBES
> bool
> @@ -1097,6 +1091,7 @@ config DMA_NONCOHERENT
> select ARCH_HAS_DMA_PREP_COHERENT
> select ARCH_HAS_SYNC_DMA_FOR_DEVICE
> select ARCH_HAS_DMA_SET_UNCACHED
> + select ARCH_HAS_SETUP_DMA_OPS
This is an unrelated und undocument change. If you want to do it,
please do that as a separate patch with a commit log documenting
the rationale.
next prev parent reply other threads:[~2023-02-21 17:57 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-21 12:46 [PATCH 0/7] MIPS DMA coherence fixes Jiaxun Yang
2023-02-21 12:46 ` Jiaxun Yang
2023-02-21 12:46 ` [PATCH 1/7] MIPS: Remove DMA_PERDEV_COHERENT Jiaxun Yang
2023-02-21 12:46 ` Jiaxun Yang
2023-02-21 17:56 ` Christoph Hellwig [this message]
2023-02-21 17:56 ` Christoph Hellwig
2023-02-21 12:46 ` [PATCH 2/7] MIPS: Always select ARCH_HAS_SYNC_DMA_FOR_CPU for noncoherent platforms Jiaxun Yang
2023-02-21 12:46 ` Jiaxun Yang
2023-02-21 12:46 ` [PATCH 3/7] MIPS: c-r4k: Always install dma flush functions Jiaxun Yang
2023-02-21 12:46 ` Jiaxun Yang
2023-02-21 12:46 ` [PATCH 4/7] dma-mapping: Always provide dma_default_coherent Jiaxun Yang
2023-02-21 12:46 ` Jiaxun Yang
2023-02-21 17:58 ` Christoph Hellwig
2023-02-21 17:58 ` Christoph Hellwig
2023-02-21 19:35 ` Robin Murphy
2023-02-21 19:35 ` Robin Murphy
2023-02-21 19:56 ` Jiaxun Yang
2023-02-21 19:56 ` Jiaxun Yang
2023-02-21 12:46 ` [PATCH 5/7] dma-mapping: Provide CONFIG_ARCH_DMA_DEFAULT_COHERENT Jiaxun Yang
2023-02-21 12:46 ` Jiaxun Yang
2023-02-21 17:58 ` Christoph Hellwig
2023-02-21 17:58 ` Christoph Hellwig
2023-02-21 18:18 ` Jiaxun Yang
2023-02-21 18:18 ` Jiaxun Yang
2023-02-21 12:46 ` [PATCH 6/7] riscv: Select ARCH_DMA_DEFAULT_COHERENT Jiaxun Yang
2023-02-21 12:46 ` Jiaxun Yang
2023-02-21 18:14 ` Conor Dooley
2023-02-21 18:14 ` Conor Dooley
2023-02-21 18:20 ` Jiaxun Yang
2023-02-21 18:20 ` Jiaxun Yang
2023-02-21 12:46 ` [PATCH 7/7] of: address: Use dma_default_coherent to determine default coherency Jiaxun Yang
2023-02-21 12:46 ` Jiaxun Yang
2023-02-21 17:54 ` [PATCH 0/7] MIPS DMA coherence fixes Christoph Hellwig
2023-02-21 17:54 ` Christoph Hellwig
2023-02-21 18:15 ` Jiaxun Yang
2023-02-21 18:15 ` Jiaxun Yang
2023-02-21 19:46 ` Robin Murphy
2023-02-21 19:46 ` Robin Murphy
2023-02-21 19:55 ` Jiaxun Yang
2023-02-21 19:55 ` Jiaxun Yang
2023-02-22 12:55 ` Robin Murphy
2023-02-22 12:55 ` Robin Murphy
2023-02-22 13:04 ` Jiaxun Yang
2023-02-22 13:04 ` Jiaxun Yang
2023-02-22 14:22 ` Robin Murphy
2023-02-22 14:22 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230221175628.GB15247@lst.de \
--to=hch@lst.de \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=m.szyprowski@samsung.com \
--cc=mpe@ellerman.id.au \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.