All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] boot/grub2: add information where is configuration file
@ 2023-01-09  7:33 AndreiCherniaev
  2023-02-21 22:01 ` Thomas Petazzoni via buildroot
  0 siblings, 1 reply; 2+ messages in thread
From: AndreiCherniaev @ 2023-01-09  7:33 UTC (permalink / raw)
  To: buildroot; +Cc: Thomas Petazzoni

because file
boot/grub2/grub.cfg
contains menu. If you want add, rename something in menu use grub.cfg file. This is example of grub.cfg
menuentry "Buildroot" {
	linux /boot/bzImage root=/dev/sda1 rootwait console=tty1
}

Signed-off-by: AndreiCherniaev <cherniaev.andrei@kairo.space>
---
 boot/grub2/Config.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/boot/grub2/Config.in b/boot/grub2/Config.in
index 92b5dd501b..bf0400c08f 100644
--- a/boot/grub2/Config.in
+++ b/boot/grub2/Config.in
@@ -125,6 +125,7 @@ config BR2_TARGET_GRUB2_BUILTIN_CONFIG_PC
 	  into the Grub image itself. This allows to set the root
 	  device and other configuration parameters, but however menu
 	  entries cannot be described in this embedded configuration.
+	  Use boot/grub2/grub.cfg to edit menu entries.
 
 endif # BR2_TARGET_GRUB2_HAS_LEGACY_BOOT
 
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Buildroot] [PATCH] boot/grub2: add information where is configuration file
  2023-01-09  7:33 [Buildroot] [PATCH] boot/grub2: add information where is configuration file AndreiCherniaev
@ 2023-02-21 22:01 ` Thomas Petazzoni via buildroot
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni via buildroot @ 2023-02-21 22:01 UTC (permalink / raw)
  To: AndreiCherniaev; +Cc: buildroot

Hello Andrei,

On Mon,  9 Jan 2023 16:33:52 +0900
AndreiCherniaev <cherniaev.andrei@kairo.space> wrote:

> diff --git a/boot/grub2/Config.in b/boot/grub2/Config.in
> index 92b5dd501b..bf0400c08f 100644
> --- a/boot/grub2/Config.in
> +++ b/boot/grub2/Config.in
> @@ -125,6 +125,7 @@ config BR2_TARGET_GRUB2_BUILTIN_CONFIG_PC
>  	  into the Grub image itself. This allows to set the root
>  	  device and other configuration parameters, but however menu
>  	  entries cannot be described in this embedded configuration.
> +	  Use boot/grub2/grub.cfg to edit menu entries.

Actually no, you probably don't want to change boot/grub2/grub.cfg: it
is part of Buildroot itself, and you probably don't want to have
project-specific changes in there.

Instead, you should override it using a rootfs overlay (if grub.cfg is
in $(TARGET_DIR)/boot) or a post-build/post-image script (if it's in
the EFI partition).

I have nevertheless applied your patch, but after tweaking the message
in the help text, and moving it to the main Grub2 option. See:

  https://gitlab.com/buildroot.org/buildroot/-/commit/7692d5beb2d9e4d0b463f0f26a177829e5bcc1ec

Best regards,

Thomas Petazzoni
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-02-21 22:02 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-09  7:33 [Buildroot] [PATCH] boot/grub2: add information where is configuration file AndreiCherniaev
2023-02-21 22:01 ` Thomas Petazzoni via buildroot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.