From: Carlos Maiolino <cem@kernel.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: linux-xfs@vger.kernel.org, daan.j.demeyer@gmail.com
Subject: Re: [PATCH 1/5] xfs_spaceman: fix broken -g behavior in freesp command
Date: Wed, 22 Feb 2023 09:40:18 +0100 [thread overview]
Message-ID: <20230222084018.spanredntrvnkiry@andromeda> (raw)
In-Reply-To: <167658437328.3590000.18137446679798085024.stgit@magnolia>
On Thu, Feb 16, 2023 at 01:52:53PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> Don't zero out the histogram bucket count when turning on group summary
> mode -- this will screw up the data structures and it's pointless.
>
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>
> ---
> spaceman/freesp.c | 1 -
> 1 file changed, 1 deletion(-)
>
>
> diff --git a/spaceman/freesp.c b/spaceman/freesp.c
> index 423568a4248..70dcdb5c923 100644
> --- a/spaceman/freesp.c
> +++ b/spaceman/freesp.c
> @@ -284,7 +284,6 @@ init(
> speced = 1;
> break;
> case 'g':
> - histcount = 0;
> gflag++;
> break;
> case 'h':
>
--
Carlos Maiolino
next prev parent reply other threads:[~2023-02-22 8:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-16 21:52 [PATCHSET 0/5] xfsprogs: random fixes for 6.2 Darrick J. Wong
2023-02-16 21:52 ` [PATCH 1/5] xfs_spaceman: fix broken -g behavior in freesp command Darrick J. Wong
2023-02-22 8:40 ` Carlos Maiolino [this message]
2023-02-16 21:52 ` [PATCH 2/5] xfs_scrub: fix broken realtime free blocks unit conversions Darrick J. Wong
2023-02-22 8:44 ` Carlos Maiolino
2023-02-16 21:53 ` [PATCH 3/5] xfs_io: set fs_path when opening files on foreign filesystems Darrick J. Wong
2023-02-22 8:46 ` Carlos Maiolino
2023-02-16 21:53 ` [PATCH 4/5] xfs_io: fix bmap command not detecting realtime files with xattrs Darrick J. Wong
2023-02-22 8:48 ` Carlos Maiolino
2023-02-16 21:53 ` [PATCH 5/5] mkfs: substitute slashes with spaces in protofiles Darrick J. Wong
2023-02-22 9:03 ` Carlos Maiolino
2023-02-22 16:37 ` Darrick J. Wong
2023-02-23 8:48 ` Carlos Maiolino
2023-02-23 22:03 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230222084018.spanredntrvnkiry@andromeda \
--to=cem@kernel.org \
--cc=daan.j.demeyer@gmail.com \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.