All of lore.kernel.org
 help / color / mirror / Atom feed
From: Carlos Maiolino <cem@kernel.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
	linux-xfs@vger.kernel.org, daan.j.demeyer@gmail.com
Subject: Re: [PATCH 4/5] xfs_io: fix bmap command not detecting realtime files with xattrs
Date: Wed, 22 Feb 2023 09:48:54 +0100	[thread overview]
Message-ID: <20230222084854.psipute2rappob4m@andromeda> (raw)
In-Reply-To: <167658439020.3590000.194008272775624083.stgit@magnolia>

On Thu, Feb 16, 2023 at 01:53:10PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
> 
> Fix the bmap command so that it will detect a realtime file if any of
> the other file flags (e.g. xattrs) are set.  Observed via xfs/556.
> 
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> Reviewed-by: Christoph Hellwig <hch@lst.de>

Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>

> ---
>  io/bmap.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> 
> diff --git a/io/bmap.c b/io/bmap.c
> index 27383ca6037..722a389baaa 100644
> --- a/io/bmap.c
> +++ b/io/bmap.c
> @@ -118,7 +118,7 @@ bmap_f(
>  			return 0;
>  		}
> 
> -		if (fsx.fsx_xflags == FS_XFLAG_REALTIME) {
> +		if (fsx.fsx_xflags & FS_XFLAG_REALTIME) {
>  			/*
>  			 * ag info not applicable to rt, continue
>  			 * without ag output.
> 

-- 
Carlos Maiolino

  reply	other threads:[~2023-02-22  8:49 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-16 21:52 [PATCHSET 0/5] xfsprogs: random fixes for 6.2 Darrick J. Wong
2023-02-16 21:52 ` [PATCH 1/5] xfs_spaceman: fix broken -g behavior in freesp command Darrick J. Wong
2023-02-22  8:40   ` Carlos Maiolino
2023-02-16 21:52 ` [PATCH 2/5] xfs_scrub: fix broken realtime free blocks unit conversions Darrick J. Wong
2023-02-22  8:44   ` Carlos Maiolino
2023-02-16 21:53 ` [PATCH 3/5] xfs_io: set fs_path when opening files on foreign filesystems Darrick J. Wong
2023-02-22  8:46   ` Carlos Maiolino
2023-02-16 21:53 ` [PATCH 4/5] xfs_io: fix bmap command not detecting realtime files with xattrs Darrick J. Wong
2023-02-22  8:48   ` Carlos Maiolino [this message]
2023-02-16 21:53 ` [PATCH 5/5] mkfs: substitute slashes with spaces in protofiles Darrick J. Wong
2023-02-22  9:03   ` Carlos Maiolino
2023-02-22 16:37     ` Darrick J. Wong
2023-02-23  8:48       ` Carlos Maiolino
2023-02-23 22:03         ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230222084854.psipute2rappob4m@andromeda \
    --to=cem@kernel.org \
    --cc=daan.j.demeyer@gmail.com \
    --cc=djwong@kernel.org \
    --cc=hch@lst.de \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.