From: Florian Westphal <fw@strlen.de>
To: Florian Westphal <fw@strlen.de>
Cc: Sriram Yagnaraman <sriram.yagnaraman@est.tech>,
netfilter-devel@vger.kernel.org,
Pablo Neira Ayuso <pablo@netfilter.org>
Subject: Re: [RFC nf-next PATCH] netfilter: nft: introduce broute chain type
Date: Wed, 22 Feb 2023 12:49:01 +0100 [thread overview]
Message-ID: <20230222114901.GF12484@breakpoint.cc> (raw)
In-Reply-To: <20230222113731.GE12484@breakpoint.cc>
Florian Westphal <fw@strlen.de> wrote:
> The br_netfilter_broute flag is required, but I don't like a new chain
> type for this, nor keeping the drop/accept override.
>
> I'd add a new "broute" expression that sets the flag in the skb cb
> and sets NF_ACCEPT, useable in bridge family -- I think that this would
> be much more readable.
Or, even simpler, extend nft_meta_bridge.c and extend nft userspace to
support:
nft ... meta broute set 1 accept
We also support nftrace this way, so there is precedence for it.
next prev parent reply other threads:[~2023-02-22 11:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-22 11:03 [RFC nf-next PATCH] netfilter: nft: introduce broute chain type Sriram Yagnaraman
2023-02-22 11:37 ` Florian Westphal
2023-02-22 11:49 ` Florian Westphal [this message]
2023-02-22 16:37 ` Sriram Yagnaraman
2023-02-23 9:06 ` Pablo Neira Ayuso
2023-02-22 16:36 ` Sriram Yagnaraman
2023-02-22 22:17 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230222114901.GF12484@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=sriram.yagnaraman@est.tech \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.