[meta-rockchip][PATCH] nanopi-r4s: add

[meta-rockchip][PATCH] nanopi-r4s: add

[Trevor Woerner]

Add a MACHINE definition for the FriendlyElec NanoPi R2S
https://www.friendlyelec.com/index.php?route=product/product&product_id=284

My testing shows that there still seems to be some issues with the SDcard
voltage regulator. The kernel has a number of fix attempts for this issue, but
I've seen it a couple times. Ejecting and re-inserting the SDcard gets past
the issue. Some SDcards show the issue, others don't.

Signed-off-by: Trevor Woerner <twoerner@gmail.com>
---
 README                                     |  1 +
 conf/machine/nanopi-r4s.conf               | 12 ++++++++++++
 recipes-kernel/linux/linux-yocto%.bbappend |  1 +
 3 files changed, 14 insertions(+)
 create mode 100644 conf/machine/nanopi-r4s.conf

diff --git a/README b/README
index d66ed7e79bd2..286dafbe1020 100644
--- a/README
+++ b/README
@@ -29,6 +29,7 @@ Status of supported boards:
 		tinker-board-s
 		vyasa-rk3288
 		firefly-rk3288
+		nanopi-r4s
 	builds:
 		marsboard-rk3066
 		radxarock
diff --git a/conf/machine/nanopi-r4s.conf b/conf/machine/nanopi-r4s.conf
new file mode 100644
index 000000000000..e3323e03b61a
--- /dev/null
+++ b/conf/machine/nanopi-r4s.conf
@@ -0,0 +1,12 @@
+#@TYPE: Machine
+#@NAME: NanoPi R4S
+#@DESCRIPTION: NanoPi R2S is a high-end FriendlyElec mini-router based on the RK3399 SoC
+
+MACHINEOVERRIDES =. "nanopi-r4s:"
+
+require conf/machine/include/rk3399.inc
+
+MACHINE_EXTRA_RRECOMMENDS += "kernel-modules"
+
+KERNEL_DEVICETREE = "rockchip/rk3399-nanopi-r4s.dtb"
+UBOOT_MACHINE = "nanopi-r4s-rk3399_defconfig"
diff --git a/recipes-kernel/linux/linux-yocto%.bbappend b/recipes-kernel/linux/linux-yocto%.bbappend
index 470dc0911ca0..7680d0372e36 100644
--- a/recipes-kernel/linux/linux-yocto%.bbappend
+++ b/recipes-kernel/linux/linux-yocto%.bbappend
@@ -10,5 +10,6 @@ COMPATIBLE_MACHINE:nanopi-m4 = "nanopi-m4"
 COMPATIBLE_MACHINE:nanopi-m4-2gb = "nanopi-m4-2gb"
 COMPATIBLE_MACHINE:rock64 = "rock64"
 COMPATIBLE_MACHINE:rock-pi-e = "rock-pi-e"
+COMPATIBLE_MACHINE:nanopi-r4s = "nanopi-r4s"
 
 FILESEXTRAPATHS:prepend := "${THISDIR}/files:"
-- 
2.36.0.rc2.17.g4027e30c53

Re: [yocto] [meta-rockchip][PATCH] nanopi-r4s: add

[Quentin Schulz]

Hi Trevor,

On 2/22/23 21:09, Trevor Woerner wrote:
> Add a MACHINE definition for the FriendlyElec NanoPi R2S
> https://urldefense.com/v3/__https://www.friendlyelec.com/index.php?route=product*product&product_id=284__;Lw!!OOPJP91ZZw!h-oSfHR_L6CGxqg2FDVatV20vOBPECbLP6rgKxl1ZfpRBpCKAywDT8kUfG-XYW_cCgvwd8DxfcDWrqwnYx8cY6nC-ubOB4w$
> 
> My testing shows that there still seems to be some issues with the SDcard
> voltage regulator. The kernel has a number of fix attempts for this issue, but
> I've seen it a couple times. Ejecting and re-inserting the SDcard gets past
> the issue. Some SDcards show the issue, others don't.
> 
> Signed-off-by: Trevor Woerner <twoerner@gmail.com>
> ---
>   README                                     |  1 +
>   conf/machine/nanopi-r4s.conf               | 12 ++++++++++++
>   recipes-kernel/linux/linux-yocto%.bbappend |  1 +
>   3 files changed, 14 insertions(+)
>   create mode 100644 conf/machine/nanopi-r4s.conf
> 
> diff --git a/README b/README
> index d66ed7e79bd2..286dafbe1020 100644
> --- a/README
> +++ b/README
> @@ -29,6 +29,7 @@ Status of supported boards:
>   		tinker-board-s
>   		vyasa-rk3288
>   		firefly-rk3288
> +		nanopi-r4s
>   	builds:
>   		marsboard-rk3066
>   		radxarock
> diff --git a/conf/machine/nanopi-r4s.conf b/conf/machine/nanopi-r4s.conf
> new file mode 100644
> index 000000000000..e3323e03b61a
> --- /dev/null
> +++ b/conf/machine/nanopi-r4s.conf
> @@ -0,0 +1,12 @@
> +#@TYPE: Machine
> +#@NAME: NanoPi R4S
> +#@DESCRIPTION: NanoPi R2S is a high-end FriendlyElec mini-router based on the RK3399 SoC
> +

s/R2S/R4S/

Cheers,
Quentin

Re: [yocto] [meta-rockchip][PATCH] nanopi-r4s: add

[Trevor Woerner]

[-- Attachment #1: Type: text/plain, Size: 2175 bytes --]

On Tue, Feb 28, 2023 at 6:06 AM Quentin Schulz <
quentin.schulz@theobroma-systems.com> wrote:

> Hi Trevor,
>
> On 2/22/23 21:09, Trevor Woerner wrote:
> > Add a MACHINE definition for the FriendlyElec NanoPi R2S
> >
> https://urldefense.com/v3/__https://www.friendlyelec.com/index.php?route=product*product&product_id=284__;Lw!!OOPJP91ZZw!h-oSfHR_L6CGxqg2FDVatV20vOBPECbLP6rgKxl1ZfpRBpCKAywDT8kUfG-XYW_cCgvwd8DxfcDWrqwnYx8cY6nC-ubOB4w$
> >
> > My testing shows that there still seems to be some issues with the SDcard
> > voltage regulator. The kernel has a number of fix attempts for this
> issue, but
> > I've seen it a couple times. Ejecting and re-inserting the SDcard gets
> past
> > the issue. Some SDcards show the issue, others don't.
> >
> > Signed-off-by: Trevor Woerner <twoerner@gmail.com>
> > ---
> >   README                                     |  1 +
> >   conf/machine/nanopi-r4s.conf               | 12 ++++++++++++
> >   recipes-kernel/linux/linux-yocto%.bbappend |  1 +
> >   3 files changed, 14 insertions(+)
> >   create mode 100644 conf/machine/nanopi-r4s.conf
> >
> > diff --git a/README b/README
> > index d66ed7e79bd2..286dafbe1020 100644
> > --- a/README
> > +++ b/README
> > @@ -29,6 +29,7 @@ Status of supported boards:
> >               tinker-board-s
> >               vyasa-rk3288
> >               firefly-rk3288
> > +             nanopi-r4s
> >       builds:
> >               marsboard-rk3066
> >               radxarock
> > diff --git a/conf/machine/nanopi-r4s.conf b/conf/machine/nanopi-r4s.conf
> > new file mode 100644
> > index 000000000000..e3323e03b61a
> > --- /dev/null
> > +++ b/conf/machine/nanopi-r4s.conf
> > @@ -0,0 +1,12 @@
> > +#@TYPE: Machine
> > +#@NAME: NanoPi R4S
> > +#@DESCRIPTION: NanoPi R2S is a high-end FriendlyElec mini-router based
> on the RK3399 SoC
> > +
>
> s/R2S/R4S/
>
>
Nice catch, thanks! :-)

Turns out the SDcard issue I was seeing was bizarre too, I have many cards
lying around, out of pure luck the 2 I tried were bad, all the rest are
fine.

However, I did find a patch for a soft-reboot SDcard issue that seems to
help.

I'll be sending a v2 when I cycle back around to it.


> Cheers,
> Quentin
>

[-- Attachment #2: Type: text/html, Size: 3426 bytes --]